Re: [PATCH] iommu: Avoid NULL group dereference

2017-08-18 Thread Joerg Roedel
On Thu, Aug 17, 2017 at 05:56:23PM +0100, Robin Murphy wrote: > On 17/08/17 16:41, Joerg Roedel wrote: > > Okay, so just to check I got it right: Drivers do the above to check > > whether a device is managed by an IOMMU, and that crashes now because > > the 'group == NULL' check was removed? > >

Re: [PATCH] iommu: Avoid NULL group dereference

2017-08-17 Thread Shawn Lin
Hi On 2017/8/17 18:40, Robin Murphy wrote: The recently-removed FIXME in iommu_get_domain_for_dev() turns out to have been a little misleading, since that check is still worthwhile even when groups *are* universal. We have a few IOMMU-aware drivers which only care whether their device is

Re: [PATCH] iommu: Avoid NULL group dereference

2017-08-17 Thread Robin Murphy
On 17/08/17 16:41, Joerg Roedel wrote: > On Thu, Aug 17, 2017 at 11:40:08AM +0100, Robin Murphy wrote: >> The recently-removed FIXME in iommu_get_domain_for_dev() turns out to >> have been a little misleading, since that check is still worthwhile even >> when groups *are* universal. We have a few

Re: [PATCH] iommu: Avoid NULL group dereference

2017-08-17 Thread Joerg Roedel
On Thu, Aug 17, 2017 at 11:40:08AM +0100, Robin Murphy wrote: > The recently-removed FIXME in iommu_get_domain_for_dev() turns out to > have been a little misleading, since that check is still worthwhile even > when groups *are* universal. We have a few IOMMU-aware drivers which > only care

Re: [PATCH] iommu: Avoid NULL group dereference

2017-08-17 Thread Marc Zyngier
On 17/08/17 11:40, Robin Murphy wrote: > The recently-removed FIXME in iommu_get_domain_for_dev() turns out to > have been a little misleading, since that check is still worthwhile even > when groups *are* universal. We have a few IOMMU-aware drivers which > only care whether their device is

[PATCH] iommu: Avoid NULL group dereference

2017-08-17 Thread Robin Murphy
The recently-removed FIXME in iommu_get_domain_for_dev() turns out to have been a little misleading, since that check is still worthwhile even when groups *are* universal. We have a few IOMMU-aware drivers which only care whether their device is already attached to an existing domain or not, for