Re: [PATCH] iommu: rockchip: Drop verbose prints in the interrupt handler

2018-09-27 Thread Marc Zyngier
On 26/09/18 18:31, Ezequiel Garcia wrote: On Tue, 2018-09-25 at 13:29 +0200, Joerg Roedel wrote: On Thu, Aug 30, 2018 at 07:28:32PM -0300, Ezequiel Garcia wrote: Printing verbosely via WARN macros and friends in interrupt handlers is strongly discouraged. Drop them and use proper ratelimited pr

Re: [PATCH] iommu: rockchip: Drop verbose prints in the interrupt handler

2018-09-26 Thread Ezequiel Garcia
On Tue, 2018-09-25 at 13:29 +0200, Joerg Roedel wrote: > On Thu, Aug 30, 2018 at 07:28:32PM -0300, Ezequiel Garcia wrote: > > Printing verbosely via WARN macros and friends in interrupt handlers > > is strongly discouraged. Drop them and use proper ratelimited > > prints. > > > > Signed-off-by: Ez

Re: [PATCH] iommu: rockchip: Drop verbose prints in the interrupt handler

2018-09-25 Thread Joerg Roedel
On Thu, Aug 30, 2018 at 07:28:32PM -0300, Ezequiel Garcia wrote: > Printing verbosely via WARN macros and friends in interrupt handlers > is strongly discouraged. Drop them and use proper ratelimited > prints. > > Signed-off-by: Ezequiel Garcia > --- > drivers/iommu/rockchip-iommu.c | 10 ++-

Re: [PATCH] iommu: rockchip: Drop verbose prints in the interrupt handler

2018-09-10 Thread Heiko Stuebner
Am Freitag, 31. August 2018, 00:28:32 CEST schrieb Ezequiel Garcia: > Printing verbosely via WARN macros and friends in interrupt handlers > is strongly discouraged. Drop them and use proper ratelimited > prints. > > Signed-off-by: Ezequiel Garcia Reviewed-by: Heiko Stuebner _

[PATCH] iommu: rockchip: Drop verbose prints in the interrupt handler

2018-08-30 Thread Ezequiel Garcia
Printing verbosely via WARN macros and friends in interrupt handlers is strongly discouraged. Drop them and use proper ratelimited prints. Signed-off-by: Ezequiel Garcia --- drivers/iommu/rockchip-iommu.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/iomm