Re: [PATCH -next] iommu/exynos: Fix return value check in exynos_iommu_of_setup()

2016-07-18 Thread Marek Szyprowski
Hello, On 2016-07-06 15:09, Krzysztof Kozlowski wrote: On 07/06/2016 02:15 PM, weiyj...@163.com wrote: From: Wei Yongjun In case of error, the function of_platform_device_create() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check

Re: [PATCH -next] iommu/exynos: Fix return value check in exynos_iommu_of_setup()

2016-07-06 Thread Wei Yongjun
Hi, > just a question, > >>> pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root); >>> - if (IS_ERR(pdev)) >>> - return PTR_ERR(pdev); >>> + if (!pdev) >>> + return -ENOMEM; >>> >>> /* >>> * use the first registered sysmmu device for

Re: [PATCH -next] iommu/exynos: Fix return value check in exynos_iommu_of_setup()

2016-07-06 Thread Andi Shyti
Hi, just a question, > > pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root); > > - if (IS_ERR(pdev)) > > - return PTR_ERR(pdev); > > + if (!pdev) > > + return -ENOMEM; > > > > /* > > * use the first registered sysmmu device for

Re: [PATCH -next] iommu/exynos: Fix return value check in exynos_iommu_of_setup()

2016-07-06 Thread Krzysztof Kozlowski
On 07/06/2016 02:15 PM, weiyj...@163.com wrote: > From: Wei Yongjun > > In case of error, the function of_platform_device_create() returns > NULL pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test. > >

Re: [PATCH -next] iommu/exynos: Fix return value check in exynos_iommu_of_setup()

2016-07-06 Thread Dennis Chen
On Wed, Jul 06, 2016 at 12:15:54PM +, weiyj...@163.com wrote: > From: Wei Yongjun > > In case of error, the function of_platform_device_create() returns > NULL pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL

[PATCH -next] iommu/exynos: Fix return value check in exynos_iommu_of_setup()

2016-07-06 Thread weiyj_lk
From: Wei Yongjun In case of error, the function of_platform_device_create() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun ---