Re: [PATCH 03/16] PCI/P2PDMA: Attempt to set map_type if it has not been set

On 5/2/21 3:58 PM, John Hubbard wrote: On 4/8/21 10:01 AM, Logan Gunthorpe wrote: Attempt to find the mapping type for P2PDMA pages on the first DMA map attempt if it has not been done ahead of time. Previously, the mapping type was expected to be calculated ahead of time, but if pages are to c

Re: [PATCH 03/16] PCI/P2PDMA: Attempt to set map_type if it has not been set

On 2021-05-03 12:35 p.m., Christoph Hellwig wrote: > On Mon, May 03, 2021 at 10:17:59AM -0600, Logan Gunthorpe wrote: >> I agree that some of this has evolved in a way that some of the names >> are a bit odd now. Could definitely use a cleanup, but that's not really >> part of this series. When

Re: [PATCH 03/16] PCI/P2PDMA: Attempt to set map_type if it has not been set

On Mon, May 03, 2021 at 10:17:59AM -0600, Logan Gunthorpe wrote: > I agree that some of this has evolved in a way that some of the names > are a bit odd now. Could definitely use a cleanup, but that's not really > part of this series. When I have some time I can look at doing a cleanup > series to

Re: [PATCH 03/16] PCI/P2PDMA: Attempt to set map_type if it has not been set

On 5/3/21 9:17 AM, Logan Gunthorpe wrote: Returning a "bridge distance" from a "get map type" routine is jarring, and I think it is because of a pre-existing problem: the above function is severely misnamed. Let's try renaming it (and the other one) to approximately: upstream_bridge_map_ty

Re: [PATCH 03/16] PCI/P2PDMA: Attempt to set map_type if it has not been set

On 2021-05-02 1:58 p.m., John Hubbard wrote: > On 4/8/21 10:01 AM, Logan Gunthorpe wrote: >> Attempt to find the mapping type for P2PDMA pages on the first >> DMA map attempt if it has not been done ahead of time. >> >> Previously, the mapping type was expected to be calculated ahead of >> time,

Re: [PATCH 03/16] PCI/P2PDMA: Attempt to set map_type if it has not been set

On 4/8/21 10:01 AM, Logan Gunthorpe wrote: Attempt to find the mapping type for P2PDMA pages on the first DMA map attempt if it has not been done ahead of time. Previously, the mapping type was expected to be calculated ahead of time, but if pages are to come from userspace then there's no way t

[PATCH 03/16] PCI/P2PDMA: Attempt to set map_type if it has not been set

Attempt to find the mapping type for P2PDMA pages on the first DMA map attempt if it has not been done ahead of time. Previously, the mapping type was expected to be calculated ahead of time, but if pages are to come from userspace then there's no way to ensure the path was checked ahead of time.