Re: [PATCH 1/1] iommu/vt-d: Fix misuse of iommu_domain_identity_map()

[Jerry Snitselaar]

On Fri Jun 19 20, Lu Baolu wrote:

The iommu_domain_identity_map() helper takes start/end PFN as arguments.
Fix a misuse case where the start and end addresses are passed.

Fixes: e70b081c6f376 ("iommu/vt-d: Remove IOVA handling code from the non-dma_ops 
path")
Cc: Tom Murphy 
Reported-by: Alex Williamson 
Signed-off-by: Lu Baolu 


Reviewed-by: Jerry Snitselaar 

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH 1/1] iommu/vt-d: Fix misuse of iommu_domain_identity_map()

[Lu Baolu]

The iommu_domain_identity_map() helper takes start/end PFN as arguments.
Fix a misuse case where the start and end addresses are passed.

Fixes: e70b081c6f376 ("iommu/vt-d: Remove IOVA handling code from the 
non-dma_ops path")
Cc: Tom Murphy 
Reported-by: Alex Williamson 
Signed-off-by: Lu Baolu 
---
 drivers/iommu/intel/iommu.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index f16bf63ea9fd..d759e7234e98 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -2701,7 +2701,9 @@ static int __init si_domain_init(int hw)
end >> agaw_to_width(si_domain->agaw)))
continue;
 
-   ret = iommu_domain_identity_map(si_domain, start, end);
+   ret = iommu_domain_identity_map(si_domain,
+   mm_to_dma_pfn(start >> PAGE_SHIFT),
+   mm_to_dma_pfn(end >> PAGE_SHIFT));
if (ret)
return ret;
}
-- 
2.17.1

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu