[PATCH 1/2] iommu/exynos: fix runtime pm support

2012-04-11 Thread Marek Szyprowski 
Fix registration to runtime pw and add missing resume callback.

Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
---
 drivers/iommu/exynos-iommu.c |   20 ++--
 1 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index b8daf7c..eef924d 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -651,8 +651,7 @@ static int exynos_sysmmu_probe(struct platform_device *pdev)
 
__set_fault_handler(data, default_fault_handler);
 
-   if (dev-parent)
-   pm_runtime_enable(dev);
+   pm_runtime_enable(dev);
 
dev_dbg(dev, (%s) Initialized\n, data-dbgname);
return 0;
@@ -674,11 +673,28 @@ err_alloc:
return ret;
 }
 
+static int exynos_pm_resume(struct device *dev)
+{
+   struct sysmmu_drvdata *data;
+
+   data = dev_get_drvdata(dev);
+
+   if (is_sysmmu_active(data))
+   __exynos_sysmmu_enable(data, data-pgtable, NULL);
+
+   return 0;
+}
+
+const struct dev_pm_ops exynos_pm_ops = {
+   .resume = exynos_pm_resume,
+};
+
 static struct platform_driver exynos_sysmmu_driver = {
.probe  = exynos_sysmmu_probe,
.driver = {
.owner  = THIS_MODULE,
.name   = exynos-sysmmu,
+   .pm = exynos_pm_ops,
}
 };
 
-- 
1.7.1.569.g6f426

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 1/2] iommu/exynos: fix runtime pm support

2012-04-11 Thread Sergei Shtylyov 

Hello.

Marek Szyprowski wrote:


Fix registration to runtime pw and add missing resume callback.



Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
---
 drivers/iommu/exynos-iommu.c |   20 ++--
 1 files changed, 18 insertions(+), 2 deletions(-)



diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index b8daf7c..eef924d 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c

[...]

@@ -674,11 +673,28 @@ err_alloc:
return ret;
 }
 
+static int exynos_pm_resume(struct device *dev)

+{
+   struct sysmmu_drvdata *data;
+
+   data = dev_get_drvdata(dev);


   Why not do it right in the initializer?

WBR, Sergei

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu