Re: [PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages

2021-04-01 Thread Robin Murphy
On 2021-04-01 10:39, Geert Uytterhoeven wrote: Hi Steven, On Wed, Mar 31, 2021 at 3:40 PM Steven Rostedt wrote: On Wed, 31 Mar 2021 11:31:03 +0200 Geert Uytterhoeven wrote: This reduces kernel size by ca. 0.5 KiB. If you are worried about size, disable tracing and it will go away

Re: [PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages

2021-04-01 Thread Geert Uytterhoeven
Hi Steven, On Wed, Mar 31, 2021 at 3:40 PM Steven Rostedt wrote: > On Wed, 31 Mar 2021 11:31:03 +0200 > Geert Uytterhoeven wrote: > > > This reduces kernel size by ca. 0.5 KiB. > > If you are worried about size, disable tracing and it will go away > entirely. 0.5KiB is a drop in the bucket

Re: [PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages

2021-04-01 Thread Petr Mladek via iommu
On Wed 2021-03-31 09:40:07, Steven Rostedt wrote: > On Wed, 31 Mar 2021 11:31:03 +0200 > Geert Uytterhoeven wrote: > > > This reduces kernel size by ca. 0.5 KiB. > > If you are worried about size, disable tracing and it will go away > entirely. 0.5KiB is a drop in the bucket compared to what

Re: [PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages

2021-03-31 Thread Steven Rostedt
On Wed, 31 Mar 2021 11:31:03 +0200 Geert Uytterhoeven wrote: > This reduces kernel size by ca. 0.5 KiB. If you are worried about size, disable tracing and it will go away entirely. 0.5KiB is a drop in the bucket compared to what tracing adds in size overhead. Sorry, but NAK. This has been

[PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages

2021-03-31 Thread Geert Uytterhoeven
While long fancy messages have a higher probability of being seen than small messages, they may scroll of the screen fast, if visible at all, and may still be missed. In addition, they increase boot time and kernel size. The correct mechanism to increase importance of a kernel message is not to