Re: [PATCH 3/4] iommu: Remove pci.h include from trace/events/iommu.h
Hi Joerg, [auto build test WARNING on linus/master] [also build test WARNING on v4.11-rc8 next-20170426] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Joerg-Roedel/iommu-Header-file-cleanups/20170427-160734 config: tile-allmodconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=tile All warnings (new ones prefixed by >>): In file included from drivers/infiniband//hw/qedr/main.c:39:0: >> include/linux/qed/qede_roce.h:57:12: warning: 'struct pci_dev' declared >> inside parameter list [enabled by default] >> include/linux/qed/qede_roce.h:57:12: warning: its scope is only this >> definition or declaration, which is probably not what you want [enabled by >> default] >> drivers/infiniband//hw/qedr/main.c:905:2: warning: initialization from >> incompatible pointer type [enabled by default] drivers/infiniband//hw/qedr/main.c:905:2: warning: (near initialization for 'qedr_drv.add') [enabled by default] -- In file included from drivers/infiniband/hw/qedr/main.c:39:0: >> include/linux/qed/qede_roce.h:57:12: warning: 'struct pci_dev' declared >> inside parameter list [enabled by default] >> include/linux/qed/qede_roce.h:57:12: warning: its scope is only this >> definition or declaration, which is probably not what you want [enabled by >> default] drivers/infiniband/hw/qedr/main.c:905:2: warning: initialization from incompatible pointer type [enabled by default] drivers/infiniband/hw/qedr/main.c:905:2: warning: (near initialization for 'qedr_drv.add') [enabled by default] vim +57 include/linux/qed/qede_roce.h cee9fbd8 Ram Amrani 2016-10-01 41 QEDE_DOWN, cee9fbd8 Ram Amrani 2016-10-01 42 QEDE_CHANGE_ADDR, cee9fbd8 Ram Amrani 2016-10-01 43 QEDE_CLOSE cee9fbd8 Ram Amrani 2016-10-01 44 }; cee9fbd8 Ram Amrani 2016-10-01 45 cee9fbd8 Ram Amrani 2016-10-01 46 struct qede_roce_event_work { cee9fbd8 Ram Amrani 2016-10-01 47 struct list_head list; cee9fbd8 Ram Amrani 2016-10-01 48 struct work_struct work; cee9fbd8 Ram Amrani 2016-10-01 49 void *ptr; cee9fbd8 Ram Amrani 2016-10-01 50 enum qede_roce_event event; cee9fbd8 Ram Amrani 2016-10-01 51 }; cee9fbd8 Ram Amrani 2016-10-01 52 cee9fbd8 Ram Amrani 2016-10-01 53 struct qedr_driver { cee9fbd8 Ram Amrani 2016-10-01 54 unsigned char name[32]; cee9fbd8 Ram Amrani 2016-10-01 55 cee9fbd8 Ram Amrani 2016-10-01 56 struct qedr_dev* (*add)(struct qed_dev *, struct pci_dev *, cee9fbd8 Ram Amrani 2016-10-01 @57 struct net_device *); cee9fbd8 Ram Amrani 2016-10-01 58 cee9fbd8 Ram Amrani 2016-10-01 59 void (*remove)(struct qedr_dev *); cee9fbd8 Ram Amrani 2016-10-01 60 void (*notify)(struct qedr_dev *, enum qede_roce_event); cee9fbd8 Ram Amrani 2016-10-01 61 }; cee9fbd8 Ram Amrani 2016-10-01 62 cee9fbd8 Ram Amrani 2016-10-01 63 /* APIs for RoCE driver to register callback handlers, cee9fbd8 Ram Amrani 2016-10-01 64 * which will be invoked when device is added, removed, ifup, ifdown cee9fbd8 Ram Amrani 2016-10-01 65 */ :: The code at line 57 was first introduced by commit :: cee9fbd8e2e9e713cd8bf227c6492fd8854de74b qede: Add qedr framework :: TO: Ram Amrani:: CC: David S. Miller --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[PATCH 3/4] iommu: Remove pci.h include from trace/events/iommu.h
From: Joerg RoedelThe include file does not need any PCI specifics, so remove that include. Also fix the places that relied on it. Signed-off-by: Joerg Roedel --- arch/arm64/mm/dma-mapping.c| 1 + drivers/iommu/fsl_pamu.h | 1 + drivers/iommu/rockchip-iommu.c | 1 + drivers/iommu/tegra-smmu.c | 1 + include/linux/dma-iommu.h | 1 + include/trace/events/iommu.h | 1 - 6 files changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c index 81cdb2e..982f85b 100644 --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -28,6 +28,7 @@ #include #include #include +#include #include diff --git a/drivers/iommu/fsl_pamu.h b/drivers/iommu/fsl_pamu.h index aab723f..c3434f2 100644 --- a/drivers/iommu/fsl_pamu.h +++ b/drivers/iommu/fsl_pamu.h @@ -20,6 +20,7 @@ #define __FSL_PAMU_H #include +#include #include diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c index 9afcbf7..0ba303a 100644 --- a/drivers/iommu/rockchip-iommu.c +++ b/drivers/iommu/rockchip-iommu.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c index 9305964..eeb19f5 100644 --- a/drivers/iommu/tegra-smmu.c +++ b/drivers/iommu/tegra-smmu.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include diff --git a/include/linux/dma-iommu.h b/include/linux/dma-iommu.h index 5725c94..abd9465 100644 --- a/include/linux/dma-iommu.h +++ b/include/linux/dma-iommu.h @@ -20,6 +20,7 @@ #include #ifdef CONFIG_IOMMU_DMA +#include #include #include diff --git a/include/trace/events/iommu.h b/include/trace/events/iommu.h index 2c7befb..99254ed 100644 --- a/include/trace/events/iommu.h +++ b/include/trace/events/iommu.h @@ -11,7 +11,6 @@ #define _TRACE_IOMMU_H #include -#include struct device; -- 1.9.1 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu