Re: [PATCH 6/6] iommu/arm-smmu: Make use of phandle iterators in device-tree parsing

2016-04-14 Thread Will Deacon
Hi Joerg, On Mon, Apr 04, 2016 at 05:49:22PM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > Remove the usage of of_parse_phandle_with_args() and replace > it by the phandle-iterator implementation so that we can > parse out all of the potentially present 128 stream-ids. >

[PATCH 6/6] iommu/arm-smmu: Make use of phandle iterators in device-tree parsing

2016-04-04 Thread Joerg Roedel
From: Joerg Roedel Remove the usage of of_parse_phandle_with_args() and replace it by the phandle-iterator implementation so that we can parse out all of the potentially present 128 stream-ids. Signed-off-by: Joerg Roedel --- drivers/iommu/arm-smmu.c | 38

Re: [PATCH 6/6] iommu/arm-smmu: Make use of phandle iterators in device-tree parsing

2016-04-04 Thread Joerg Roedel
Hi Will, On Tue, Mar 29, 2016 at 06:22:16PM +0100, Will Deacon wrote: > > + > > + if (i == 0) > > + goto out_put_masters; > > I'm confused by this hunk. If i == 0, then we shouldn't have registered > any masters and therefore out_put_masters won't have anything to do. The idea was

Re: [PATCH 6/6] iommu/arm-smmu: Make use of phandle iterators in device-tree parsing

2016-03-29 Thread Will Deacon
Hi Joerg, On Tue, Mar 22, 2016 at 06:58:29PM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Remove the usage of of_parse_phandle_with_args() and replace > it by the phandle-iterator implementation so that we can > parse out all of the potentially present 128 stream-ids. >

Re: [PATCH 6/6] iommu/arm-smmu: Make use of phandle iterators in device-tree parsing

2016-03-29 Thread Will Deacon
On Wed, Mar 23, 2016 at 12:51:28PM +0100, Joerg Roedel wrote: > On Tue, Mar 22, 2016 at 06:53:48PM +, Robin Murphy wrote: > > In a stream-matching implementation, a device may quite legitimately > > own anything up to _all_ of the stream IDs (32768, or 65536 if we > > ever implement support

Re: [PATCH 6/6] iommu/arm-smmu: Make use of phandle iterators in device-tree parsing

2016-03-23 Thread Joerg Roedel
Hi Robin, On Tue, Mar 22, 2016 at 06:53:48PM +, Robin Murphy wrote: > In a stream-matching implementation, a device may quite legitimately > own anything up to _all_ of the stream IDs (32768, or 65536 if we > ever implement support for the SMMUv2 EXID extension), so this is > only a genuine

Re: [PATCH 6/6] iommu/arm-smmu: Make use of phandle iterators in device-tree parsing

2016-03-22 Thread Robin Murphy
Hi Joerg, On 22/03/16 17:58, Joerg Roedel wrote: From: Joerg Roedel Remove the usage of of_parse_phandle_with_args() and replace it by the phandle-iterator implementation so that we can parse out all of the potentially present 128 stream-ids. In a stream-matching

Re: [PATCH 6/6] iommu/arm-smmu: Make use of phandle iterators in device-tree parsing

2016-03-22 Thread Rob Herring
On Tue, Mar 22, 2016 at 12:58 PM, Joerg Roedel wrote: > From: Joerg Roedel > > Remove the usage of of_parse_phandle_with_args() and replace > it by the phandle-iterator implementation so that we can > parse out all of the potentially present 128 stream-ids. > >

[PATCH 6/6] iommu/arm-smmu: Make use of phandle iterators in device-tree parsing

2016-03-22 Thread Joerg Roedel
From: Joerg Roedel Remove the usage of of_parse_phandle_with_args() and replace it by the phandle-iterator implementation so that we can parse out all of the potentially present 128 stream-ids. Signed-off-by: Joerg Roedel --- drivers/iommu/arm-smmu.c | 28