Re: [PATCH V4 5/6] perf/amd/iommu: Enable support for multiple IOMMUs

2016-02-23 Thread Suravee Suthikulpanit
On 02/23/2016 12:24 PM, Alex Williamson wrote: On Tue, 23 Feb 2016 12:12:42 +0700 Suravee Suthikulpanit wrote: Hi On 02/22/2016 09:07 PM, Peter Zijlstra wrote: On Mon, Feb 22, 2016 at 03:00:31PM +0700, Suravee Suthikulpanit wrote: So I really don't have time to review new muck while I'm h

Re: [PATCH V4 5/6] perf/amd/iommu: Enable support for multiple IOMMUs

2016-02-22 Thread Alex Williamson
On Tue, 23 Feb 2016 12:12:42 +0700 Suravee Suthikulpanit wrote: > Hi > > On 02/22/2016 09:07 PM, Peter Zijlstra wrote: > > On Mon, Feb 22, 2016 at 03:00:31PM +0700, Suravee Suthikulpanit wrote: > >>> So I really don't have time to review new muck while I'm hunting perf > >>> core fail, but Bor

Re: [PATCH V4 5/6] perf/amd/iommu: Enable support for multiple IOMMUs

2016-02-22 Thread Suravee Suthikulpanit
Hi On 02/22/2016 09:07 PM, Peter Zijlstra wrote: On Mon, Feb 22, 2016 at 03:00:31PM +0700, Suravee Suthikulpanit wrote: So I really don't have time to review new muck while I'm hunting perf core fail, but Boris made me look at this. This is crazy, if you have multiple IOMMUs then create an eve

Re: [PATCH V4 5/6] perf/amd/iommu: Enable support for multiple IOMMUs

2016-02-22 Thread Peter Zijlstra
On Mon, Feb 22, 2016 at 03:00:31PM +0700, Suravee Suthikulpanit wrote: > >So I really don't have time to review new muck while I'm hunting perf > >core fail, but Boris made me look at this. > > > >This is crazy, if you have multiple IOMMUs then create an event per > >IOMMU, do _NOT_ fold them all i

Re: [PATCH V4 5/6] perf/amd/iommu: Enable support for multiple IOMMUs

2016-02-22 Thread Suravee Suthikulpanit
Hi Peter, On 02/18/2016 08:18 PM, Peter Zijlstra wrote: On Thu, Feb 11, 2016 at 04:15:26PM +0700, Suravee Suthikulpanit wrote: static void perf_iommu_read(struct perf_event *event) { + int i; u64 delta = 0ULL; struct hw_perf_event *hwc = &event->hw; + struct perf

Re: [PATCH V4 5/6] perf/amd/iommu: Enable support for multiple IOMMUs

2016-02-18 Thread Borislav Petkov
On Thu, Feb 11, 2016 at 04:15:26PM +0700, Suravee Suthikulpanit wrote: > The current amd_iommu_pc_get_set_reg_val() does not support muli-IOMMU multi > system. This patch replace amd_iommu_pc_get_set_reg_val() with You don't need to say in the commit message what this patch does - I think most o

Re: [PATCH V4 5/6] perf/amd/iommu: Enable support for multiple IOMMUs

2016-02-18 Thread Peter Zijlstra
On Thu, Feb 11, 2016 at 04:15:26PM +0700, Suravee Suthikulpanit wrote: > static void perf_iommu_read(struct perf_event *event) > { > + int i; > u64 delta = 0ULL; > struct hw_perf_event *hwc = &event->hw; > + struct perf_amd_iommu *perf_iommu = container_of(event->pmu, > +

[PATCH V4 5/6] perf/amd/iommu: Enable support for multiple IOMMUs

2016-02-11 Thread Suravee Suthikulpanit
The current amd_iommu_pc_get_set_reg_val() does not support muli-IOMMU system. This patch replace amd_iommu_pc_get_set_reg_val() with amd_iommu_pc_set_reg_val() and amd_iommu_pc_[set|get]_cnt_vals(). Also, the current struct hw_perf_event.prev_count can only store the previous counter value only f