This patch cleans up:
  * Various bitwise operations in perf_iommu_enable_event
  * Make use macros BIT(x)

This should not affect logic and functionality.

Cc: Borislav Petkov <b...@alien8.de>
Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com>
---
 arch/x86/events/amd/iommu.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c
index ee7b4d3..1a678b9 100644
--- a/arch/x86/events/amd/iommu.c
+++ b/arch/x86/events/amd/iommu.c
@@ -253,21 +253,21 @@ static void perf_iommu_enable_event(struct perf_event *ev)
        amd_iommu_pc_set_reg(0, devid, bank, cntr,
                             IOMMU_PC_COUNTER_SRC_REG, &reg);
 
-       reg = 0ULL | devid | (_GET_DEVID_MASK(ev) << 32);
+       reg = devid | (_GET_DEVID_MASK(ev) << 32);
        if (reg)
-               reg |= (1UL << 31);
+               reg |= BIT(31);
        amd_iommu_pc_set_reg(0, devid, bank, cntr,
                             IOMMU_PC_DEVID_MATCH_REG, &reg);
 
-       reg = 0ULL | _GET_PASID(ev) | (_GET_PASID_MASK(ev) << 32);
+       reg = _GET_PASID(ev) | (_GET_PASID_MASK(ev) << 32);
        if (reg)
-               reg |= (1UL << 31);
+               reg |= BIT(31);
        amd_iommu_pc_set_reg(0, devid, bank, cntr,
                             IOMMU_PC_PASID_MATCH_REG, &reg);
 
-       reg = 0ULL | _GET_DOMID(ev) | (_GET_DOMID_MASK(ev) << 32);
+       reg = _GET_DOMID(ev) | (_GET_DOMID_MASK(ev) << 32);
        if (reg)
-               reg |= (1UL << 31);
+               reg |= BIT(31);
        amd_iommu_pc_set_reg(0, devid, bank, cntr,
                             IOMMU_PC_DOMID_MATCH_REG, &reg);
 }
-- 
1.9.1

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to