Re: [PATCH v1 3/7] iommu/amd: Fix sparse warning

2022-06-27 Thread Vasant Hegde via iommu
On 6/23/2022 3:12 PM, Robin Murphy wrote: > On 2022-06-23 09:03, Joerg Roedel wrote: >> On Fri, Jun 03, 2022 at 04:51:03PM +0530, Vasant Hegde wrote: >>> Fix below sparse warning: >>>    CHECK   drivers/iommu/amd/iommu.c >>>    drivers/iommu/amd/iommu.c:73:24: warning: symbol 'amd_iommu_ops' was

Re: [PATCH v1 3/7] iommu/amd: Fix sparse warning

2022-06-23 Thread Joerg Roedel
On Thu, Jun 23, 2022 at 10:42:52AM +0100, Robin Murphy wrote: > TBH it's probably time to retire iommu_ops->pgsize_bitmap anyway. At the > very least it would be logical to move it to iommu_domain_ops now, but maybe > we could skip ahead and just rely on drivers initialising >

Re: [PATCH v1 3/7] iommu/amd: Fix sparse warning

2022-06-23 Thread Robin Murphy
On 2022-06-23 09:03, Joerg Roedel wrote: On Fri, Jun 03, 2022 at 04:51:03PM +0530, Vasant Hegde wrote: Fix below sparse warning: CHECK drivers/iommu/amd/iommu.c drivers/iommu/amd/iommu.c:73:24: warning: symbol 'amd_iommu_ops' was not declared. Should it be static? Also we are going to

Re: [PATCH v1 3/7] iommu/amd: Fix sparse warning

2022-06-23 Thread Joerg Roedel
On Fri, Jun 03, 2022 at 04:51:03PM +0530, Vasant Hegde wrote: > Fix below sparse warning: > CHECK drivers/iommu/amd/iommu.c > drivers/iommu/amd/iommu.c:73:24: warning: symbol 'amd_iommu_ops' was not > declared. Should it be static? > > Also we are going to introduce v2 page table which has

[PATCH v1 3/7] iommu/amd: Fix sparse warning

2022-06-03 Thread Vasant Hegde via iommu
Fix below sparse warning: CHECK drivers/iommu/amd/iommu.c drivers/iommu/amd/iommu.c:73:24: warning: symbol 'amd_iommu_ops' was not declared. Should it be static? Also we are going to introduce v2 page table which has different pgsize_bitmaps. Hence remove 'const' qualifier. Signed-off-by: