Re: [PATCH v13 00/19] iommu/exynos: Fixes and Enhancements of System MMU driver with DT
On Tue, May 13, 2014 at 10:50 PM, Joerg Roedel j...@8bytes.org wrote: On Mon, May 12, 2014 at 11:44:45AM +0530, Shaik Ameer Basha wrote: Cho KyongHo (18): iommu/exynos: fix build errors iommu/exynos: change error handling when page table update is failed iommu/exynos: allocate lv2 page table from own slab iommu/exynos: fix L2TLB invalidation iommu/exynos: remove prefetch buffer setting iommu/exynos: add missing cache flush for removed page table entries iommu/exynos: always enable runtime PM iommu/exynos: remove dbgname from drvdata of a System MMU iommu/exynos: use managed device helper functions iommu/exynos: gating clocks of master H/W iommu/exynos: remove custom fault handler iommu/exynos: change rwlock to spinlock iommu/exynos: use exynos-iommu specific typedef iommu/exynos: enhanced error messages documentation: iommu: add binding document of Exynos System MMU iommu/exynos: support for device tree iommu/exynos: turn on useful configuration options iommu/exynos: apply workaround of caching fault page table entries .../devicetree/bindings/iommu/samsung,sysmmu.txt | 65 ++ drivers/iommu/exynos-iommu.c | 1035 2 files changed, 677 insertions(+), 423 deletions(-) create mode 100644 Documentation/devicetree/bindings/iommu/samsung,sysmmu.txt Applied, thanks. Please send another patch to update the documentation as requested by Arnd. Hi Joerg, Thanks for applying the series. I posted one patch addressing 'Arnd' comments. Please apply it on top of this series. -- documentation/iommu: Add note on existing DT binding status Regards, Shaik Joerg ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[PATCH v13 00/19] iommu/exynos: Fixes and Enhancements of System MMU driver with DT
This is the subset of previous v12 series and includes only the fixes and enhancements, leaving out the private DT bindings as discussed in the below thread. -- http://www.gossamer-threads.com/lists/linux/kernel/1918178 This patch series includes, 1] fixes for exynos-iommu driver build break 2] includes several bug fixes and enhancements for the exynos-iommu driver 3] code to handle multiple exynos sysmmu versions 4] adding support for device tree Documentation/devicetree/bindings/iommu/samsung,sysmmu.txt Change log: v13: - Rebased to the latest 3.15-rc4 master branch git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master (3.15-rc4) - This patch series is the subset of the previous patch series v12: iommu/exynos: Fixes and Enhancements of System MMU driver with dt Changes incude: - Removed dt bindings and code specific to mmu-masters property - Dropped patch 18/31 from previous patch series as suggested by 'Tomasz Figa'. - Fixes buid break issue in patch 01/19 by merging the following patches from the previous series iommu/exynos: do not include removed header iommu/exynos: fix address handling iommu/exynos: handle one instance of sysmmu with a device descriptor - Shuffled the patches to bring all the fixes and enhancement to the start of the patch series v12: - Rebased to the latest 3.15-rc2 master branch git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master (3.15-rc2) - Addressed v11 review comments from 'Sachin Kamat', 'Tomasz Figa' and 'Shaik Ameer Basha' - Uses macro names instead of magic numbers for clock description in DT - Moved DT binding document to seperate patch - dtsi changes are separated into multiple patches - patch description of some patches are updated according to the review comments - removed the macros which hides the clock operations - review comments related to compatible strings will be fixed in followup patches v11: - Rebased on the latest works on clock, arm/samsung, iommu branches - Change the property to link System MMU and its master H/W 'iommu' in the master's node - 'mmu-masters' in the System MMU's node - Changed compatible string: samsung,sysmmu-v1 samsung,sysmmu-v2 samsung,sysmmu-v3.1 samsung,sysmmu-v3.2 samsung,sysmmu-v3.3 - Change the implementation of retrieving System MMU version - simpler - Check NULL pointer before call to clk_enable() and clk_disable() - Allow a single master to link to multiple System MMUs. (fimc-is, fimd/g2d/Scaler in Exynos5420) - Workarounds of known problems of System MMU - Code enhancements: * Compilable for 64-bit * Enhanced error messages v10: - Rebased on the following branches git.linaro.org/git-ro/people/mturquette/linux.git/clk-next git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git/for-next git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git/next git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master (3.12-rc3) - Set parent clock to all System MMU clocks. - Add clock and DT descriptos for Exynos5420 - Modified error handling in exynos_iommu_init() - Split iommu/exynos: support for device tree patch into the following 6 patches iommu/exynos: handle only one instance of System MMU iommu/exynos: always enable runtime PM iommu/exynos: always use a single clock descriptor iommu/exynos: remove dbgname from drvdata of a System MMU iommu/exynos: use managed driver helper functions iommu/exynos: support for device tree - Remove 'interrupt-names' and 'status' properties from DT - Change n:1 relationship between master:System MMU into 1:1 relationship. - Removed custom fault handler and print the status of System MMU whenever System MMU fault is occurred. - Post Antonios Motakis's commit together: iommu/exynos: add devices attached to the System MMU to an IOMMU group v9: - Rebased on the following branches git.linaro.org/git-ro/people/mturquette/linux.git/clk-next git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git/samsung-next git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master (3.11-rc4) - Split add bus notifier for registering System MMU into 5 patches - Call clk_prepare() that was missing in v8. - Fixed base address of sysmmu_tv in exynos4210.dtsi - BUG_ON() instead of return -EADDRINUSE when trying mapping on an mapped area - Moved camif_top to 317 in drivers/clk/samsung/clk-exynos5250.c - Removed 'iommu' property from 'codec'(mfc) node - Does not make 'master' clock to be the parent of 'sysmmu' clock. 'master' clock is enabled before accessing control registers of System MMU and disabled after the access. v8: - Reordered patch list: moved change rwloc to spinlock to the last. - Fixed remained bug in fix page table maintenance. - Always return 0 from exynos_iommu_attach_device(). - Removed prefetch buffer setting when System MMU is enabled due to the restriction of prefetch buffers: A prefetch buffer must not hit from more than one DMA.
Re: [PATCH v13 00/19] iommu/exynos: Fixes and Enhancements of System MMU driver with DT
On Monday 12 May 2014 11:44:45 Shaik Ameer Basha wrote: This is the subset of previous v12 series and includes only the fixes and enhancements, leaving out the private DT bindings as discussed in the below thread. -- http://www.gossamer-threads.com/lists/linux/kernel/1918178 This patch series includes, 1] fixes for exynos-iommu driver build break 2] includes several bug fixes and enhancements for the exynos-iommu driver 3] code to handle multiple exynos sysmmu versions 4] adding support for device tree Documentation/devicetree/bindings/iommu/samsung,sysmmu.txt The patches look good to me, but please add a note into the samsung,sysmmu.txt file explaining that the binding is incomplete and that it's possible to change in incompatible ways when we add support for attaching devices to the IOMMU through the generic IOMMU binding. Arnd ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
