Re: [PATCH v2 02/37] iommu/amd: Introduce pci segment structure

2022-04-29 Thread Vasant Hegde via iommu
Joerg, On 4/28/2022 3:24 PM, Joerg Roedel wrote: > Hi Vasant, > > On Mon, Apr 25, 2022 at 05:03:40PM +0530, Vasant Hegde wrote: >> +/* >> + * This structure contains information about one PCI segment in the system. >> + */ >> +struct amd_iommu_pci_seg { >> +struct list_head list; > > The

Re: [PATCH v2 02/37] iommu/amd: Introduce pci segment structure

2022-04-28 Thread Joerg Roedel
Hi Vasant, On Mon, Apr 25, 2022 at 05:03:40PM +0530, Vasant Hegde wrote: > +/* > + * This structure contains information about one PCI segment in the system. > + */ > +struct amd_iommu_pci_seg { > + struct list_head list; The purpose of this list_head needs a comment. > + > + /* PCI

[PATCH v2 02/37] iommu/amd: Introduce pci segment structure

2022-04-25 Thread Vasant Hegde via iommu
Newer AMD systems can support multiple PCI segments, where each segment contains one or more IOMMU instances. However, an IOMMU instance can only support a single PCI segment. Current code assumes that system contains only one pci segment (segment 0) and creates global data structures such as