Re: [PATCH v2 08/10] iommu: Remove unused argument in is_attach_deferred

2022-02-13 Thread Lu Baolu
Hi Robin, On 2/9/22 9:52 PM, Robin Murphy wrote: On 2022-02-08 01:25, Lu Baolu wrote: The is_attach_deferred iommu_ops callback is a device op. The domain argument is unnecessary and never used. Remove it to make code clean. Suggested-by: Robin Murphy Signed-off-by: Lu Baolu ---  

Re: [PATCH v2 08/10] iommu: Remove unused argument in is_attach_deferred

2022-02-09 Thread Lu Baolu
On 2/9/22 9:52 PM, Robin Murphy wrote: diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c index 2b5f4e57a8bb..80f1294be634 100644 --- a/drivers/iommu/intel/iommu.c +++ b/drivers/iommu/intel/iommu.c @@ -5052,8 +5052,7 @@ intel_iommu_dev_disable_feat(struct device *dev, enum

Re: [PATCH v2 08/10] iommu: Remove unused argument in is_attach_deferred

2022-02-09 Thread Robin Murphy
On 2022-02-08 01:25, Lu Baolu wrote: The is_attach_deferred iommu_ops callback is a device op. The domain argument is unnecessary and never used. Remove it to make code clean. Suggested-by: Robin Murphy Signed-off-by: Lu Baolu --- include/linux/iommu.h | 2 +-

Re: [PATCH v2 08/10] iommu: Remove unused argument in is_attach_deferred

2022-02-09 Thread Jason Gunthorpe via iommu
On Tue, Feb 08, 2022 at 09:25:57AM +0800, Lu Baolu wrote: > The is_attach_deferred iommu_ops callback is a device op. The domain > argument is unnecessary and never used. Remove it to make code clean. > > Suggested-by: Robin Murphy > Signed-off-by: Lu Baolu > --- > include/linux/iommu.h

Re: [PATCH v2 08/10] iommu: Remove unused argument in is_attach_deferred

2022-02-08 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH v2 08/10] iommu: Remove unused argument in is_attach_deferred

2022-02-07 Thread Lu Baolu
The is_attach_deferred iommu_ops callback is a device op. The domain argument is unnecessary and never used. Remove it to make code clean. Suggested-by: Robin Murphy Signed-off-by: Lu Baolu --- include/linux/iommu.h | 2 +- drivers/iommu/amd/amd_iommu.h | 3 +--