Re: [PATCH v2 1/2] iommu/tegra: gart: Optionally check for overwriting of page mappings

2017-10-13 Thread Dmitry Osipenko
On 13.10.2017 11:38, Joerg Roedel wrote: > On Thu, Oct 12, 2017 at 05:27:26PM +0300, Dmitry Osipenko wrote: >> I'm not talking about any specific bug, but in general if allocator re-maps >> already mapped region or unmaps the wrong-and-used region. I had those >> bug-cases >> during of development

Re: [PATCH v2 1/2] iommu/tegra: gart: Optionally check for overwriting of page mappings

2017-10-13 Thread Joerg Roedel
On Thu, Oct 12, 2017 at 05:27:26PM +0300, Dmitry Osipenko wrote: > I'm not talking about any specific bug, but in general if allocator re-maps > already mapped region or unmaps the wrong-and-used region. I had those > bug-cases > during of development of the 'scattered' graphics allocations for Te

Re: [PATCH v2 1/2] iommu/tegra: gart: Optionally check for overwriting of page mappings

2017-10-12 Thread Dmitry Osipenko
On 10.10.2017 12:53, Joerg Roedel wrote: > On Wed, Oct 04, 2017 at 04:02:31AM +0300, Dmitry Osipenko wrote: >> Due to a bug in IOVA allocator, page mapping could accidentally overwritten. >> We can catch this case by checking 'VALID' bit of GART's page entry prior to >> mapping of a page. Since tha

Re: [PATCH v2 1/2] iommu/tegra: gart: Optionally check for overwriting of page mappings

2017-10-10 Thread Joerg Roedel
On Wed, Oct 04, 2017 at 04:02:31AM +0300, Dmitry Osipenko wrote: > Due to a bug in IOVA allocator, page mapping could accidentally overwritten. > We can catch this case by checking 'VALID' bit of GART's page entry prior to > mapping of a page. Since that check introduces a noticeable performance >

[PATCH v2 1/2] iommu/tegra: gart: Optionally check for overwriting of page mappings

2017-10-03 Thread Dmitry Osipenko
Due to a bug in IOVA allocator, page mapping could accidentally overwritten. We can catch this case by checking 'VALID' bit of GART's page entry prior to mapping of a page. Since that check introduces a noticeable performance impact, it should be enabled explicitly by a new CONFIG_TEGRA_IOMMU_GART_