Re: [PATCH v2 4/6] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable

2022-01-12 Thread Yong Wu
On Tue, 2022-01-11 at 10:10 +0100, AngeloGioacchino Del Regno wrote: > Il 11/01/22 07:39, Yong Wu ha scritto: > > The successful return value for clk_bulk_prepare_enable is 0, > > rather than > > "< 0". Fix this. > > > > Hello! Thanks for this commit! > However, there are a few comments... > > T

Re: [PATCH v2 4/6] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable

2022-01-12 Thread Krzysztof Kozlowski
On 11/01/2022 07:39, Yong Wu wrote: > The successful return value for clk_bulk_prepare_enable is 0, rather than > "< 0". Fix this. I do not understand. The commit description does not match the code. What is the error here? > > Fixes: 0e14917c57f9 ("memory: mtk-smi: Use clk_bulk clock ops") The

Re: [PATCH v2 4/6] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable

2022-01-11 Thread AngeloGioacchino Del Regno
Il 11/01/22 07:39, Yong Wu ha scritto: The successful return value for clk_bulk_prepare_enable is 0, rather than "< 0". Fix this. Hello! Thanks for this commit! However, there are a few comments... This description is a bit confusing, please reword it, something like... "Function clk_bulk_pr

[PATCH v2 4/6] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable

2022-01-10 Thread Yong Wu
The successful return value for clk_bulk_prepare_enable is 0, rather than "< 0". Fix this. Fixes: 0e14917c57f9 ("memory: mtk-smi: Use clk_bulk clock ops") Signed-off-by: Yong Wu --- drivers/memory/mtk-smi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memory/mtk-sm