Re: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-24 Thread Andreas Herrmann
On Thu, Jan 23, 2014 at 08:24:29PM +0100, Andreas Herrmann wrote: On Wed, Jan 22, 2014 at 03:33:52PM +, Will Deacon wrote: On Wed, Jan 22, 2014 at 01:54:11PM +, Varun Sethi wrote: Ok, so are you suggesting that we perform the isolation mapping in arm_smmu_add_device and drop

Re: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-23 Thread Andreas Herrmann
...@lists.infradead.org; Andreas Herrmann Subject: Re: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block On Wed, Jan 22, 2014 at 01:54:11PM +, Varun Sethi wrote: Ok, so are you suggesting that we perform the isolation mapping in arm_smmu_add_device and drop the notifier

Re: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-22 Thread Will Deacon
Hi Varun, Andreas, On Tue, Jan 21, 2014 at 05:48:02PM +, Varun Sethi wrote: +static int arm_smmu_group_notifier(struct notifier_block *nb, + unsigned long action, void *data) +{ + struct device *dev = data; + struct dma_iommu_mapping *mapping; +

RE: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-22 Thread Varun Sethi
/arm-smmu: Introduce iommu_group notifier block Hi Varun, Andreas, On Tue, Jan 21, 2014 at 05:48:02PM +, Varun Sethi wrote: +static int arm_smmu_group_notifier(struct notifier_block *nb, + unsigned long action, void *data) { + struct device *dev = data

Re: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-22 Thread Will Deacon
On Wed, Jan 22, 2014 at 01:14:13PM +, Varun Sethi wrote: On Tue, Jan 21, 2014 at 05:48:02PM +, Varun Sethi wrote: +static int arm_smmu_group_notifier(struct notifier_block *nb, + unsigned long action, void *data) { + struct device *dev =

RE: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-22 Thread Varun Sethi
/arm-smmu: Introduce iommu_group notifier block On Wed, Jan 22, 2014 at 01:54:11PM +, Varun Sethi wrote: Ok, so are you suggesting that we perform the isolation mapping in arm_smmu_add_device and drop the notifier altogether? I think that should be fine, until we want to delay

RE: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-21 Thread Varun Sethi
/arm-smmu: Introduce iommu_group notifier block At the moment just handle IOMMU_GROUP_NOTIFY_BIND_DRIVER to conditionally isolate all master devices for an SMMU. Depending on DT information each device is put into its own protection domain (if possible). For configuration with one

[PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-20 Thread Andreas Herrmann
At the moment just handle IOMMU_GROUP_NOTIFY_BIND_DRIVER to conditionally isolate all master devices for an SMMU. Depending on DT information each device is put into its own protection domain (if possible). For configuration with one or just a few masters per SMMU that is easy to achieve. In