Re: [PATCH v3 1/2] dma-contiguous: Abstract dma_{alloc,free}_contiguous()

2019-07-25 Thread Nicolin Chen
On Thu, Jul 25, 2019 at 07:31:05PM +0200, Dafna Hirschfeld wrote: > On Thu, 2019-07-25 at 09:50 -0700, Nicolin Chen wrote: > > On Thu, Jul 25, 2019 at 01:06:42PM -0300, Ezequiel Garcia wrote: > > > I can't find a way to forward-redirect from Gmail, so I'm Ccing Dafna > > > who found a regression

Re: [PATCH v3 1/2] dma-contiguous: Abstract dma_{alloc,free}_contiguous()

2019-07-25 Thread Dafna Hirschfeld
On Thu, 2019-07-25 at 09:50 -0700, Nicolin Chen wrote: > On Thu, Jul 25, 2019 at 01:06:42PM -0300, Ezequiel Garcia wrote: > > I can't find a way to forward-redirect from Gmail, so I'm Ccing Dafna > > who found a regression caused by this commit. Dafna, can you give all > > the details, including

Re: [PATCH v3 1/2] dma-contiguous: Abstract dma_{alloc,free}_contiguous()

2019-07-25 Thread Nicolin Chen
On Thu, Jul 25, 2019 at 01:06:42PM -0300, Ezequiel Garcia wrote: > I can't find a way to forward-redirect from Gmail, so I'm Ccing Dafna > who found a regression caused by this commit. Dafna, can you give all > the details, including the log and how you are reproducing it? I saw the conversation

Re: [PATCH v3 1/2] dma-contiguous: Abstract dma_{alloc,free}_contiguous()

2019-07-25 Thread Ezequiel Garcia
I can't find a way to forward-redirect from Gmail, so I'm Ccing Dafna who found a regression caused by this commit. Dafna, can you give all the details, including the log and how you are reproducing it? On Fri, 24 May 2019 at 01:08, Nicolin Chen wrote: > > Both dma_alloc_from_contiguous() and

Re: [PATCH v3 1/2] dma-contiguous: Abstract dma_{alloc,free}_contiguous()

2019-05-29 Thread Nicolin Chen
Hi Nathan, On Wed, May 29, 2019 at 11:35:46AM -0700, Nathan Chancellor wrote: > This commit is causing boot failures in QEMU on x86_64 defconfig: > > https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/203825363 > > Attached is a bisect log and a boot log with GCC (just to show it

Re: [PATCH v3 1/2] dma-contiguous: Abstract dma_{alloc,free}_contiguous()

2019-05-29 Thread Nathan Chancellor
Hi Nicolin, On Thu, May 23, 2019 at 09:06:32PM -0700, Nicolin Chen wrote: > Both dma_alloc_from_contiguous() and dma_release_from_contiguous() > are very simply implemented, but requiring callers to pass certain > parameters like count and align, and taking a boolean parameter to > check

[PATCH v3 1/2] dma-contiguous: Abstract dma_{alloc, free}_contiguous()

2019-05-23 Thread Nicolin Chen
Both dma_alloc_from_contiguous() and dma_release_from_contiguous() are very simply implemented, but requiring callers to pass certain parameters like count and align, and taking a boolean parameter to check __GFP_NOWARN in the allocation flags. So every function call duplicates similar work: /*