Re: [PATCH v4 05/13] iommu/rockchip: Use iopoll helpers to wait for hardware

Hi Robin, On 01/18/2018 09:09 PM, Robin Murphy wrote: -#define FORCE_RESET_TIMEOUT100/* ms */ +#define FORCE_RESET_TIMEOUT10/* us */ +#define POLL_TIMEOUT1000/* us */ Nit: the callsites look a bit odd with the combination of POLL_TIMEOUT and the magic number

Re: [PATCH v4 05/13] iommu/rockchip: Use iopoll helpers to wait for hardware

On 18/01/18 11:52, Jeffy Chen wrote: From: Tomasz Figa This patch converts the rockchip-iommu driver to use the in-kernel iopoll helpers to wait for certain status bits to change in registers instead of an open-coded custom macro. Signed-off-by: Tomasz Figa

[PATCH v4 05/13] iommu/rockchip: Use iopoll helpers to wait for hardware

From: Tomasz Figa This patch converts the rockchip-iommu driver to use the in-kernel iopoll helpers to wait for certain status bits to change in registers instead of an open-coded custom macro. Signed-off-by: Tomasz Figa Signed-off-by: Jeffy Chen