Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-12-03 Thread Kirti Wankhede
On 11/21/2018 2:15 PM, Christoph Hellwig wrote: > On Wed, Nov 21, 2018 at 02:22:08AM +0530, Kirti Wankhede wrote: >> It is about how mdev framework can be used by existing drivers. These >> symbols doesn't use any other exported symbols. > > That is an unfortunate accident of history, but

Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-11-21 Thread Christoph Hellwig
On Wed, Nov 21, 2018 at 02:22:08AM +0530, Kirti Wankhede wrote: > It is about how mdev framework can be used by existing drivers. These > symbols doesn't use any other exported symbols. That is an unfortunate accident of history, but doesn't extent to new ones. It also is another inidicator

Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-11-20 Thread Kirti Wankhede
On 11/16/2018 2:27 PM, Christoph Hellwig wrote: > On Fri, Nov 16, 2018 at 09:20:48AM +0800, Lu Baolu wrote: >>> Please keep symbols mdev_set/get_iommu_device(dev, iommu_device) non-GPL >>> same as other exported symbols from mdev_core module. >> >> Yes. It will be fixed in the next version. >

Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-11-16 Thread Lu Baolu
Hi, On 11/16/18 4:57 PM, Christoph Hellwig wrote: On Fri, Nov 16, 2018 at 09:20:48AM +0800, Lu Baolu wrote: Please keep symbols mdev_set/get_iommu_device(dev, iommu_device) non-GPL same as other exported symbols from mdev_core module. Yes. It will be fixed in the next version. No. mdev

Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-11-16 Thread Christoph Hellwig
On Fri, Nov 16, 2018 at 09:20:48AM +0800, Lu Baolu wrote: > > Please keep symbols mdev_set/get_iommu_device(dev, iommu_device) non-GPL > > same as other exported symbols from mdev_core module. > > Yes. It will be fixed in the next version. No. mdev shall not be used to circumvent the exports in

Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-11-15 Thread Lu Baolu
Hi, On 11/16/18 5:31 AM, Kirti Wankhede wrote: On 11/7/2018 7:18 AM, Lu Baolu wrote: Hi Alex, On 11/7/18 7:53 AM, Alex Williamson wrote: On Mon,  5 Nov 2018 15:34:06 +0800 Lu Baolu wrote: A parent device might create different types of mediated devices. For example, a mediated device

Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-11-15 Thread Kirti Wankhede
On 11/7/2018 7:18 AM, Lu Baolu wrote: > Hi Alex, > > On 11/7/18 7:53 AM, Alex Williamson wrote: >> On Mon,  5 Nov 2018 15:34:06 +0800 >> Lu Baolu wrote: >> >>> A parent device might create different types of mediated >>> devices. For example, a mediated device could be created >>> by the

Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-11-06 Thread Lu Baolu
Hi Alex, On 11/7/18 7:53 AM, Alex Williamson wrote: On Mon, 5 Nov 2018 15:34:06 +0800 Lu Baolu wrote: A parent device might create different types of mediated devices. For example, a mediated device could be created by the parent device with full isolation and protection provided by the

Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-11-06 Thread Alex Williamson
On Mon, 5 Nov 2018 15:34:06 +0800 Lu Baolu wrote: > A parent device might create different types of mediated > devices. For example, a mediated device could be created > by the parent device with full isolation and protection > provided by the IOMMU. One usage case could be found on > Intel

Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-11-05 Thread Lu Baolu
Hi, On 11/5/18 10:51 PM, Christoph Hellwig wrote: Please use EXPORT_SYMBOL_GPL like most of the vfio code. Sure. Will use this in the next version. Best regards, Lu Baolu ___ iommu mailing list iommu@lists.linux-foundation.org

Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-11-05 Thread Christoph Hellwig
Please use EXPORT_SYMBOL_GPL like most of the vfio code. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-11-04 Thread Lu Baolu
A parent device might create different types of mediated devices. For example, a mediated device could be created by the parent device with full isolation and protection provided by the IOMMU. One usage case could be found on Intel platforms where a mediated device is an assignable subset of a