Re: [PATCH v5 4/7] dma-iommu: fold _swiotlb helpers into callers

2021-08-16 Thread Christoph Hellwig
> + if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) && > + (dir == DMA_TO_DEVICE || > + dir == DMA_BIDIRECTIONAL)) { Nit: the two dire checks easily fit onto a single line and are easier to follow that way. Otherwise looks good: Reviewed-by: Christoph Hellwig

[PATCH v5 4/7] dma-iommu: fold _swiotlb helpers into callers

2021-08-15 Thread David Stevens
From: David Stevens Fold the _swiotlb helper functions into the respective _page functions, since recent fixes have moved all logic from the _page functions to the _swiotlb functions. Signed-off-by: David Stevens --- drivers/iommu/dma-iommu.c | 136 +- 1