Re: [RFC PATCH 1/3] dma-mapping: make overriding GFP_* flags arch customizable
On Fri, Sep 27, 2019 at 02:33:14AM +0200, Halil Pasic wrote: > Thank you for your feedback. Just to be sure we are on the same pager, I > read commit a0be1db4304f like this: > 1) virtio_pci_legacy needs to allocate the virtqueues so that the base > address fits 44 bits > 2) if 64 bit dma is possible they set coherent_dma_mask to > DMA_BIT_MASK(44) and dma_mask to DMA_BIT_MASK(64) > 3) since the queues get allocated with coherent allocations 1) is > satisfied > 4) when the streaming mappings see a buffer that is beyond > DMA_BIT_MASK(44) then it has to treat it as not coherent memory > and do the syncing magic (which isn't actually required, just > a side effect of the workaround. 1-3 is correct, 4 is not. The coherent mask is a little misnamed and doesn't have to anything with coherency. It is the mask for DMA allocations, while the dma mask is for streaming mappings. > I've already implemented a patch (see after the scissors line) that > takes a similar route as commit a0be1db4304f, but I consider that a > workaround at best. But if that is what the community wants... I have to > get the job done one way or the other. That patch (minus the comments about being a workaround) is what you should have done from the beginning. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [RFC PATCH 1/3] dma-mapping: make overriding GFP_* flags arch customizable
On Thu, 26 Sep 2019 14:04:13 +0100 Robin Murphy wrote: > On 26/09/2019 13:37, Halil Pasic wrote: > > On Mon, 23 Sep 2019 17:21:17 +0200 > > Christoph Hellwig wrote: > > > >> On Mon, Sep 23, 2019 at 02:34:16PM +0200, Halil Pasic wrote: > >>> Before commit 57bf5a8963f8 ("dma-mapping: clear harmful GFP_* flags in > >>> common code") tweaking the client code supplied GFP_* flags used to be > >>> an issue handled in the architecture specific code. The commit message > >>> suggests, that fixing the client code would actually be a better way > >>> of dealing with this. > >>> > >>> On s390 common I/O devices are generally capable of using the full 64 > >>> bit address space for DMA I/O, but some chunks of the DMA memory need to > >>> be 31 bit addressable (in physical address space) because the > >>> instructions involved mandate it. Before switching to DMA API this used > >>> to be a non-issue, we used to allocate those chunks from ZONE_DMA. > >>> Currently our only option with the DMA API is to restrict the devices to > >>> (via dma_mask and coherent_dma_mask) to 31 bit, which is sub-optimal. > >>> > >>> Thus s390 we would benefit form having control over what flags are > >>> dropped. > >> > >> No way, sorry. You need to express that using a dma mask instead of > >> overloading the GFP flags. > > > > Thanks for your feedback and sorry for the delay. Can you help me figure > > out how can I express that using a dma mask? > > > > IMHO what you ask from me is frankly impossible. > > > > What I need is the ability to ask for (considering the physical > > address) 31 bit addressable DMA memory if the chunk is supposed to host > > control-type data that needs to be 31 bit addressable because that is > > how the architecture is, without affecting the normal data-path. So > > normally 64 bit mask is fine but occasionally (control) we would need > > a 31 bit mask. > > If it's possible to rework the "data" path to use streaming mappings > instead of coherent allocations, you could potentially mimic what virtio > does for a similar situation - see commit a0be1db4304f. > Thank you for your feedback. Just to be sure we are on the same pager, I read commit a0be1db4304f like this: 1) virtio_pci_legacy needs to allocate the virtqueues so that the base address fits 44 bits 2) if 64 bit dma is possible they set coherent_dma_mask to DMA_BIT_MASK(44) and dma_mask to DMA_BIT_MASK(64) 3) since the queues get allocated with coherent allocations 1) is satisfied 4) when the streaming mappings see a buffer that is beyond DMA_BIT_MASK(44) then it has to treat it as not coherent memory and do the syncing magic (which isn't actually required, just a side effect of the workaround. I'm actually trying to get virtio_ccw working nice with Protected Virtualization (best think of encrypted memory). So the "data" path is mostly the same as for virtio_pci. But unlike virtio_pci_legacy we are perfectly fine with virtqueues at an arbitrary address. We can make coherent_dma_mask == DMA_BIT_MASK(31) != dma_mask == DMA_BIT_MASK(64) but that affects all dma coherent allocations and needlessly force the virtio control structures into the [0..2G] range. Furthermore this whole issue has nothing to do with memory coherence. For ccw devices memory at addresses above 2G is no less coherent for ccw devices than memory at addresses below 2G. I've already implemented a patch (see after the scissors line) that takes a similar route as commit a0be1db4304f, but I consider that a workaround at best. But if that is what the community wants... I have to get the job done one way or the other. Many thanks for your help and your time. ---8< From: Halil Pasic Date: Thu, 25 Jul 2019 18:44:21 +0200 Subject: [PATCH 1/1] s390/cio: fix virtio-ccw DMA without PV Commit 37db8985b211 ("s390/cio: add basic protected virtualization support") breaks virtio-ccw devices with VIRTIO_F_IOMMU_PLATFORM for non Protected Virtualization (PV) guests. The problem is that the dma_mask of the ccw device, which is used by virtio core, gets changed from 64 to 31 bit, because some of the DMA allocations do require 31 bit addressable memory. For PV the only drawback is that some of the virtio structures must end up in ZONE_DMA because we have the bounce the buffers mapped via DMA API anyway. But for non PV guests we have a problem: because of the 31 bit mask guests bigger than 2G are likely to try bouncing buffers. The swiotlb however is only initialized for PV guests, because we don't want to bounce anything for non PV guests. The first such map kills the guest. Since the DMA API won't allow us to specify for each allocating whether we need memory from ZONE_DMA (31 bit addressable) or any DMA capable memory will do, let us abuse coherent_dma_mask (which is used for allocations) to force allocating form ZONE_DMA while changing dma_mask to DMA_BIT_MASK(64). Signed-off-by: Halil Pasic Reported-by: Marc
Re: [RFC PATCH 1/3] dma-mapping: make overriding GFP_* flags arch customizable
On 26/09/2019 13:37, Halil Pasic wrote: On Mon, 23 Sep 2019 17:21:17 +0200 Christoph Hellwig wrote: On Mon, Sep 23, 2019 at 02:34:16PM +0200, Halil Pasic wrote: Before commit 57bf5a8963f8 ("dma-mapping: clear harmful GFP_* flags in common code") tweaking the client code supplied GFP_* flags used to be an issue handled in the architecture specific code. The commit message suggests, that fixing the client code would actually be a better way of dealing with this. On s390 common I/O devices are generally capable of using the full 64 bit address space for DMA I/O, but some chunks of the DMA memory need to be 31 bit addressable (in physical address space) because the instructions involved mandate it. Before switching to DMA API this used to be a non-issue, we used to allocate those chunks from ZONE_DMA. Currently our only option with the DMA API is to restrict the devices to (via dma_mask and dma_mask_coherent) to 31 bit, which is sub-optimal. Thus s390 we would benefit form having control over what flags are dropped. No way, sorry. You need to express that using a dma mask instead of overloading the GFP flags. Thanks for your feedback and sorry for the delay. Can you help me figure out how can I express that using a dma mask? IMHO what you ask from me is frankly impossible. What I need is the ability to ask for (considering the physical address) 31 bit addressable DMA memory if the chunk is supposed to host control-type data that needs to be 31 bit addressable because that is how the architecture is, without affecting the normal data-path. So normally 64 bit mask is fine but occasionally (control) we would need a 31 bit mask. If it's possible to rework the "data" path to use streaming mappings instead of coherent allocations, you could potentially mimic what virtio does for a similar situation - see commit a0be1db4304f. Robin. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [RFC PATCH 1/3] dma-mapping: make overriding GFP_* flags arch customizable
On Mon, Sep 23, 2019 at 02:34:16PM +0200, Halil Pasic wrote: > Before commit 57bf5a8963f8 ("dma-mapping: clear harmful GFP_* flags in > common code") tweaking the client code supplied GFP_* flags used to be > an issue handled in the architecture specific code. The commit message > suggests, that fixing the client code would actually be a better way > of dealing with this. > > On s390 common I/O devices are generally capable of using the full 64 > bit address space for DMA I/O, but some chunks of the DMA memory need to > be 31 bit addressable (in physical address space) because the > instructions involved mandate it. Before switching to DMA API this used > to be a non-issue, we used to allocate those chunks from ZONE_DMA. > Currently our only option with the DMA API is to restrict the devices to > (via dma_mask and dma_mask_coherent) to 31 bit, which is sub-optimal. > > Thus s390 we would benefit form having control over what flags are > dropped. No way, sorry. You need to express that using a dma mask instead of overloading the GFP flags.
[RFC PATCH 1/3] dma-mapping: make overriding GFP_* flags arch customizable
Before commit 57bf5a8963f8 ("dma-mapping: clear harmful GFP_* flags in common code") tweaking the client code supplied GFP_* flags used to be an issue handled in the architecture specific code. The commit message suggests, that fixing the client code would actually be a better way of dealing with this. On s390 common I/O devices are generally capable of using the full 64 bit address space for DMA I/O, but some chunks of the DMA memory need to be 31 bit addressable (in physical address space) because the instructions involved mandate it. Before switching to DMA API this used to be a non-issue, we used to allocate those chunks from ZONE_DMA. Currently our only option with the DMA API is to restrict the devices to (via dma_mask and dma_mask_coherent) to 31 bit, which is sub-optimal. Thus s390 we would benefit form having control over what flags are dropped. Signed-off-by: Halil Pasic --- include/linux/dma-mapping.h | 10 ++ kernel/dma/Kconfig | 6 ++ kernel/dma/mapping.c| 4 +--- 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index 4a1c4fca475a..5024bc863fa7 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -817,4 +817,14 @@ static inline int dma_mmap_wc(struct device *dev, #define dma_unmap_len_set(PTR, LEN_NAME, VAL)do { } while (0) #endif +#ifdef CONFIG_ARCH_HAS_DMA_OVERRIDE_GFP_FLAGS +extern gfp_t dma_override_gfp_flags(struct device *dev, gfp_t flags); +#else +static inline gfp_t dma_override_gfp_flags(struct device *dev, gfp_t flags) +{ + /* let the implementation decide on the zone to allocate from: */ + return flags & ~(__GFP_DMA | __GFP_DMA32 | __GFP_HIGHMEM); +} +#endif + #endif diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig index 73c5c2b8e824..4756c75047e3 100644 --- a/kernel/dma/Kconfig +++ b/kernel/dma/Kconfig @@ -54,6 +54,12 @@ config ARCH_HAS_DMA_PREP_COHERENT config ARCH_HAS_DMA_COHERENT_TO_PFN bool +config ARCH_HAS_DMA_MMAP_PGPROT + bool + +config ARCH_HAS_DMA_OVERRIDE_GFP_FLAGS + bool + config ARCH_HAS_FORCE_DMA_UNENCRYPTED bool diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c index d9334f31a5af..535b809548e2 100644 --- a/kernel/dma/mapping.c +++ b/kernel/dma/mapping.c @@ -303,9 +303,7 @@ void *dma_alloc_attrs(struct device *dev, size_t size, dma_addr_t *dma_handle, if (dma_alloc_from_dev_coherent(dev, size, dma_handle, _addr)) return cpu_addr; - /* let the implementation decide on the zone to allocate from: */ - flag &= ~(__GFP_DMA | __GFP_DMA32 | __GFP_HIGHMEM); - + flag = dma_override_gfp_flags(dev, flag); if (dma_is_direct(ops)) cpu_addr = dma_direct_alloc(dev, size, dma_handle, flag, attrs); else if (ops->alloc) -- 2.17.1