Re: [RFC PATCH v1] iommu/io-pgtable-arm-v7s: Check for leaf entry right after finding it

2017-02-24 Thread Will Deacon
On Tue, Feb 21, 2017 at 03:31:26PM +0200, Oleksandr Tyshchenko wrote: > On Tue, Feb 21, 2017 at 2:00 PM, Robin Murphy wrote: > > Would it not be more logical (and simpler) to just check that the thing > > we dereference is valid to dereference when we dereference it? i.e.: >

Re: [RFC PATCH v1] iommu/io-pgtable-arm-v7s: Check for leaf entry right after finding it

2017-02-21 Thread Oleksandr Tyshchenko
Hi, Robin. On Tue, Feb 21, 2017 at 2:00 PM, Robin Murphy wrote: > On 16/02/17 13:52, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> Do a check for already installed leaf entry at the current level before >> performing any

Re: [RFC PATCH v1] iommu/io-pgtable-arm-v7s: Check for leaf entry right after finding it

2017-02-21 Thread Robin Murphy
On 16/02/17 13:52, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Do a check for already installed leaf entry at the current level before > performing any actions when trying to map. > > This check is already present in arm_v7s_init_pte(), i.e.

Re: [RFC PATCH v1] iommu/io-pgtable-arm-v7s: Check for leaf entry right after finding it

2017-02-16 Thread Oleksandr Tyshchenko
Hi, Robin. It would be greatly appreciated if you could test this patch if nobody has objections to the patch itself. On Thu, Feb 16, 2017 at 3:52 PM, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Do a check for already

[RFC PATCH v1] iommu/io-pgtable-arm-v7s: Check for leaf entry right after finding it

2017-02-16 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Do a check for already installed leaf entry at the current level before performing any actions when trying to map. This check is already present in arm_v7s_init_pte(), i.e. before installing new leaf entry at the current level if