Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-10-11 Thread Christoph Hellwig
On Thu, Oct 07, 2021 at 12:59:32PM +0200, Karsten Graul wrote: > In our case its really that a buffer is mapped twice for 2 different devices > which we use in SMC to provide failover capabilities. We see that -EEXIST is > returned when a buffer is mapped for the second device. Since there is a

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-10-07 Thread Gerald Schaefer
On Thu, 7 Oct 2021 12:59:32 +0200 Karsten Graul wrote: [...] > > > >>> BTW, there is already a WARN in the add_dma_entry() path, related > >>> to cachlline overlap and -EEXIST: > >>> > >>> add_dma_entry() -> active_cacheline_insert() -> -EEXIST -> > >>> active_cacheline_inc_overlap() > >>> >

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-10-07 Thread Karsten Graul
On 06/10/2021 16:23, Robin Murphy wrote: > On 2021-10-06 14:10, Gerald Schaefer wrote: >> On Fri, 1 Oct 2021 14:52:56 +0200 >> Gerald Schaefer wrote: >> >>> On Thu, 30 Sep 2021 15:37:33 +0200 >>> Karsten Graul wrote: >>> On 14/09/2021 17:45, Ioana Ciornei wrote: > On Wed, Sep 08, 2021

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-10-06 Thread Gerald Schaefer
On Wed, 6 Oct 2021 15:23:36 +0100 Robin Murphy wrote: > On 2021-10-06 14:10, Gerald Schaefer wrote: > > On Fri, 1 Oct 2021 14:52:56 +0200 > > Gerald Schaefer wrote: > > > >> On Thu, 30 Sep 2021 15:37:33 +0200 > >> Karsten Graul wrote: > >> > >>> On 14/09/2021 17:45, Ioana Ciornei wrote: >

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-10-06 Thread Robin Murphy
On 2021-10-06 14:10, Gerald Schaefer wrote: On Fri, 1 Oct 2021 14:52:56 +0200 Gerald Schaefer wrote: On Thu, 30 Sep 2021 15:37:33 +0200 Karsten Graul wrote: On 14/09/2021 17:45, Ioana Ciornei wrote: On Wed, Sep 08, 2021 at 10:33:26PM -0500, Jeremy Linton wrote: +DPAA2, netdev maintainers

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-10-06 Thread Gerald Schaefer
On Wed, 6 Oct 2021 15:10:43 +0200 Gerald Schaefer wrote: > On Fri, 1 Oct 2021 14:52:56 +0200 > Gerald Schaefer wrote: > > > On Thu, 30 Sep 2021 15:37:33 +0200 > > Karsten Graul wrote: > > > > > On 14/09/2021 17:45, Ioana Ciornei wrote: > > > > On Wed, Sep 08, 2021 at 10:33:26PM -0500, Jeremy

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-10-06 Thread Gerald Schaefer
On Fri, 1 Oct 2021 14:52:56 +0200 Gerald Schaefer wrote: > On Thu, 30 Sep 2021 15:37:33 +0200 > Karsten Graul wrote: > > > On 14/09/2021 17:45, Ioana Ciornei wrote: > > > On Wed, Sep 08, 2021 at 10:33:26PM -0500, Jeremy Linton wrote: > > >> +DPAA2, netdev maintainers > > >> Hi, > > >> > > >>

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-10-01 Thread Gerald Schaefer
On Thu, 30 Sep 2021 15:37:33 +0200 Karsten Graul wrote: > On 14/09/2021 17:45, Ioana Ciornei wrote: > > On Wed, Sep 08, 2021 at 10:33:26PM -0500, Jeremy Linton wrote: > >> +DPAA2, netdev maintainers > >> Hi, > >> > >> On 5/18/21 7:54 AM, Hamza Mahfooz wrote: > >>> Since, overlapping mappings are

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-10-01 Thread Ioana Ciornei
On Fri, Oct 01, 2021 at 06:19:59AM +0200, Christoph Hellwig wrote: > On Tue, Sep 14, 2021 at 03:45:06PM +, Ioana Ciornei wrote: > > [ 245.927020] fsl_dpaa2_eth dpni.3: scather-gather idx 0 P=20a732 > > N=20a7320 D=20a732 L=30 DMA_BIDIRECTIONAL dma map error check not > > applicable·

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-09-30 Thread Christoph Hellwig
On Tue, Sep 14, 2021 at 03:45:06PM +, Ioana Ciornei wrote: > [ 245.927020] fsl_dpaa2_eth dpni.3: scather-gather idx 0 P=20a732 > N=20a7320 D=20a732 L=30 DMA_BIDIRECTIONAL dma map error check not > applicable· > [ 245.927048] fsl_dpaa2_eth dpni.3: scather-gather idx 1 P=20a7320030

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-09-30 Thread Karsten Graul
On 14/09/2021 17:45, Ioana Ciornei wrote: > On Wed, Sep 08, 2021 at 10:33:26PM -0500, Jeremy Linton wrote: >> +DPAA2, netdev maintainers >> Hi, >> >> On 5/18/21 7:54 AM, Hamza Mahfooz wrote: >>> Since, overlapping mappings are not supported by the DMA API we should >>> report an error if

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-09-14 Thread Ioana Ciornei
On Wed, Sep 08, 2021 at 10:33:26PM -0500, Jeremy Linton wrote: > +DPAA2, netdev maintainers > Hi, > > On 5/18/21 7:54 AM, Hamza Mahfooz wrote: > > Since, overlapping mappings are not supported by the DMA API we should > > report an error if active_cacheline_insert returns -EEXIST. > > It seems

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-09-10 Thread Christoph Hellwig
On Wed, Sep 08, 2021 at 10:33:26PM -0500, Jeremy Linton wrote: > PS, it might not hurt to rate limit/_once this somehow to avoid a runtime > problem if it starts to trigger. Yes, that might be a good idea. Care to prepare a patch? ___ iommu mailing

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-09-10 Thread Ioana Ciornei
On Wed, Sep 08, 2021 at 10:33:26PM -0500, Jeremy Linton wrote: > +DPAA2, netdev maintainers > Hi, > > On 5/18/21 7:54 AM, Hamza Mahfooz wrote: > > Since, overlapping mappings are not supported by the DMA API we should > > report an error if active_cacheline_insert returns -EEXIST. > > It seems

DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-09-08 Thread Jeremy Linton
+DPAA2, netdev maintainers Hi, On 5/18/21 7:54 AM, Hamza Mahfooz wrote: Since, overlapping mappings are not supported by the DMA API we should report an error if active_cacheline_insert returns -EEXIST. It seems this patch found a victim. I was trying to run iperf3 on a honeycomb (5.14.0,