Re: [PATCH v2 08/16] iommu: introduce device fault data

2017-11-13 Thread Jean-Philippe Brucker
On 13/11/17 16:57, Jacob Pan wrote: > On Mon, 13 Nov 2017 13:06:24 + > Jean-Philippe Brucker wrote: > >> On 10/11/17 22:18, Jacob Pan wrote: >>> On Fri, 10 Nov 2017 13:54:59 + >>> Jean-Philippe Brucker wrote: >>> On

Re: [PATCH v2 08/16] iommu: introduce device fault data

2017-11-13 Thread Jacob Pan
On Mon, 13 Nov 2017 13:06:24 + Jean-Philippe Brucker wrote: > On 10/11/17 22:18, Jacob Pan wrote: > > On Fri, 10 Nov 2017 13:54:59 + > > Jean-Philippe Brucker wrote: > > > >> On 09/11/17 19:36, Jacob Pan wrote: > >>> On

Re: [PATCH v2 08/16] iommu: introduce device fault data

2017-11-13 Thread Jacob Pan
On Mon, 13 Nov 2017 13:19:50 + Jean-Philippe Brucker wrote: > On 11/11/17 00:00, Jacob Pan wrote: > > On Fri, 10 Nov 2017 13:54:59 + > > Jean-Philippe Brucker wrote: > > > >> /* > >> * Note: I tried to synthesize what I

Re: [PATCH v2 08/16] iommu: introduce device fault data

2017-11-13 Thread Jean-Philippe Brucker
On 11/11/17 00:00, Jacob Pan wrote: > On Fri, 10 Nov 2017 13:54:59 + > Jean-Philippe Brucker wrote: > >> /* >> * Note: I tried to synthesize what I believe would be useful to >> device >> * drivers and guests, with regards to the kind of faults that the ARM

Re: [PATCH v2 08/16] iommu: introduce device fault data

2017-11-13 Thread Jean-Philippe Brucker
On 10/11/17 22:18, Jacob Pan wrote: > On Fri, 10 Nov 2017 13:54:59 + > Jean-Philippe Brucker wrote: > >> On 09/11/17 19:36, Jacob Pan wrote: >>> On Tue, 7 Nov 2017 11:38:50 + >>> Jean-Philippe Brucker wrote: >>> I

Re: [PATCH v2 08/16] iommu: introduce device fault data

2017-11-10 Thread Jacob Pan
On Fri, 10 Nov 2017 13:54:59 + Jean-Philippe Brucker wrote: > /* > * Note: I tried to synthesize what I believe would be useful to > device > * drivers and guests, with regards to the kind of faults that the ARM > * SMMU is capable of reporting. Other IOMMUs

Re: [PATCH v2 08/16] iommu: introduce device fault data

2017-11-10 Thread Jean-Philippe Brucker
On 09/11/17 19:36, Jacob Pan wrote: > On Tue, 7 Nov 2017 11:38:50 + > Jean-Philippe Brucker wrote: > >> I think the IOMMU should pass the struct device associated to the BDF >> to the fault handler. The fault handler can then deduce the BDF from >> struct

Re: [PATCH v2 08/16] iommu: introduce device fault data

2017-11-09 Thread Jacob Pan
On Tue, 7 Nov 2017 11:38:50 + Jean-Philippe Brucker wrote: > I think the IOMMU should pass the struct device associated to the BDF > to the fault handler. The fault handler can then deduce the BDF from > struct device if it needs to. This also allows to support

Re: [PATCH v2 08/16] iommu: introduce device fault data

2017-11-07 Thread Jean-Philippe Brucker
On 07/11/17 08:40, Liu, Yi L wrote: [...] > + > +/* Generic fault types, can be expanded IRQ remapping fault */ > +enum iommu_fault_type { > + IOMMU_FAULT_DMA_UNRECOV = 1,/* unrecoverable fault */ > + IOMMU_FAULT_PAGE_REQ, /* page request fault */ > +}; >

RE: [PATCH v2 08/16] iommu: introduce device fault data

2017-11-07 Thread Liu, Yi L
, Rafael J > <rafael.j.wyso...@intel.com> > Cc: Lan, Tianyu <tianyu@intel.com>; Tian, Kevin <kevin.t...@intel.com>; > Raj, > Ashok <ashok....@intel.com>; Alex Williamson <alex.william...@redhat.com> > Subject: Re: [PATCH v2 08/16] iommu: introduce device f

Re: [PATCH v2 08/16] iommu: introduce device fault data

2017-11-06 Thread Jean-Philippe Brucker
Hi Yi, Sorry for the late reply, I seem to have missed this. On 20/10/17 11:07, Liu, Yi L wrote: [...] >>> + >>> +/* Generic fault types, can be expanded IRQ remapping fault */ enum >>> +iommu_fault_type { >>> + IOMMU_FAULT_DMA_UNRECOV = 1,/* unrecoverable fault */ >>> +

RE: [PATCH v2 08/16] iommu: introduce device fault data

2017-10-20 Thread Liu, Yi L
, > Kevin > <kevin.t...@intel.com>; Raj, Ashok <ashok....@intel.com>; Alex Williamson > <alex.william...@redhat.com> > Subject: Re: [PATCH v2 08/16] iommu: introduce device fault data > > On 06/10/17 00:03, Jacob Pan wrote: > > Device faults det

Re: [PATCH v2 08/16] iommu: introduce device fault data

2017-10-10 Thread Jacob Pan
On Tue, 10 Oct 2017 20:29:29 +0100 Jean-Philippe Brucker wrote: > > +enum iommu_model { > > + IOMMU_MODEL_INTEL = 1, > > + IOMMU_MODEL_AMD, > > + IOMMU_MODEL_SMMU3, > > +}; > > Now unused, I guess? right, missed it. thanks

Re: [PATCH v2 08/16] iommu: introduce device fault data

2017-10-10 Thread Jean-Philippe Brucker
On 06/10/17 00:03, Jacob Pan wrote: > Device faults detected by IOMMU can be reported outside IOMMU > subsystem. This patch intends to provide a generic device > fault data such that device drivers can communicate IOMMU faults > without model specific knowledge. > > The assumption is that model