RE: [PATCHv8 05/10] ARM: dma-mapping: use asm-generic/dma-mapping-common.h

2012-04-11 Thread Marek Szyprowski
Hi Arnd,

On Tuesday, April 10, 2012 1:47 PM Arnd Bergmann wrote:

 On Tuesday 10 April 2012, Marek Szyprowski wrote:
  This patch modifies dma-mapping implementation on ARM architecture to
  use common dma_map_ops structure and asm-generic/dma-mapping-common.h
  helpers.
 
  Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
  Acked-by: Kyungmin Park kyungmin.p...@samsung.com
  ---
   arch/arm/Kconfig   |1 +
   arch/arm/include/asm/device.h  |1 +
   arch/arm/include/asm/dma-mapping.h |  196 
  +---
   arch/arm/mm/dma-mapping.c  |  148 ---
   4 files changed, 115 insertions(+), 231 deletions(-)
 
 Looks good in principle. One question: Now that many of the functions are only
 used in the dma_map_ops, can you make them 'static' instead?

Some of these non static functions (mainly arm_dma_*_sg_* family) are also used 
by dma bounce
code introduced in the next patch, that's why I left them without static 
attribute.

Best regards
-- 
Marek Szyprowski
Samsung Poland RD Center


___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu


Re: [PATCHv8 05/10] ARM: dma-mapping: use asm-generic/dma-mapping-common.h

2012-04-10 Thread Arnd Bergmann
On Tuesday 10 April 2012, Marek Szyprowski wrote:
 This patch modifies dma-mapping implementation on ARM architecture to
 use common dma_map_ops structure and asm-generic/dma-mapping-common.h
 helpers.
 
 Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
 Acked-by: Kyungmin Park kyungmin.p...@samsung.com
 ---
  arch/arm/Kconfig   |1 +
  arch/arm/include/asm/device.h  |1 +
  arch/arm/include/asm/dma-mapping.h |  196 
 +---
  arch/arm/mm/dma-mapping.c  |  148 ---
  4 files changed, 115 insertions(+), 231 deletions(-)

Looks good in principle. One question: Now that many of the functions are only
used in the dma_map_ops, can you make them 'static' instead?

Arnd
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu