Re: add a new dma_alloc_noncontiguous API v2
Hi Ricardo, On Thu, Feb 11, 2021 at 02:20:30PM +0100, Ricardo Ribalda wrote: > On Thu, Feb 11, 2021 at 2:06 PM Christoph Hellwig wrote: > > On Thu, Feb 11, 2021 at 10:08:18AM +0100, Ricardo Ribalda wrote: > > > Hi Christoph > > > > > > What are your merge plans for the uvc change? > > > http://git.infradead.org/users/hch/dma-mapping.git/commit/3dc47131f8aacc2093f68a9971d24c754e435520 > > > > > > Are you going to remove the patch on your Merge request and then send > > > it for review to Laurent? or merge it through your tree with a S-o-B > > > him? > > > > I though I had all the ACKs to queue it up. Is that not what was > > intended? Queueing up the API without a user is generally a bad idea. > > > > I am pretty sure we need the ack from Laurent. He maintains uvc > > @Laurent Pinchart what are your thoughts? I think it would have been nice to CC me on the patch in the first place :-) I won't have time to review the series before next week at the earliest. -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: add a new dma_alloc_noncontiguous API v2
HI Christoph On Thu, Feb 11, 2021 at 2:06 PM Christoph Hellwig wrote: > > On Thu, Feb 11, 2021 at 10:08:18AM +0100, Ricardo Ribalda wrote: > > Hi Christoph > > > > What are your merge plans for the uvc change? > > http://git.infradead.org/users/hch/dma-mapping.git/commit/3dc47131f8aacc2093f68a9971d24c754e435520 > > > > Are you going to remove the patch on your Merge request and then send > > it for review to Laurent? or merge it through your tree with a S-o-B > > him? > > I though I had all the ACKs to queue it up. Is that not what was > intended? Queueing up the API without a user is generally a bad idea. > I am pretty sure we need the ack from Laurent. He maintains uvc @Laurent Pinchart what are your thoughts? Thanks! -- Ricardo Ribalda ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: add a new dma_alloc_noncontiguous API v2
On Thu, Feb 11, 2021 at 10:08:18AM +0100, Ricardo Ribalda wrote: > Hi Christoph > > What are your merge plans for the uvc change? > http://git.infradead.org/users/hch/dma-mapping.git/commit/3dc47131f8aacc2093f68a9971d24c754e435520 > > Are you going to remove the patch on your Merge request and then send > it for review to Laurent? or merge it through your tree with a S-o-B > him? I though I had all the ACKs to queue it up. Is that not what was intended? Queueing up the API without a user is generally a bad idea. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: add a new dma_alloc_noncontiguous API v2
Hi Christoph What are your merge plans for the uvc change? http://git.infradead.org/users/hch/dma-mapping.git/commit/3dc47131f8aacc2093f68a9971d24c754e435520 Are you going to remove the patch on your Merge request and then send it for review to Laurent? or merge it through your tree with a S-o-B him? Thanks On Tue, Feb 9, 2021 at 6:02 PM Christoph Hellwig wrote: > > On Tue, Feb 09, 2021 at 03:46:13PM +0100, Ricardo Ribalda wrote: > > Hi Christoph > > > > I have tested it in both arm and x86, since there are not significant > > changes with the previous version I did not do a performance test. > > I'll take this as a Tested-by. -- Ricardo Ribalda ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: add a new dma_alloc_noncontiguous API v2
Hi Christoph I have tested it in both arm and x86, since there are not significant changes with the previous version I did not do a performance test. Thanks! On Tue, Feb 9, 2021 at 9:29 AM Ricardo Ribalda wrote: > > Hi Christoph > > On Tue, Feb 9, 2021 at 9:22 AM Christoph Hellwig wrote: > > > > On Mon, Feb 08, 2021 at 08:33:50PM +0900, Tomasz Figa wrote: > > > Sorry for the delay. The whole series looks very good to me. Thanks a lot. > > > > > > Reviewed-by: Tomasz Figa > > > > Thanks. > > > > Ricardo, do the uvcvideo changes look good to you? I'd like to queue > > the series up for this merge window. Tested-by: Ricardo Ribalda > > Let me test them in real hardware today. > > Thanks! > > > -- > Ricardo Ribalda -- Ricardo Ribalda ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: add a new dma_alloc_noncontiguous API v2
Hi Christoph On Tue, Feb 9, 2021 at 9:22 AM Christoph Hellwig wrote: > > On Mon, Feb 08, 2021 at 08:33:50PM +0900, Tomasz Figa wrote: > > Sorry for the delay. The whole series looks very good to me. Thanks a lot. > > > > Reviewed-by: Tomasz Figa > > Thanks. > > Ricardo, do the uvcvideo changes look good to you? I'd like to queue > the series up for this merge window. Let me test them in real hardware today. Thanks! -- Ricardo Ribalda ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: add a new dma_alloc_noncontiguous API v2
Hi Christoph, On Mon, Feb 8, 2021 at 3:49 AM Christoph Hellwig wrote: > > Any comments? > Sorry for the delay. The whole series looks very good to me. Thanks a lot. Reviewed-by: Tomasz Figa Best regards, Tomasz > On Tue, Feb 02, 2021 at 10:51:03AM +0100, Christoph Hellwig wrote: > > Hi all, > > > > this series adds the new noncontiguous DMA allocation API requested by > > various media driver maintainers. > > > > Changes since v1: > > - document that flush_kernel_vmap_range and invalidate_kernel_vmap_range > >must be called once an allocation is mapped into KVA > > - add dma-debug support > > - remove the separate dma_handle argument, and instead create fully formed > >DMA mapped scatterlists > > - use a directional allocation in uvcvideo > > - call invalidate_kernel_vmap_range from uvcvideo > > ___ > > iommu mailing list > > iommu@lists.linux-foundation.org > > https://lists.linuxfoundation.org/mailman/listinfo/iommu > ---end quoted text--- ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: add a new dma_alloc_noncontiguous API v2
Any comments? On Tue, Feb 02, 2021 at 10:51:03AM +0100, Christoph Hellwig wrote: > Hi all, > > this series adds the new noncontiguous DMA allocation API requested by > various media driver maintainers. > > Changes since v1: > - document that flush_kernel_vmap_range and invalidate_kernel_vmap_range >must be called once an allocation is mapped into KVA > - add dma-debug support > - remove the separate dma_handle argument, and instead create fully formed >DMA mapped scatterlists > - use a directional allocation in uvcvideo > - call invalidate_kernel_vmap_range from uvcvideo > ___ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu ---end quoted text--- ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
add a new dma_alloc_noncontiguous API v2
Hi all, this series adds the new noncontiguous DMA allocation API requested by various media driver maintainers. Changes since v1: - document that flush_kernel_vmap_range and invalidate_kernel_vmap_range must be called once an allocation is mapped into KVA - add dma-debug support - remove the separate dma_handle argument, and instead create fully formed DMA mapped scatterlists - use a directional allocation in uvcvideo - call invalidate_kernel_vmap_range from uvcvideo ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
