Re: dma-mapping: clearing GFP_ZERO flag caused crashes of Ethernet on arc/hsdk board.

2018-03-28 Thread h...@lst.de
> > The logical question is why? > > 1. See that's another platform with ARC core so maybe in case of ARM >DMA allocator already zeroes pages regardless provided flags - >personally I didn't check that. Yes, most architectures always clear memory returned by dma_alloc*. Looks like a few

Re: dma-mapping: clearing GFP_ZERO flag caused crashes of Ethernet on arc/hsdk board.

2018-03-27 Thread Alexey Brodkin
Hi Andy, On Tue, 2018-03-27 at 21:11 +0300, Andy Shevchenko wrote: > On Tue, Mar 27, 2018 at 8:12 PM, Evgeniy Didin > wrote: > > Hello, > > > > After commit 57bf5a8963f8 ("dma-mapping: clear harmful GFP_* flags in > > common code") we noticed problems with

Re: dma-mapping: clearing GFP_ZERO flag caused crashes of Ethernet on arc/hsdk board.

2018-03-27 Thread Vineet Gupta
Hi Christoph, Andy On 03/27/2018 11:11 AM, Andy Shevchenko wrote: On Tue, Mar 27, 2018 at 8:12 PM, Evgeniy Didin wrote: Hello, After commit 57bf5a8963f8 ("dma-mapping: clear harmful GFP_* flags in common code") we noticed problems with Ethernet controller on

Re: dma-mapping: clearing GFP_ZERO flag caused crashes of Ethernet on arc/hsdk board.

2018-03-27 Thread Andy Shevchenko
On Tue, Mar 27, 2018 at 8:12 PM, Evgeniy Didin wrote: > Hello, > > After commit 57bf5a8963f8 ("dma-mapping: clear harmful GFP_* flags in common > code") we noticed problems with Ethernet controller on one of our platforms > (namely ARC HSDK). > I > n particular we

dma-mapping: clearing GFP_ZERO flag caused crashes of Ethernet on arc/hsdk board.

2018-03-27 Thread Evgeniy Didin
Hello, After commit 57bf5a8963f8 ("dma-mapping: clear harmful GFP_* flags in common code") we noticed problems with Ethernet controller on one of our platforms (namely ARC HSDK). I n particular we see that removal of __GFP_ZERO flag in function dma_alloc_attrs() was the culprit because in