[PATCH v5 21/22] vfio-pci: Add VFIO_PCI_DMA_FAULT_IRQ_INDEX

2019-03-15 Thread Eric Auger
Add a new VFIO_PCI_DMA_FAULT_IRQ_INDEX index. This allows to set/unset an eventfd that will be triggered when DMA translation faults are detected at physical level when the nested mode is used. Signed-off-by: Eric Auger --- drivers/vfio/pci/vfio_pci.c | 3 +++

[PATCH v5 20/22] vfio_pci: Allow to mmap the fault queue

2019-03-15 Thread Eric Auger
The Producer Fault region contains the fault queue in the second page. There is benefit to let the userspace mmap this area. So let's expose this mmappable area through a sparse mmap entry and implement the mmap operation. Signed-off-by: Eric Auger --- drivers/vfio/pci/vfio_pci.c | 61

[PATCH v5 22/22] vfio: Document nested stage control

2019-03-15 Thread Eric Auger
New iotcls were introduced to pass information about guest stage1 to the host through VFIO. Let's document the nested stage control. Signed-off-by: Eric Auger --- v2 -> v3: - document the new fault API v1 -> v2: - use the new ioctl names - add doc related to fault handling ---

[PATCH v5 11/22] iommu/arm-smmu-v3: Maintain a SID->device structure

2019-03-15 Thread Eric Auger
From: Jean-Philippe Brucker When handling faults from the event or PRI queue, we need to find the struct device associated to a SID. Add a rb_tree to keep track of SIDs. Signed-off-by: Jean-Philippe Brucker --- drivers/iommu/arm-smmu-v3.c | 136 ++-- 1 file

[PATCH v5 09/22] vfio: VFIO_IOMMU_BIND/UNBIND_MSI

2019-03-15 Thread Eric Auger
This patch adds the VFIO_IOMMU_BIND/UNBIND_MSI ioctl which aim to pass/withdraw the guest MSI binding to/from the host. Signed-off-by: Eric Auger --- v3 -> v4: - add UNBIND - unwind on BIND error v2 -> v3: - adapt to new proto of bind_guest_msi - directly use vfio_iommu_for_each_dev v1 -> v2:

[PATCH v5 15/22] dma-iommu: Implement NESTED_MSI cookie

2019-03-15 Thread Eric Auger
Up to now, when the type was UNMANAGED, we used to allocate IOVA pages within a range provided by the user. This does not work in nested mode. If both the host and the guest are exposed with SMMUs, each would allocate an IOVA. The guest allocates an IOVA (gIOVA) to map onto the guest MSI doorbell

[PATCH v5 12/22] iommu/smmuv3: Get prepared for nested stage support

2019-03-15 Thread Eric Auger
To allow nested stage support, we need to store both stage 1 and stage 2 configurations (and remove the former union). A nested setup is characterized by both s1_cfg and s2_cfg set. We introduce a new ste.abort field that will be set upon guest stage1 configuration passing. If s1_cfg is NULL and

[PATCH v5 17/22] iommu/smmuv3: Report non recoverable faults

2019-03-15 Thread Eric Auger
When a stage 1 related fault event is read from the event queue, let's propagate it to potential external fault listeners, ie. users who registered a fault handler. Signed-off-by: Eric Auger --- v4 -> v5: - s/IOMMU_FAULT_PERM_INST/IOMMU_FAULT_PERM_EXEC --- drivers/iommu/arm-smmu-v3.c | 169

[PATCH v5 16/22] iommu/smmuv3: Implement bind/unbind_guest_msi

2019-03-15 Thread Eric Auger
The bind/unbind_guest_msi() callbacks check the domain is NESTED and redirect to the dma-iommu implementation. Signed-off-by: Eric Auger --- drivers/iommu/arm-smmu-v3.c | 44 + 1 file changed, 44 insertions(+) diff --git a/drivers/iommu/arm-smmu-v3.c

[PATCH v5 18/22] vfio-pci: Add a new VFIO_REGION_TYPE_NESTED region type

2019-03-15 Thread Eric Auger
This patch adds two new regions aiming to handle nested mode translation faults. The first region (two host kernel pages) is read-only from the user-space perspective. The first page contains an header that provides information about the circular buffer located in the second page. The circular

[PATCH v5 13/22] iommu/smmuv3: Implement attach/detach_pasid_table

2019-03-15 Thread Eric Auger
On attach_pasid_table() we program STE S1 related info set by the guest into the actual physical STEs. At minimum we need to program the context descriptor GPA and compute whether the stage1 is translated/bypassed or aborted. Signed-off-by: Eric Auger --- v3 -> v4: - adapt to changes in

[PATCH v5 10/22] iommu/arm-smmu-v3: Link domains and devices

2019-03-15 Thread Eric Auger
From: Jean-Philippe Brucker When removing a mapping from a domain, we need to send an invalidation to all devices that might have stored it in their Address Translation Cache (ATC). In addition with SVM, we'll need to invalidate context descriptors of all devices attached to a live domain.

[PATCH v5 14/22] iommu/smmuv3: Implement cache_invalidate

2019-03-15 Thread Eric Auger
Implement domain-selective and page-selective IOTLB invalidations. Signed-off-by: Eric Auger --- v3 -> v4: - adapt to changes in the uapi - add support for leaf parameter - do not use arm_smmu_tlb_inv_range_nosync or arm_smmu_tlb_inv_context anymore v2 -> v3: - replace __arm_smmu_tlb_sync

[PATCH v5 19/22] vfio-pci: Register an iommu fault handler

2019-03-15 Thread Eric Auger
This patch registers a fault handler which records faults in a circular buffer and then signals an eventfd. This buffer is exposed within the fault region. Signed-off-by: Eric Auger --- v3 -> v4: - move iommu_unregister_device_fault_handler to vfio_pci_release --- drivers/vfio/pci/vfio_pci.c

[PATCH v5 00/22] SMMUv3 Nested Stage Setup

2019-03-15 Thread Eric Auger
This series allows a virtualizer to program the nested stage mode. This is useful when both the host and the guest are exposed with an SMMUv3 and a PCI device is assigned to the guest using VFIO. In this mode, the physical IOMMU must be programmed to translate the two stages: the one set up by

[git pull] IOMMU Fix for Linux v5.1-rc1

2019-03-15 Thread Joerg Roedel
Hi Linus, The following changes since commit d05e4c8600c36084ce9de6249bb972c9bdd75b7e: Merge branches 'iommu/fixes', 'arm/msm', 'arm/tegra', 'arm/mediatek', 'x86/vt-d', 'x86/amd', 'hyper-v' and 'core' into next (2019-03-01 11:24:51 +0100) are available in the Git repository at:

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-15 Thread Helen Koike
On 3/15/19 8:29 AM, Michel Dänzer wrote: > On 2019-03-15 11:25 a.m., Boris Brezillon wrote: >> On Fri, 15 Mar 2019 11:11:36 +0100 >> Michel Dänzer wrote: >> >>> On 2019-03-14 6:51 p.m., Helen Koike wrote: On 3/14/19 6:15 AM, Michel Dänzer wrote: > On 2019-03-13 7:08 p.m., Helen Koike

Re: [RESEND][PATCH] iommu/amd: Fix NULL dereference bug in match_hid_uid

2019-03-15 Thread Joerg Roedel
On Wed, Mar 13, 2019 at 09:53:24PM +0800, Aaron Ma wrote: > Add a non-NULL check to fix potential NULL pointer dereference > Cleanup code to call function once. > > Signed-off-by: Aaron Ma > --- > drivers/iommu/amd_iommu.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-)

[PATCH v5 05/22] iommu: Introduce cache_invalidate API

2019-03-15 Thread Eric Auger
From: "Liu, Yi L" In any virtualization use case, when the first translation stage is "owned" by the guest OS, the host IOMMU driver has no knowledge of caching structure updates unless the guest invalidation activities are trapped by the virtualizer and passed down to the host. Since the

[PATCH v5 03/22] iommu: introduce device fault report API

2019-03-15 Thread Eric Auger
From: Jacob Pan Traditionally, device specific faults are detected and handled within their own device drivers. When IOMMU is enabled, faults such as DMA related transactions are detected by IOMMU. There is no generic reporting mechanism to report faults back to the in-kernel device driver or

[PATCH v5 04/22] iommu: Introduce attach/detach_pasid_table API

2019-03-15 Thread Eric Auger
From: Jacob Pan In virtualization use case, when a guest is assigned a PCI host device, protected by a virtual IOMMU on the guest, the physical IOMMU must be programmed to be consistent with the guest mappings. If the physical IOMMU supports two translation stages it makes sense to program guest

[PATCH v5 02/22] iommu: introduce device fault data

2019-03-15 Thread Eric Auger
From: Jacob Pan Device faults detected by IOMMU can be reported outside the IOMMU subsystem for further processing. This patch introduces a generic device fault data structure. The fault can be either an unrecoverable fault or a page request, also referred to as a recoverable fault. We only

[PATCH v5 01/22] driver core: add per device iommu param

2019-03-15 Thread Eric Auger
From: Jacob Pan DMA faults can be detected by IOMMU at device level. Adding a pointer to struct device allows IOMMU subsystem to report relevant faults back to the device driver for further handling. For direct assigned device (or user space drivers), guest OS holds responsibility to handle and

[PATCH v5 06/22] iommu: Introduce bind/unbind_guest_msi

2019-03-15 Thread Eric Auger
On ARM, MSI are translated by the SMMU. An IOVA is allocated for each MSI doorbell. If both the host and the guest are exposed with SMMUs, we end up with 2 different IOVAs allocated by each. guest allocates an IOVA (gIOVA) to map onto the guest MSI doorbell (gDB). The Host allocates another IOVA

[PATCH v5 08/22] vfio: VFIO_IOMMU_CACHE_INVALIDATE

2019-03-15 Thread Eric Auger
From: "Liu, Yi L" When the guest "owns" the stage 1 translation structures, the host IOMMU driver has no knowledge of caching structure updates unless the guest invalidation requests are trapped and passed down to the host. This patch adds the VFIO_IOMMU_CACHE_INVALIDATE ioctl with aims at

[PATCH v5 07/22] vfio: VFIO_IOMMU_ATTACH/DETACH_PASID_TABLE

2019-03-15 Thread Eric Auger
From: "Liu, Yi L" This patch adds VFIO_IOMMU_ATTACH/DETACH_PASID_TABLE ioctl which aims to pass/withdraw the virtual iommu guest configuration to/from the VFIO driver downto to the iommu subsystem. Signed-off-by: Jacob Pan Signed-off-by: Liu, Yi L Signed-off-by: Eric Auger --- v3 -> v4: -

Re: [PATCH] iommu/amd: Fix a null pointer dereference for ACPI devices

2019-03-15 Thread Joerg Roedel
Hi Chris, On Fri, Mar 08, 2019 at 12:12:10PM +0800, Chris Chiu wrote: > On ASUS laptop X512DK with the realtek USB card reader, the NULL > pointer dereference happens while bringing up the rtsx_usb driver. Thanks for your patch, but I applied

Re: [PATCH v5 05/22] iommu: Introduce cache_invalidate API

2019-03-15 Thread Jacob Pan
On Fri, 15 Mar 2019 17:08:49 +0100 Eric Auger wrote: > From: "Liu, Yi L" > > In any virtualization use case, when the first translation stage > is "owned" by the guest OS, the host IOMMU driver has no knowledge > of caching structure updates unless the guest invalidation activities > are

Re: [git pull] IOMMU Fix for Linux v5.1-rc1

2019-03-15 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Mar 2019 16:44:07 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git > tags/iommu-fix-v5.1-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/323ea40ff6fb1e9d2c481bff50245ee5f559c8af Thank you! --

[PATCH] iommu/iova: Fix tracking of recently failed iova address size

2019-03-15 Thread Robert Richter
We track the smallest size that failed for a 32 bit allocation. The Size decreases only and if we actually walked the tree and noticed an allocation failure. Current code is broken and wrongly updates the size value even if we did not try an allocation. This leads to increased size values and we

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-15 Thread Boris Brezillon
On Fri, 15 Mar 2019 11:11:36 +0100 Michel Dänzer wrote: > On 2019-03-14 6:51 p.m., Helen Koike wrote: > > On 3/14/19 6:15 AM, Michel Dänzer wrote: > >> On 2019-03-13 7:08 p.m., Helen Koike wrote: > >>> On 3/13/19 6:58 AM, Michel Dänzer wrote: > On 2019-03-13 4:42 a.m., Tomasz Figa

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-15 Thread Michel Dänzer
On 2019-03-15 11:25 a.m., Boris Brezillon wrote: > On Fri, 15 Mar 2019 11:11:36 +0100 > Michel Dänzer wrote: > >> On 2019-03-14 6:51 p.m., Helen Koike wrote: >>> On 3/14/19 6:15 AM, Michel Dänzer wrote: On 2019-03-13 7:08 p.m., Helen Koike wrote: > On 3/13/19 6:58 AM, Michel Dänzer

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-15 Thread Michel Dänzer
On 2019-03-14 6:51 p.m., Helen Koike wrote: > On 3/14/19 6:15 AM, Michel Dänzer wrote: >> On 2019-03-13 7:08 p.m., Helen Koike wrote: >>> On 3/13/19 6:58 AM, Michel Dänzer wrote: On 2019-03-13 4:42 a.m., Tomasz Figa wrote: > On Wed, Mar 13, 2019 at 12:52 AM Boris Brezillon > wrote: