[PATCH -next] iommu/amd: Remove set but not used variable 'iommu'

2020-05-08 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/iommu/amd_iommu.c: In function 'amd_iommu_uninit_device': drivers/iommu/amd_iommu.c:422:20: warning: variable 'iommu' set but not used [-Wunused-but-set-variable] commit dce8d6964ebd ("iommu/amd: Convert to probe/release_device()

Re: [PATCH v5] iommu/arm-smmu-qcom: Request direct mapping for modem device

2020-05-08 Thread Sibi Sankar
Hey Stephen, Thanks for taking time to review the patch. On 5/8/20 2:44 AM, Stephen Boyd wrote: Quoting Sibi Sankar (2020-05-07 12:21:57) The modem remote processor has two modes of access to the DDR, a direct mode and through a SMMU which requires direct mapping. The configuration of the

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-08 Thread Rob Clark
On Thu, May 7, 2020 at 5:54 AM Will Deacon wrote: > > On Thu, May 07, 2020 at 11:55:54AM +0100, Robin Murphy wrote: > > On 2020-05-07 11:14 am, Sai Prakash Ranjan wrote: > > > On 2020-04-22 01:50, Sai Prakash Ranjan wrote: > > > > Add stall implementation hook to enable stalling > > > > faults on

Re: [PATCH] iommu/virtio: reverse arguments to list_add

2020-05-08 Thread Joerg Roedel
On Tue, May 05, 2020 at 08:47:47PM +0200, Julia Lawall wrote: > Elsewhere in the file, there is a list_for_each_entry with > >resv_regions as the second argument, suggesting that > >resv_regions is the list head. So exchange the > arguments on the list_add call to put the list head in the >

Re: [PATCH] iomm/arm-smmu: Add stall implementation hook

2020-05-08 Thread Rob Clark
On Fri, May 8, 2020 at 8:32 AM Rob Clark wrote: > > On Thu, May 7, 2020 at 5:54 AM Will Deacon wrote: > > > > On Thu, May 07, 2020 at 11:55:54AM +0100, Robin Murphy wrote: > > > On 2020-05-07 11:14 am, Sai Prakash Ranjan wrote: > > > > On 2020-04-22 01:50, Sai Prakash Ranjan wrote: > > > > > Add

Re: [PATCH] iommu/iova: Retry from last rb tree node if iova search fails

2020-05-08 Thread Vijayanand Jitta
On 5/7/2020 6:54 PM, Robin Murphy wrote: > On 2020-05-06 9:01 pm, vji...@codeaurora.org wrote: >> From: Vijayanand Jitta >> >> When ever a new iova alloc request comes iova is always searched >> from the cached node and the nodes which are previous to cached >> node. So, even if there is free

[PATCH] iommu/renesas: fix unused-function warning

2020-05-08 Thread Arnd Bergmann
gcc warns because the only reference to ipmmu_find_group is inside of an #ifdef: drivers/iommu/ipmmu-vmsa.c:878:28: error: 'ipmmu_find_group' defined but not used [-Werror=unused-function] Change the #ifdef to an equivalent IS_ENABLED(). Fixes: 6580c8a78424 ("iommu/renesas: Convert to

Re: [PATCH] iommu/arm-smmu-v3: Don't reserve implementation defined register space

2020-05-08 Thread Tuan Phan
> On May 6, 2020, at 10:46 AM, Jean-Philippe Brucker > wrote: > > Some SMMUv3 implementation embed the Perf Monitor Group Registers (PMCG) > inside the first 64kB region of the SMMU. Since PMCG are managed by a > separate driver, this layout causes resource reservation conflicts > during

[PATCH -next] iommu/amd: fix variable "iommu" set but not used

2020-05-08 Thread Qian Cai
The commit dce8d6964ebd ("iommu/amd: Convert to probe/release_device() call-backs") introduced an unused variable, drivers/iommu/amd_iommu.c: In function 'amd_iommu_uninit_device': drivers/iommu/amd_iommu.c:422:20: warning: variable 'iommu' set but not used [-Wunused-but-set-variable] struct

Re: [PATCH v3 02/25] drm: core: fix common struct sg_table related issues

2020-05-08 Thread Christoph Hellwig
On Fri, May 08, 2020 at 09:12:13AM +0200, Marek Szyprowski wrote: > Then we would just need one more helper to construct scatterlist, as the > above two are read-only don't allow to modify scatterlist: > > #define for_each_sgtable_sg(sgt, sg, i)    \ >    for_each_sg(sgt->sgl,

Re: [PATCH v3 02/25] drm: core: fix common struct sg_table related issues

2020-05-08 Thread Marek Szyprowski
Hi Christoph, On 05.05.2020 13:09, Christoph Hellwig wrote: > On Tue, May 05, 2020 at 12:51:58PM +0200, Marek Szyprowski wrote: >> On 05.05.2020 12:15, Christoph Hellwig wrote: - for_each_sg_page(st->sgl, _iter, st->nents, 0) + for_each_sg_page(st->sgl, _iter,

[PATCH -next] iommu/arm-smmu-v3: remove set but not used variable 'smmu'

2020-05-08 Thread Chen Zhou
Fixes gcc '-Wunused-but-set-variable' warning: drivers/iommu/arm-smmu-v3.c:2989:26: warning: variable ‘smmu’ set but not used [-Wunused-but-set-variable] struct arm_smmu_device *smmu; Reported-by: Hulk Robot Signed-off-by: Chen Zhou --- drivers/iommu/arm-smmu-v3.c | 2 -- 1 file changed, 2

[PATCH -next] iommu: remove set but not used variable 'data'

2020-05-08 Thread Chen Zhou
Fixes gcc '-Wunused-but-set-variable' warning: drivers/iommu/mtk_iommu_v1.c:467:25: warning: variable ‘data’ set but not used [-Wunused-but-set-variable] struct mtk_iommu_data *data; Reported-by: Hulk Robot Signed-off-by: Chen Zhou --- drivers/iommu/mtk_iommu_v1.c | 3 +-- 1 file changed, 1