Re: [PATCH -next] iommu/of: Check for valid fwspec after of_pci_iommu_init

2017-08-02 Thread Sudeep Holla
On 02/08/17 17:39, Robin Murphy wrote: > On 02/08/17 17:11, Sudeep Holla wrote: >> The successful return from of_pci_iommu_init doesn't ensure valid >> fwspec if it's IOMMU is disabled. >> >> Accessing dev->iommu_fwspec->ops without checking dev->iommu_fw

[PATCH -next] iommu/of: Check for valid fwspec after of_pci_iommu_init

2017-08-02 Thread Sudeep Holla
k for dev->iommu_fwspec and fixes the above. Fixes: d87beb749281 ("iommu/of: Handle PCI aliases properly") Cc: Robin Murphy <robin.mur...@arm.com> Signed-off-by: Sudeep Holla <sudeep.ho...@arm.com> --- drivers/iommu/of_iommu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

Re: [PATCH] iommu/of: Fix of_iommu_configure() for disabled IOMMUs

2017-08-04 Thread Sudeep Holla
ble IOMMU, > then retrieve the ops from the fwspec if and when we actually need them. > This makes everything a bit more uniform and certainly easier to follow. > > Reported-by: Sudeep Holla <sudeep.ho...@arm.com> Tested-by: Sudeep Holla <sudeep.ho...@arm.com> -- Regards, Sudee

Re: [PATCH v2 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state()

2022-07-01 Thread Sudeep Holla
Hi, Saravana, On Fri, Jul 01, 2022 at 01:26:12AM -0700, Saravana Kannan wrote: [...] > Can you check if this hack helps? If so, then I can think about > whether we can pick it up without breaking everything else. Copy-paste > tab mess up warning. Sorry for jumping in late and not even sure if