Re: [PATCH 0/5] iommu/omap: Add support for iommu-groups and 'struct iommu_device'

2017-04-03 Thread Suman Anna
Hi Joerg, On 03/31/2017 07:10 AM, Joerg Roedel wrote: > Hi, > > here is a small patch-set for the omap-iommu driver to make > it use new features of the iommu-core. Please review. Thanks for the patches - this has been on my TODO list but you beat me in getting there first :). Are these for 4.12

Re: [PATCH 1/5] iommu/omap: Move data structures to omap-iommu.h

2017-04-03 Thread Suman Anna
On 03/31/2017 07:10 AM, Joerg Roedel wrote: > From: Joerg Roedel > > The internal data-structures are scattered over various > header and C files. Consolidate them in omap-iommu.h. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu/omap-iommu.c | 16 > drivers

Re: [PATCH 3/5] iommu/omap: Set dev->archdata.iommu = NULL in omap_iommu_remove_device

2017-04-03 Thread Suman Anna
Hi Joerg, On 03/31/2017 07:10 AM, Joerg Roedel wrote: > From: Joerg Roedel > > Don't leave a stale pointer in case the device continues to > exist for some more time. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu/omap-iommu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/d

Re: [PATCH 2/5] iommu/omap: Permanently keep iommu_dev pointer in arch_data

2017-04-03 Thread Suman Anna
Hi Joerg, On 03/31/2017 07:10 AM, Joerg Roedel wrote: > From: Joerg Roedel > > Instead of finding the matching IOMMU for a device using > string comparision functions, keep the pointer to the > iommu_dev in arch_data permanently populated. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu

Re: [PATCH 1/4] iommu/omap: Move data structures to omap-iommu.h

2017-04-11 Thread Suman Anna
On 04/07/2017 09:41 AM, Joerg Roedel wrote: > From: Joerg Roedel > > The internal data-structures are scattered over various > header and C files. Consolidate them in omap-iommu.h. > > Signed-off-by: Joerg Roedel Acked-by:

Re: [PATCH 2/4] iommu/omap: Set dev->archdata.iommu = NULL in omap_iommu_remove_device

2017-04-11 Thread Suman Anna
On 04/07/2017 09:41 AM, Joerg Roedel wrote: > From: Joerg Roedel > > Don't leave a stale pointer in case the device continues to > exist for some more time. > > Signed-off-by: Joerg Roedel Acked-by: Suman Anna > --- > drivers/iommu/omap-iommu.c | 2 ++ &g

Re: [PATCH 3/4] iommu/omap: Make use of 'struct iommu_device'

2017-04-11 Thread Suman Anna
Hi Joerg, On 04/07/2017 09:41 AM, Joerg Roedel wrote: > From: Joerg Roedel > > Modify the driver to register individual iommus and > establish links between devices and iommus in sysfs. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu/omap-iommu.c | 25 + > driver

Re: [PATCH 4/4] iommu/omap: Add iommu-group support

2017-04-11 Thread Suman Anna
Hi Joerg, This patch is still causing couple of issues. Adding Laurent and Sakari to the thread as we do have the OMAP3ISP driver which would need some changes once the iommu groups are implemented in the OMAP IOMMU driver. The OMAP3 ISP driver (drivers/media/platform/omap3isp/isp.c) is currently

[PATCH v3 2/7] iommu/omap: Drop legacy-style device support

2017-04-11 Thread Suman Anna
platform data is still needed though for performing reset management properly in a multi-arch environment. Signed-off-by: Suman Anna --- v3: New patch drivers/iommu/omap-iommu.c | 30 ++ include/linux/platform_data/iommu-omap.h | 3 --- 2 files changed, 14

[PATCH v3 1/7] iommu/omap: Register driver before setting IOMMU ops

2017-04-11 Thread Suman Anna
driver. While at this, also check for the return status from bus_set_iommu. Signed-off-by: Suman Anna --- v3: New patch drivers/iommu/omap-iommu.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c

[PATCH v3 6/7] iommu/omap: Add iommu-group support

2017-04-11 Thread Suman Anna
From: Joerg Roedel Support for IOMMU groups will become mandatory for drivers, so add it to the omap iommu driver. Signed-off-by: Joerg Roedel [s-a...@ti.com: minor error cleanups] Signed-off-by: Suman Anna --- v3 w.r.t v1: - iommu_group_get_for_dev() failure path cleanup code added in

[PATCH v3 5/7] iommu/omap: Make use of 'struct iommu_device'

2017-04-11 Thread Suman Anna
From: Joerg Roedel Modify the driver to register individual iommus and establish links between devices and iommus in sysfs. Signed-off-by: Joerg Roedel [s-a...@ti.com: fix some cleanup issues during failures] Signed-off-by: Suman Anna --- v3 w.r.t v1: - moved the iommu_device calls in probe

[PATCH v3 3/7] iommu/omap: Move data structures to omap-iommu.h

2017-04-11 Thread Suman Anna
: revise kerneldoc comments] Signed-off-by: Suman Anna --- v3 w.r.t v2: - added kerneldoc comment for @domain - renamed iommu_arch_data to omap_iommu_arch_data in comments drivers/iommu/omap-iommu.c | 16 drivers/iommu/omap-iommu.h | 33

[PATCH v3 0/7] iommu/omap: Add support for iommu-groups and 'struct iommu_device'

2017-04-11 Thread Suman Anna
ake use of 'struct iommu_device' iommu/omap: Add iommu-group support Suman Anna (3): iommu/omap: Register driver before setting IOMMU ops iommu/omap: Drop legacy-style device support [media] omap3isp: Remove iommu_group related code drivers/iommu/omap

[PATCH v3 7/7] [media] omap3isp: Remove iommu_group related code

2017-04-11 Thread Suman Anna
: Suman Anna --- v3: new patch drivers/media/platform/omap3isp/isp.c | 17 - drivers/media/platform/omap3isp/isp.h | 1 - 2 files changed, 18 deletions(-) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 084ecf4aa9a4..0d984a28a003

[PATCH v3 4/7] iommu/omap: Store iommu_dev pointer in arch_data

2017-04-11 Thread Suman Anna
[s-a...@ti.com: few minor cleanups] Signed-off-by: Suman Anna --- v3 w.r.t v1: - dropped the iommu_domain from arch_data (same as in v2) - squashed patch 3 from v1 into this patch - minor revisions to the commit subject and description - renamed the iommu variable to oiommu in add_device

[PATCH] iommu/omap: fix checkpatch warnings in omap iommu code

2013-05-30 Thread Suman Anna
This patch fixes the checkpatch warnings in omap iommu code, most of them are related to broken strings. Signed-off-by: Suman Anna --- drivers/iommu/omap-iommu.c | 9 - drivers/iommu/omap-iopgtable.h | 2 +- drivers/iommu/omap-iovmm.c | 4 ++-- 3 files changed, 7 insertions

[PATCH] iommu/omap: fix printk formats for dma_addr_t

2013-05-30 Thread Suman Anna
_addr_t' drivers/iommu/omap-iommu.c:1245:4: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'dma_addr_t' Signed-off-by: Suman Anna --- drivers/iommu/omap-iommu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

Re: [PATCH] iommu/omap: Remove casting the return value which is a void pointer

2013-09-12 Thread Suman Anna
On 09/09/2013 12:39 AM, Jingoo Han wrote: > Casting the return value which is a void pointer is redundant. > The conversion from void pointer to any other pointer type is > guaranteed by the C programming language. > > Signed-off-by: Jingoo Han Thanks, LGTM. > --- > drivers/iommu/omap-iopgtabl

[PATCHv2 02/16] iommu/omap: omap_iommu_attach() should return ENODEV, not NULL

2014-02-13 Thread Suman Anna
, omap_iommu_attach() should return ENODEV, not NULL. Signed-off-by: Florian Vaussard Acked-by: Suman Anna --- drivers/iommu/omap-iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index fff2ffd..6272c36 100644

[PATCHv2 10/16] ARM: OMAP2+: use pdata quirks for iommu reset lines

2014-02-13 Thread Suman Anna
portions are decoupled from omap_hwmod/omap_device into a separate reset driver. This patch adds the pdata quirks for the reset management of iommus within the DSP (OMAP3 & OMAP4) and IPU subsystems (OMAP4). Signed-off-by: Suman Anna --- arch/arm/mach-omap2/pdata-quirks.c

[PATCHv2 07/16] iommu/omap: allow enable/disable even without pdata

2014-02-13 Thread Suman Anna
From: Florian Vaussard When booting with a devicetree, no platform data is provided. Do not prematurely exit iommu_enable() and iommu_disable() in such a case. Note: As OMAP do not yet has a proper reset controller driver, IOMMUs requiring a reset signal should use pdata-quirks as a transitional

[PATCHv2 01/16] iommu/omap: convert to devm_* interfaces

2014-02-13 Thread Suman Anna
Use the various devm_ interfaces to simplify the cleanup in probe and remove functions. Signed-off-by: Florian Vaussard Signed-off-by: Suman Anna --- drivers/iommu/omap-iommu.c | 52 +- 1 file changed, 10 insertions(+), 42 deletions(-) diff --git a

[PATCHv2 06/16] iommu/omap: allocate archdata on the fly for DT-based devices

2014-02-13 Thread Suman Anna
name instead of OF name] Signed-off-by: Suman Anna --- drivers/iommu/omap-iommu.c | 45 + 1 file changed, 45 insertions(+) diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index e64025a..f6afe8f 100644 --- a/drivers/iommu/omap-iommu.c

[PATCHv2 00/16] OMAP IOMMU DT adaptation and cleanup

2014-02-13 Thread Suman Anna
e legacy omap-iommu.c Laurent Pinchart (1): iommu/omap: allocate archdata on the fly for DT-based devices Suman Anna (7): iommu/omap: convert to devm_* interfaces iommu/omap: enable bus-error back on supported iommus ARM: OMAP2+: change the ISP device archdata MMU name ARM: OMAP2+: us

[PATCHv2 12/16] ARM: OMAP5: hwmod data: add mmu data for ipu & dsp

2014-02-13 Thread Suman Anna
A new MMU hwmod class and data structures are created to represent the MMUs within the IPU and DSP processor subsystems in OMAP5. The MMUs in OMAP5 are identical to those in OMAP4. Signed-off-by: Suman Anna --- arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 83 ++ 1

[PATCHv2 16/16] ARM: OMAP2+: Remove legacy omap-iommu.c

2014-02-13 Thread Suman Anna
From: Florian Vaussard With full DT boot, the legacy mode of platform device creation for OMAP IOMMUs is not needed anymore. Signed-off-by: Florian Vaussard --- arch/arm/mach-omap2/Makefile | 3 -- arch/arm/mach-omap2/omap-iommu.c | 79 2 files cha

[PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-13 Thread Suman Anna
err-back'. Signed-off-by: Florian Vaussard [s-a...@ti.com: split bindings document, add dra7 and bus error back] Signed-off-by: Suman Anna --- .../devicetree/bindings/iommu/ti,omap-iommu.txt| 28 ++ 1 file changed, 28 insertions(+) create mode 100644 Documentatio

[PATCHv2 11/16] ARM: OMAP3: fix iva mmu programming issues

2014-02-13 Thread Suman Anna
, and there is no automatic power domain switching to ON. Signed-off-by: Suman Anna --- arch/arm/mach-omap2/clockdomains3xxx_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2

[PATCHv2 14/16] ARM: OMAP3: hwmod data: cleanup data for IOMMUs

2014-02-13 Thread Suman Anna
From: Florian Vaussard The irq numbers, ocp address space and device attribute data have all been cleaned up for OMAP3 IOMMUs. All this data is populated via the corresponding dt node. Signed-off-by: Florian Vaussard Signed-off-by: Suman Anna --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c

[PATCHv2 05/16] iommu/omap: enable bus-error back on supported iommus

2014-02-13 Thread Suman Anna
a bus fault and provide additional debug information. This feature is turned on by default by the driver on iommus supporting it. Signed-off-by: Subramaniam Chanderashekarapuram Signed-off-by: Suman Anna --- drivers/iommu/omap-iommu.c | 2 ++ drivers/iommu/omap-iommu.h | 5 + drivers/iommu

[PATCHv2 04/16] iommu/omap: add devicetree support

2014-02-13 Thread Suman Anna
t! Signed-off-by: Florian Vaussard [s-a...@ti.com: dev_name adaptation and improved error checking] Signed-off-by: Suman Anna --- arch/arm/mach-omap2/omap-iommu.c | 5 + drivers/iommu/omap-iommu.c | 41 2 files changed, 42 insertions(+), 4

[PATCHv2 09/16] ARM: OMAP2+: change the ISP device archdata MMU name

2014-02-13 Thread Suman Anna
forward. Signed-off-by: Suman Anna --- arch/arm/mach-omap2/devices.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 0dd6398..3bf0452 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm/mach-omap2/devices.c

[PATCHv2 15/16] ARM: OMAP4: hwmod data: cleanup data for IOMMUs

2014-02-13 Thread Suman Anna
From: Florian Vaussard The device attribute data and ocp address space have all been cleaned up for OMAP4 iommus. All this data is populated via the corresponding dt node. Signed-off-by: Florian Vaussard Signed-off-by: Suman Anna --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 35

[PATCHv2 13/16] ARM: OMAP2+: extend iommu pdata-quirks to OMAP5

2014-02-13 Thread Suman Anna
OMAP5 has the same iommus as OMAP4, so extend the OMAP4 iommu pdata quirks for OMAP5 as well. Signed-off-by: Suman Anna --- arch/arm/mach-omap2/pdata-quirks.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata-quirks.c index

[PATCHv2 08/16] ARM: OMAP3: remove deprecated CONFIG_OMAP_IOMMU_IVA2

2014-02-13 Thread Suman Anna
-off-by: Florian Vaussard [s-a...@ti.com: revise commit log] Signed-off-by: Suman Anna --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 8 arch/arm/plat-omap/Kconfig | 3 --- 2 files changed, 11 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch

[PATCH 1/4] ARM: dts: OMAP3: Update ISP IOMMU node

2014-02-13 Thread Suman Anna
From: Florian Vaussard Update the IOMMU node for the camera subsystem as per the OMAP IOMMU bindings. Signed-off-by: Florian Vaussard [s-a...@ti.com: corrected interrupt number] Signed-off-by: Suman Anna --- arch/arm/boot/dts/omap3.dtsi | 8 +--- 1 file changed, 5 insertions(+), 3

[PATCH 4/4] ARM: dts: OMAP5: Add IOMMU nodes

2014-02-13 Thread Suman Anna
The IOMMU DT nodes have been added for the DSP and IPU subsystems. The MMUs in OMAP5 are identical to those in OMAP4, including the bus error back capability on IPU. Signed-off-by: Suman Anna --- arch/arm/boot/dts/omap5.dtsi | 17 + 1 file changed, 17 insertions(+) diff --git a

[PATCH 2/4] ARM: dts: OMAP3: Add IVA IOMMU node

2014-02-13 Thread Suman Anna
From: Florian Vaussard Add the DT node for the IOMMU within the DSP subsystem. The entry is disabled to keep in line with the current hwmod usage. Signed-off-by: Florian Vaussard [s-a...@ti.com: split the entry and disable the node] Signed-off-by: Suman Anna --- arch/arm/boot/dts/omap3.dtsi

[PATCH 3/4] ARM: dts: OMAP4: Add IOMMU nodes

2014-02-13 Thread Suman Anna
the IPU sub-system also supports a bus error back capability, not available on the DSP MMU. Signed-off-by: Florian Vaussard [s-a...@ti.com: dma-window updates and bus error back addition] Signed-off-by: Suman Anna --- arch/arm/boot/dts/omap4.dtsi | 17 + 1 file changed, 17

[PATCH 0/4] OMAP IOMMU DTS nodes

2014-02-13 Thread Suman Anna
: dts: OMAP3: Update ISP IOMMU node ARM: dts: OMAP3: Add IVA IOMMU node ARM: dts: OMAP4: Add IOMMU nodes Suman Anna (1): ARM: dts: OMAP5: Add IOMMU nodes arch/arm/boot/dts/omap3.dtsi | 17 ++--- arch/arm/boot/dts/omap4.dtsi | 17 + arch/arm/boot/dts/omap5.dtsi |

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-24 Thread Suman Anna
Mark, Kumar, Rob, On 02/13/2014 07:15 PM, Suman Anna wrote: From: Florian Vaussard This patch adds the iommu bindings for all OMAP2+ SoCs. Apart from the standard bindings used by OMAP peripherals, this patch uses a 'dma-window' (already used by Tegra SMMU) and adds two OMAP custo

Re: [PATCHv2 02/16] iommu/omap: omap_iommu_attach() should return ENODEV, not NULL

2014-02-25 Thread Suman Anna
Hi Laurent, On 02/25/2014 03:13 PM, Laurent Pinchart wrote: Hi Suman, Thank you for the patch. On Thursday 13 February 2014 12:15:33 Suman Anna wrote: From: Florian Vaussard omap_iommu_attach() returns NULL or ERR_PTR in case of error, but omap_iommu_attach_dev() only checks for IS_ERR

Re: [PATCHv2 07/16] iommu/omap: allow enable/disable even without pdata

2014-02-25 Thread Suman Anna
Hi Laurent, On 02/25/2014 03:15 PM, Laurent Pinchart wrote: Hi Suman, Thank you for the patch. On Thursday 13 February 2014 12:15:38 Suman Anna wrote: From: Florian Vaussard When booting with a devicetree, no platform data is provided. Do not prematurely exit iommu_enable() and

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-25 Thread Suman Anna
Hi Laurent, On 02/25/2014 03:26 PM, Laurent Pinchart wrote: Hi Suman, Thank you for the patch. On Thursday 13 February 2014 12:15:34 Suman Anna wrote: From: Florian Vaussard This patch adds the iommu bindings for all OMAP2+ SoCs. Apart from the standard bindings used by OMAP peripherals

Re: [PATCHv2 02/16] iommu/omap: omap_iommu_attach() should return ENODEV, not NULL

2014-02-26 Thread Suman Anna
Hi Laurent, On Tuesday 25 February 2014 16:32:03 Suman Anna wrote: On 02/25/2014 03:13 PM, Laurent Pinchart wrote: On Thursday 13 February 2014 12:15:33 Suman Anna wrote: From: Florian Vaussard omap_iommu_attach() returns NULL or ERR_PTR in case of error, but omap_iommu_attach_dev() only

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-26 Thread Suman Anna
Hi Laurent, On 02/25/2014 08:13 PM, Laurent Pinchart wrote: Hi Suman, On Tuesday 25 February 2014 17:02:35 Suman Anna wrote: On 02/25/2014 03:26 PM, Laurent Pinchart wrote: On Thursday 13 February 2014 12:15:34 Suman Anna wrote: From: Florian Vaussard This patch adds the iommu bindings

Re: [PATCHv2 14/16] ARM: OMAP3: hwmod data: cleanup data for IOMMUs

2014-02-26 Thread Suman Anna
Tony, On 02/26/2014 11:18 AM, Tony Lindgren wrote: * Suman Anna [140213 10:19]: From: Florian Vaussard The irq numbers, ocp address space and device attribute data have all been cleaned up for OMAP3 IOMMUs. All this data is populated via the corresponding dt node. Signed-off-by: Florian

Re: [PATCHv2 10/16] ARM: OMAP2+: use pdata quirks for iommu reset lines

2014-02-26 Thread Suman Anna
Hi Tony, On 02/26/2014 11:17 AM, Tony Lindgren wrote: * Suman Anna [140213 10:19]: The OMAP iommu driver performs the reset management for the iommu instances in processor sub-systems using the omap_device API which are currently supplied as platform data ops. Use pdata quirks to maintain the

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-26 Thread Suman Anna
Hi Laurent, On Wednesday 26 February 2014 11:02:24 Suman Anna wrote: On 02/25/2014 08:13 PM, Laurent Pinchart wrote: On Tuesday 25 February 2014 17:02:35 Suman Anna wrote: On 02/25/2014 03:26 PM, Laurent Pinchart wrote: On Thursday 13 February 2014 12:15:34 Suman Anna wrote: From: Florian

Re: [PATCH 3/4] ARM: dts: OMAP4: Add IOMMU nodes

2014-02-26 Thread Suman Anna
Hi Laurent, On 02/26/2014 03:05 PM, Laurent Pinchart wrote: Hi Suman, Thank you for the patch. On Thursday 13 February 2014 12:22:55 Suman Anna wrote: From: Florian Vaussard Add the IOMMU nodes for the DSP and IPU subsystems. The external address space for DSP starts at 0x2000 in OMAP4

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-26 Thread Suman Anna
Hi Laurent, On 02/26/2014 02:36 PM, Laurent Pinchart wrote: Hi Suman, On Wednesday 26 February 2014 14:23:03 Suman Anna wrote: On Wednesday 26 February 2014 11:02:24 Suman Anna wrote: On 02/25/2014 08:13 PM, Laurent Pinchart wrote: On Tuesday 25 February 2014 17:02:35 Suman Anna wrote: On

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-26 Thread Suman Anna
On 02/26/2014 04:18 PM, Suman Anna wrote: Hi Laurent, On 02/26/2014 02:36 PM, Laurent Pinchart wrote: Hi Suman, On Wednesday 26 February 2014 14:23:03 Suman Anna wrote: On Wednesday 26 February 2014 11:02:24 Suman Anna wrote: On 02/25/2014 08:13 PM, Laurent Pinchart wrote: On Tuesday 25

Re: [PATCHv2 03/16] Documentation: dt: add OMAP iommu bindings

2014-02-26 Thread Suman Anna
Hi Laurent, > On Wednesday 26 February 2014 16:28:08 Suman Anna wrote: On 02/26/2014 04:18 PM, Suman Anna wrote: On 02/26/2014 02:36 PM, Laurent Pinchart wrote: On Wednesday 26 February 2014 14:23:03 Suman Anna wrote: On Wednesday 26 February 2014 11:02:24 Suman Anna wrote: On 02/25/2

Re: [PATCHv2 08/16] ARM: OMAP3: remove deprecated CONFIG_OMAP_IOMMU_IVA2

2014-02-28 Thread Suman Anna
Paul, On 02/28/2014 01:58 PM, Paul Walmsley wrote: On Thu, 13 Feb 2014, Suman Anna wrote: From: Florian Vaussard CONFIG_OMAP_IOMMU_IVA2 was defined originally to avoid conflicting usage by tidspbridge and other iommu users. The same can be achieved by marking the DT node disabled, so remove

[PATCHv3 02/13] iommu/omap: fix error return paths in omap_iommu_attach()

2014-02-28 Thread Suman Anna
when omap_iommu_attach_dev() dereferences the pointer. 2. A try_module_get() failure returns a valid success value as returned from iommu_enable(). Both the above issues have been fixed up to return the proper ERR_PTR. Signed-off-by: Florian Vaussard Signed-off-by: Suman Anna --- drivers

[PATCHv3 03/13] iommu/omap: allow enable/disable even without pdata

2014-02-28 Thread Suman Anna
transitional solution. Signed-off-by: Florian Vaussard Signed-off-by: Suman Anna Acked-by: Laurent Pinchart --- drivers/iommu/omap-iommu.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index 647e4ba..217952b 100644

[PATCHv3 01/13] iommu/omap: convert to devm_* interfaces

2014-02-28 Thread Suman Anna
Use the various devm_ interfaces to simplify the cleanup in probe and remove functions. Signed-off-by: Florian Vaussard Signed-off-by: Suman Anna Acked-by: Laurent Pinchart --- drivers/iommu/omap-iommu.c | 52 +- 1 file changed, 10 insertions(+), 42

[PATCHv3 00/13] OMAP IOMMU DT adaptation for 3.15

2014-02-28 Thread Suman Anna
p: add devicetree support ARM: OMAP3: remove deprecated CONFIG_OMAP_IOMMU_IVA2 Laurent Pinchart (1): iommu/omap: allocate archdata on the fly for DT-based devices Suman Anna (8): iommu/omap: convert to devm_* interfaces iommu/omap: fix error return paths in omap_iommu_attach() iommu/omap: ena

[PATCHv3 08/13] ARM: OMAP3: remove deprecated CONFIG_OMAP_IOMMU_IVA2

2014-02-28 Thread Suman Anna
-off-by: Florian Vaussard [s-a...@ti.com: revise commit log] Signed-off-by: Suman Anna Acked-by: Laurent Pinchart Acked-by: Tony Lindgren Acked-by: Paul Walmsley --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 8 arch/arm/plat-omap/Kconfig | 3 --- 2 files changed, 11

[PATCHv3 05/13] iommu/omap: add devicetree support

2014-02-28 Thread Suman Anna
t it! The legacy boot mode is still supported until OMAP3 is converted to DT-boot only. Signed-off-by: Florian Vaussard [s-a...@ti.com: dev_name adaptation and improved error checking] Signed-off-by: Suman Anna [t...@atomide.com: Ack for arch/arm/*omap* parts] Acked-by: Tony Lindgren --- arch/arm/

[PATCHv3 04/13] Documentation: dt: add OMAP iommu bindings

2014-02-28 Thread Suman Anna
err-back'. Signed-off-by: Florian Vaussard [s-a...@ti.com: split bindings document, add dra7 and bus error back] Signed-off-by: Suman Anna --- .../devicetree/bindings/iommu/ti,omap-iommu.txt| 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentatio

[PATCHv3 09/13] ARM: OMAP3: fix iva mmu programming issues

2014-02-28 Thread Suman Anna
, and there is no automatic power domain switching to ON. Signed-off-by: Suman Anna --- arch/arm/mach-omap2/clockdomains3xxx_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2

[PATCHv3 07/13] iommu/omap: allocate archdata on the fly for DT-based devices

2014-02-28 Thread Suman Anna
name instead of OF name] Signed-off-by: Suman Anna --- drivers/iommu/omap-iommu.c | 45 + 1 file changed, 45 insertions(+) diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index 28bc631..8acea87 100644 --- a/drivers/iommu/omap-iommu.c

[PATCHv3 06/13] iommu/omap: enable bus-error back on supported iommus

2014-02-28 Thread Suman Anna
a bus fault and provide additional debug information. This feature is turned on by default by the driver on iommus supporting it. Signed-off-by: Subramaniam Chanderashekarapuram Signed-off-by: Suman Anna --- drivers/iommu/omap-iommu.c | 2 ++ drivers/iommu/omap-iommu.h | 5 + drivers/iommu

[PATCHv3 13/13] ARM: OMAP2+: extend iommu pdata-quirks to OMAP5

2014-02-28 Thread Suman Anna
OMAP5 has the same iommus as OMAP4, so extend the OMAP4 iommu pdata quirks for OMAP5 as well. Signed-off-by: Suman Anna --- arch/arm/mach-omap2/pdata-quirks.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata-quirks.c index

[PATCHv3 10/13] ARM: OMAP2+: change the ISP device archdata MMU name for DT

2014-02-28 Thread Suman Anna
users have been converted to DT nodes. Signed-off-by: Suman Anna --- arch/arm/mach-omap2/devices.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 0dd6398..e58609b 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm

[PATCHv3 12/13] ARM: OMAP5: hwmod data: add mmu data for ipu & dsp

2014-02-28 Thread Suman Anna
A new MMU hwmod class and data structures are created to represent the MMUs within the IPU and DSP processor subsystems in OMAP5. The MMUs in OMAP5 are identical to those in OMAP4. Signed-off-by: Suman Anna --- arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 83 ++ 1

[PATCHv3 11/13] ARM: OMAP2+: use pdata quirks for iommu reset lines

2014-02-28 Thread Suman Anna
portions are decoupled from omap_hwmod/omap_device into a separate reset driver. This patch adds the pdata quirks for the reset management of iommus within the DSP (OMAP3 & OMAP4) and IPU subsystems (OMAP4). Signed-off-by: Suman Anna --- arch/arm/mach-omap2/pdata-quirks.c

[PATCHv2 0/4] OMAP IOMMU DTS nodes

2014-02-28 Thread Suman Anna
patches as per v2 series of driver DT adaptation series. http://marc.info/?l=linux-omap&m=139231582217147&w=2 Florian Vaussard (3): ARM: dts: OMAP3: Update ISP IOMMU node ARM: dts: OMAP3: Add IVA IOMMU node ARM: dts: OMAP4: Add IOMMU nodes Suman Anna (1): ARM: dts: OMAP5: Add IOMMU

[PATCHv2 2/4] ARM: dts: OMAP3: Add IVA IOMMU node

2014-02-28 Thread Suman Anna
-by: Suman Anna --- arch/arm/boot/dts/omap3.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index f7a47e3..9574a9e 100644 --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -418,6 +418,14

[PATCHv2 1/4] ARM: dts: OMAP3: Update ISP IOMMU node

2014-02-28 Thread Suman Anna
From: Florian Vaussard Update the IOMMU node for the camera subsystem as per the OMAP IOMMU bindings. Signed-off-by: Florian Vaussard [s-a...@ti.com: corrected interrupt number] Signed-off-by: Suman Anna --- arch/arm/boot/dts/omap3.dtsi | 7 --- 1 file changed, 4 insertions(+), 3

[PATCHv2 3/4] ARM: dts: OMAP4: Add IOMMU nodes

2014-02-28 Thread Suman Anna
From: Florian Vaussard Add the IOMMU nodes for the DSP and IPU subsystems. The MMU within the IPU sub-system also supports a bus error back capability, not available on the DSP MMU. Signed-off-by: Florian Vaussard [s-a...@ti.com: IPU bus error back addition] Signed-off-by: Suman Anna

[PATCHv2 4/4] ARM: dts: OMAP5: Add IOMMU nodes

2014-02-28 Thread Suman Anna
The IOMMU DT nodes have been added for the DSP and IPU subsystems. The MMUs in OMAP5 are identical to those in OMAP4, including the bus error back capability on IPU. Signed-off-by: Suman Anna --- arch/arm/boot/dts/omap5.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a

Re: [PATCHv3 00/13] OMAP IOMMU DT adaptation for 3.15

2014-03-02 Thread Suman Anna
Tony, On 02/28/2014 05:00 PM, Tony Lindgren wrote: * Suman Anna [140228 12:46]: Hi Joerg, Tony, This is an updated series of the OMAP IOMMU DT adaptation intended for 3.15 merge window, addressing the comments from the v2 series. This series is rebased onto 3.14-rc4, and the only change to

Re: [PATCHv3 00/13] OMAP IOMMU DT adaptation for 3.15

2014-03-04 Thread Suman Anna
On 03/04/2014 10:04 AM, Joerg Roedel wrote: On Fri, Feb 28, 2014 at 03:00:00PM -0800, Tony Lindgren wrote: * Suman Anna [140228 12:46]: Hi Joerg, Tony, This is an updated series of the OMAP IOMMU DT adaptation intended for 3.15 merge window, addressing the comments from the v2 series. This

Re: [PATCHv3 00/13] OMAP IOMMU DT adaptation for 3.15

2014-03-04 Thread Suman Anna
On 03/04/2014 10:04 AM, Joerg Roedel wrote: On Fri, Feb 28, 2014 at 03:00:00PM -0800, Tony Lindgren wrote: * Suman Anna [140228 12:46]: Hi Joerg, Tony, This is an updated series of the OMAP IOMMU DT adaptation intended for 3.15 merge window, addressing the comments from the v2 series. This

Re: [PATCHv3 00/13] OMAP IOMMU DT adaptation for 3.15

2014-03-05 Thread Suman Anna
Tony, On 03/05/2014 01:33 PM, Tony Lindgren wrote: * Suman Anna [140304 09:03]: On 03/04/2014 10:04 AM, Joerg Roedel wrote: Applied patches 1-7 to my arm/omap branch. Tony, you can pull that branch into your tree if needed (when I pushed it, which will happen today or tomorrow). OK

[PATCH 07/10] ARM: dts: OMAP3: Update ISP IOMMU node

2014-03-05 Thread Suman Anna
From: Florian Vaussard Update the IOMMU node for the camera subsystem as per the OMAP IOMMU bindings. Signed-off-by: Florian Vaussard [s-a...@ti.com: corrected interrupt number] Signed-off-by: Suman Anna --- arch/arm/boot/dts/omap3.dtsi | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH 04/10] ARM: OMAP2+: use pdata quirks for iommu reset lines

2014-03-05 Thread Suman Anna
portions are decoupled from omap_hwmod/omap_device into a separate reset driver. This patch adds the pdata quirks for the reset management of iommus within the DSP (OMAP3 & OMAP4) and IPU subsystems (OMAP4). Signed-off-by: Suman Anna --- arch/arm/mach-omap2/pdata-quirks.c

[PATCH 08/10] ARM: dts: OMAP3: Add IVA IOMMU node

2014-03-05 Thread Suman Anna
-by: Suman Anna --- arch/arm/boot/dts/omap3.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index f7a47e3..9574a9e 100644 --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -418,6 +418,14

[PATCH 09/10] ARM: dts: OMAP4: Add IOMMU nodes

2014-03-05 Thread Suman Anna
From: Florian Vaussard Add the IOMMU nodes for the DSP and IPU subsystems. The MMU within the IPU sub-system also supports a bus error back capability, not available on the DSP MMU. Signed-off-by: Florian Vaussard [s-a...@ti.com: IPU bus error back addition] Signed-off-by: Suman Anna

[PATCH 01/10] ARM: OMAP3: remove deprecated CONFIG_OMAP_IOMMU_IVA2

2014-03-05 Thread Suman Anna
-off-by: Florian Vaussard [s-a...@ti.com: revise commit log] Signed-off-by: Suman Anna Acked-by: Laurent Pinchart Acked-by: Tony Lindgren Acked-by: Paul Walmsley --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 8 arch/arm/plat-omap/Kconfig | 3 --- 2 files changed, 11

[PATCH 05/10] ARM: OMAP5: hwmod data: add mmu data for ipu & dsp

2014-03-05 Thread Suman Anna
A new MMU hwmod class and data structures are created to represent the MMUs within the IPU and DSP processor subsystems in OMAP5. The MMUs in OMAP5 are identical to those in OMAP4. Cc: Paul Walmsley Cc: Benoit Cousson Signed-off-by: Suman Anna --- arch/arm/mach-omap2/omap_hwmod_54xx_data.c

[PATCH 10/10] ARM: dts: OMAP5: Add IOMMU nodes

2014-03-05 Thread Suman Anna
The IOMMU DT nodes have been added for the DSP and IPU subsystems. The MMUs in OMAP5 are identical to those in OMAP4, including the bus error back capability on IPU. Signed-off-by: Suman Anna --- arch/arm/boot/dts/omap5.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a

[PATCH 03/10] ARM: OMAP2+: change the ISP device archdata MMU name for DT

2014-03-05 Thread Suman Anna
users have been converted to DT nodes. Signed-off-by: Suman Anna --- arch/arm/mach-omap2/devices.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 0dd6398..e58609b 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm

[PATCH 02/10] ARM: OMAP3: fix iva mmu programming issues

2014-03-05 Thread Suman Anna
, and there is no automatic power domain switching to ON. Cc: Paul Walmsley Signed-off-by: Suman Anna --- arch/arm/mach-omap2/clockdomains3xxx_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2

[PATCH 00/10] arch/arm OMAP IOMMU patches for 3.15

2014-03-05 Thread Suman Anna
;w=2 [2] http://marc.info/?l=linux-omap&m=139362062805816&w=2 [3] http://marc.info/?l=linux-omap&m=139404802021252&w=2 Florian Vaussard (4): ARM: OMAP3: remove deprecated CONFIG_OMAP_IOMMU_IVA2 ARM: dts: OMAP3: Update ISP IOMMU node ARM: dts: OMAP3: Add IVA IOMMU node ARM: dts: OMAP4

[PATCH 06/10] ARM: OMAP2+: extend iommu pdata-quirks to OMAP5

2014-03-05 Thread Suman Anna
OMAP5 has the same iommus as OMAP4, so extend the OMAP4 iommu pdata quirks for OMAP5 as well. Signed-off-by: Suman Anna --- arch/arm/mach-omap2/pdata-quirks.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata-quirks.c index

Re: [PATCH 00/10] arch/arm OMAP IOMMU patches for 3.15

2014-03-11 Thread Suman Anna
Hi Paul, On 03/05/2014 06:24 PM, Suman Anna wrote: Hi Paul, Benoit, This is a repost as per Tony's request [3] of all the OMAP IOMMU DT support patches that are under arch/arm. The series just assimilates patches 8 through 13 from the v3 OMAP IOMMU DT adaptation for 3.15 series [1], an

Re: [PATCH 00/10] arch/arm OMAP IOMMU patches for 3.15

2014-03-12 Thread Suman Anna
On 03/12/2014 12:04 PM, Tony Lindgren wrote: * Suman Anna [140311 14:52]: Hi Paul, On 03/05/2014 06:24 PM, Suman Anna wrote: Hi Paul, Benoit, This is a repost as per Tony's request [3] of all the OMAP IOMMU DT support patches that are under arch/arm. The series just assimilates patc

Re: [PATCH 2/5] iommu/omap: Fix 'no page for' debug message in flush_iotlb_page()

2014-03-13 Thread Suman Anna
Hi Laurent, On 03/07/2014 06:46 PM, Laurent Pinchart wrote: The flush_iotlb_page() function prints a debug message when no corresponding page was found in the TLB. That condition is incorrectly checked and always resolves to true, given that the for_each_iotlb_cr() loop is never interrupted and

Re: [PATCH 3/5] iommu/omap: Flush the TLB only after updating translation table entries

2014-03-13 Thread Suman Anna
Hi Laurent, On 03/07/2014 06:46 PM, Laurent Pinchart wrote: Flushing the TLB before updating translation entries creates a race condition and can lead to stale TLB entries if a translation request arrives between flushing the TLB and updating the translation entries. As there's no requirement to

Re: [PATCH 5/5] iommu/omap: Fix map protection value handling

2014-03-13 Thread Suman Anna
subsystem once, and see if the e->elsz should be set as MMU_RAM_ELSZ_NONE (I am not too familiar with the Camera usage, so you are probably in a better place than me). If you are good, then with the e->valid change, Acked-by: Suman Anna regards Suman return iopgsz_to_bytes(e

Re: [PATCH 0/5] OMAP IOMMU fixes and IOMMU architecture questions

2014-03-13 Thread Suman Anna
Hi Laurent, On 03/07/2014 06:46 PM, Laurent Pinchart wrote: Hello, This patch set fixes miscellaneous issues with the OMAP IOMMU driver, found when trying to port the OMAP3 ISP away from omap-iovmm to the ARM DMA API. The biggest issue is fixed by patch 5/5, while the other patches fix smaller

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-13 Thread Suman Anna
Hi Laurent, On 03/07/2014 06:46 PM, Laurent Pinchart wrote: The page table entries must be cleaned from the cache before being accessed by the IOMMU. Instead of implementing cache management manually (and ignoring L2 cache), use clean_dcache_area() to make sure the entries are visible to the dev

Re: [PATCH 5/5] iommu/omap: Fix map protection value handling

2014-03-14 Thread Suman Anna
Hi Laurent, On 03/14/2014 04:46 AM, Laurent Pinchart wrote: Hi Suman, Thank you for the review. On Thursday 13 March 2014 19:07:33 Suman Anna wrote: On 03/07/2014 06:46 PM, Laurent Pinchart wrote: The prot flags passed to the IOMMU map handler are defined in include/linux/iommu.h as IOMMU_

Re: [PATCH 3/5] iommu/omap: Flush the TLB only after updating translation table entries

2014-03-14 Thread Suman Anna
Hi Laurent, >> On 03/07/2014 06:46 PM, Laurent Pinchart wrote: Flushing the TLB before updating translation entries creates a race condition and can lead to stale TLB entries if a translation request arrives between flushing the TLB and updating the translation entries. As there's no requiremen

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-14 Thread Suman Anna
Hi Santosh, Laurent, Russell, Arnd, On 03/14/2014 12:51 PM, Santosh Shilimkar wrote: On Friday 14 March 2014 12:38 PM, Laurent Pinchart wrote: Hi Santosh, On Friday 14 March 2014 12:15:11 Santosh Shilimkar wrote: + Russell, Arnd On Thursday 13 March 2014 10:47 PM, Anna, Suman wrote: On 03/0

Re: [PATCH 1/5] iommu/omap: Use the cache cleaning API

2014-03-17 Thread Suman Anna
Hi Santosh, On 03/15/2014 12:54 PM, Santosh Shilimkar wrote: On Friday 14 March 2014 09:49 PM, Suman Anna wrote: Hi Santosh, Laurent, Russell, Arnd, On 03/14/2014 12:51 PM, Santosh Shilimkar wrote: On Friday 14 March 2014 12:38 PM, Laurent Pinchart wrote: Hi Santosh, On Friday 14 March

  1   2   3   >