Re: [PATCH] iommu/vt-d: gracefully handle DMAR units with no supported address widths

2021-01-20 Thread David Woodhouse
On Wed, 2021-01-20 at 18:04 +0100, Greg KH wrote: > I tried applying these to 5.4, 4.19, and 4.14, and they all fail to > build: > > drivers/iommu/dmar.c: In function ‘free_iommu’: > drivers/iommu/dmar.c:1140:35: error: ‘struct intel_iommu’ has no member named > ‘drhd’ > 1140 | if

Re: [PATCH] iommu/vt-d: gracefully handle DMAR units with no supported address widths

2021-01-20 Thread Greg KH
On Wed, Jan 20, 2021 at 03:55:05PM +, David Woodhouse wrote: > On Wed, 2021-01-20 at 13:06 +0100, Greg KH wrote: > > On Wed, Jan 20, 2021 at 09:42:43AM +, David Woodhouse wrote: > > > On Thu, 2020-09-24 at 15:08 +0100, David Woodhouse wrote: > > > > From: David Woodhouse > > > > > > > >

Re: [PATCH] iommu/vt-d: gracefully handle DMAR units with no supported address widths

2021-01-20 Thread David Woodhouse
On Wed, 2021-01-20 at 13:06 +0100, Greg KH wrote: > On Wed, Jan 20, 2021 at 09:42:43AM +, David Woodhouse wrote: > > On Thu, 2020-09-24 at 15:08 +0100, David Woodhouse wrote: > > > From: David Woodhouse > > > > > > Instead of bailing out completely, such a unit can still be used for > > >

Re: [PATCH] iommu/vt-d: gracefully handle DMAR units with no supported address widths

2021-01-20 Thread Greg KH
On Wed, Jan 20, 2021 at 09:42:43AM +, David Woodhouse wrote: > On Thu, 2020-09-24 at 15:08 +0100, David Woodhouse wrote: > > From: David Woodhouse > > > > Instead of bailing out completely, such a unit can still be used for > > interrupt remapping. > > > > Signed-off-by: David Woodhouse >

Re: [PATCH] iommu/vt-d: gracefully handle DMAR units with no supported address widths

2021-01-20 Thread David Woodhouse
On Thu, 2020-09-24 at 15:08 +0100, David Woodhouse wrote: > From: David Woodhouse > > Instead of bailing out completely, such a unit can still be used for > interrupt remapping. > > Signed-off-by: David Woodhouse Could we have this for stable too please, along with the trivial subsequent

Re: [PATCH] iommu/vt-d: gracefully handle DMAR units with no supported address widths

2020-10-07 Thread Joerg Roedel
On Fri, Sep 25, 2020 at 09:52:31AM +0800, Lu Baolu wrote: > > On 9/24/20 10:08 PM, David Woodhouse wrote: > > From: David Woodhouse > > > > Instead of bailing out completely, such a unit can still be used for > > interrupt remapping. > > Reviewed-by: Lu Baolu Applied, thanks.

Re: [PATCH] iommu/vt-d: gracefully handle DMAR units with no supported address widths

2020-09-24 Thread Lu Baolu
On 9/24/20 10:08 PM, David Woodhouse wrote: From: David Woodhouse Instead of bailing out completely, such a unit can still be used for interrupt remapping. Reviewed-by: Lu Baolu Best regards, baolu Signed-off-by: David Woodhouse --- drivers/iommu/intel/dmar.c | 46

[PATCH] iommu/vt-d: gracefully handle DMAR units with no supported address widths

2020-09-24 Thread David Woodhouse
From: David Woodhouse Instead of bailing out completely, such a unit can still be used for interrupt remapping. Signed-off-by: David Woodhouse --- drivers/iommu/intel/dmar.c | 46 +- 1 file changed, 31 insertions(+), 15 deletions(-) diff --git