Re: [PATCH] iommu: of: Fix check for returning EPROBE_DEFER
Hi, On 5/16/2017 7:39 PM, Jonathan Neuschäfer wrote: > Hi, I have a few suggestions on how to make this commit message more > readable: > > On Tue, May 16, 2017 at 10:54:13AM +0530, Sricharan R wrote: >> While returning EPROBE_DEFER for iommu masters > > Add a comma at the end of this line > >> take in to account of iommu nodes that could be > > s/in to/into/ > s/of iommu/of_iommu/ > ok, will correct the above. Regards, Sricharan >> marked in DT as 'status=disabled', in which case >> simply return NULL and let the master's probe >> continue rather than deferring. >> >> Signed-off-by: Sricharan R>> Tested-by: Will Deacon >> Acked-by: Will Deacon > > > Thanks, > Jonathan Neuschäfer > -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] iommu: of: Fix check for returning EPROBE_DEFER
Hi, I have a few suggestions on how to make this commit message more readable: On Tue, May 16, 2017 at 10:54:13AM +0530, Sricharan R wrote: > While returning EPROBE_DEFER for iommu masters Add a comma at the end of this line > take in to account of iommu nodes that could be s/in to/into/ s/of iommu/of_iommu/ > marked in DT as 'status=disabled', in which case > simply return NULL and let the master's probe > continue rather than deferring. > > Signed-off-by: Sricharan R> Tested-by: Will Deacon > Acked-by: Will Deacon Thanks, Jonathan Neuschäfer ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[PATCH] iommu: of: Fix check for returning EPROBE_DEFER
While returning EPROBE_DEFER for iommu masters take in to account of iommu nodes that could be marked in DT as 'status=disabled', in which case simply return NULL and let the master's probe continue rather than deferring. Signed-off-by: Sricharan RTested-by: Will Deacon Acked-by: Will Deacon --- drivers/iommu/of_iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index 9f44ee8..e6e9bec 100644 --- a/drivers/iommu/of_iommu.c +++ b/drivers/iommu/of_iommu.c @@ -118,6 +118,7 @@ static bool of_iommu_driver_present(struct device_node *np) ops = iommu_ops_from_fwnode(fwnode); if ((ops && !ops->of_xlate) || + !of_device_is_available(iommu_spec->np) || (!ops && !of_iommu_driver_present(iommu_spec->np))) return NULL; -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu