Re: [PATCH 00/13] iommu: amd: Add Generic IO Page Table Framework Support
On Thu, Oct 01, 2020 at 09:51:51PM +0700, Suravee Suthikulpanit wrote: > Sure. Let me send out v2 for this with some more clean up. Great, while at it please also change the "iommu: amd:" subjects to "iommu/amd:". Thanks, Joerg ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 00/13] iommu: amd: Add Generic IO Page Table Framework Support
Joerg, On 10/1/20 7:59 PM, Joerg Roedel wrote: On Thu, Sep 24, 2020 at 05:50:37PM +0700, Suravee Suthikulpanit wrote: On 9/24/20 5:34 PM, Joerg Roedel wrote: Hi Suravee, On Wed, Sep 23, 2020 at 10:14:29AM +, Suravee Suthikulpanit wrote: The framework allows callable implementation of IO page table. This allows AMD IOMMU driver to switch between different types of AMD IOMMU page tables (e.g. v1 vs. v2). Is there a reason you created your own framework, there is already an io-pgtable framework for ARM, maybe that can be reused? Actually, this is the same framework used by ARM codes. Sorry if the description is not clear. Ah, right, thanks. I think this should spend some time in linux-next before going upstream. Can you please remind me after the next merge window to pick it up? Thanks, Joerg Sure. Let me send out v2 for this with some more clean up. Thanks, Suravee ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 00/13] iommu: amd: Add Generic IO Page Table Framework Support
On Thu, Sep 24, 2020 at 05:50:37PM +0700, Suravee Suthikulpanit wrote: > > > On 9/24/20 5:34 PM, Joerg Roedel wrote: > > Hi Suravee, > > > > On Wed, Sep 23, 2020 at 10:14:29AM +, Suravee Suthikulpanit wrote: > > > The framework allows callable implementation of IO page table. > > > This allows AMD IOMMU driver to switch between different types > > > of AMD IOMMU page tables (e.g. v1 vs. v2). > > > > Is there a reason you created your own framework, there is already an > > io-pgtable framework for ARM, maybe that can be reused? > > > > Actually, this is the same framework used by ARM codes. > Sorry if the description is not clear. Ah, right, thanks. I think this should spend some time in linux-next before going upstream. Can you please remind me after the next merge window to pick it up? Thanks, Joerg ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 00/13] iommu: amd: Add Generic IO Page Table Framework Support
On 9/24/20 5:34 PM, Joerg Roedel wrote: Hi Suravee, On Wed, Sep 23, 2020 at 10:14:29AM +, Suravee Suthikulpanit wrote: The framework allows callable implementation of IO page table. This allows AMD IOMMU driver to switch between different types of AMD IOMMU page tables (e.g. v1 vs. v2). Is there a reason you created your own framework, there is already an io-pgtable framework for ARM, maybe that can be reused? Actually, this is the same framework used by ARM codes. Sorry if the description is not clear. Suravee ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 00/13] iommu: amd: Add Generic IO Page Table Framework Support
Hi Suravee, On Wed, Sep 23, 2020 at 10:14:29AM +, Suravee Suthikulpanit wrote: > The framework allows callable implementation of IO page table. > This allows AMD IOMMU driver to switch between different types > of AMD IOMMU page tables (e.g. v1 vs. v2). Is there a reason you created your own framework, there is already an io-pgtable framework for ARM, maybe that can be reused? Regards, Joerg ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[PATCH 00/13] iommu: amd: Add Generic IO Page Table Framework Support
The framework allows callable implementation of IO page table. This allows AMD IOMMU driver to switch between different types of AMD IOMMU page tables (e.g. v1 vs. v2). This series refactors the current implementation of AMD IOMMU v1 page table to adopt the framework. There should be no functional change. Subsequent series will introduce support for the AMD IOMMU v2 page table. Thanks, Suravee Suravee Suthikulpanit (13): iommu: amd: Re-define amd_iommu_domain_encode_pgtable as inline iommu: amd: Prepare for generic IO page table framework iommu: amd: Move pt_root to to struct amd_io_pgtable iommu: amd: Convert to using amd_io_pgtable iommu: amd: Declare functions as extern iommu: amd: Move IO page table related functions iommu: amd: Restructure code for freeing page table iommu: amd: Remove amd_iommu_domain_get_pgtable iommu: amd: Rename variables to be consistent with struct io_pgtable_ops iommu: amd: Refactor fetch_pte to use struct amd_io_pgtable iommu: amd: Introduce iommu_v1_iova_to_phys iommu: amd: Introduce iommu_v1_map_page and iommu_v1_unmap_page iommu: amd: Adopt IO page table framework drivers/iommu/amd/Kconfig | 1 + drivers/iommu/amd/Makefile | 2 +- drivers/iommu/amd/amd_iommu.h | 25 ++ drivers/iommu/amd/amd_iommu_types.h | 40 +- drivers/iommu/amd/io_pgtable.c | 580 + drivers/iommu/amd/iommu.c | 630 ++-- drivers/iommu/io-pgtable.c | 3 + include/linux/io-pgtable.h | 2 + 8 files changed, 691 insertions(+), 592 deletions(-) create mode 100644 drivers/iommu/amd/io_pgtable.c -- 2.17.1 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
