Re: [PATCH v2] iommu/arm-smmu: fix null-pointer dereference in arm_smmu_add_device

2017-08-09 Thread David Daney
On 08/08/2017 04:21 AM, Will Deacon wrote: [+ Joerg] On Tue, Aug 08, 2017 at 11:37:40AM +0100, Robin Murphy wrote: On 08/08/17 11:26, Artem Savkov wrote: Commit c54451a "iommu/arm-smmu: Fix the error path in arm_smmu_add_device" removed fwspec assignment in legacy_binding path as redundant

Re: [PATCH v2] iommu/arm-smmu: fix null-pointer dereference in arm_smmu_add_device

2017-08-08 Thread Will Deacon
[+ Joerg] On Tue, Aug 08, 2017 at 11:37:40AM +0100, Robin Murphy wrote: > On 08/08/17 11:26, Artem Savkov wrote: > > Commit c54451a "iommu/arm-smmu: Fix the error path in arm_smmu_add_device" > > removed fwspec assignment in legacy_binding path as redundant which is > > wrong. It needs to be

Re: [PATCH v2] iommu/arm-smmu: fix null-pointer dereference in arm_smmu_add_device

2017-08-08 Thread Robin Murphy
On 08/08/17 11:26, Artem Savkov wrote: > Commit c54451a "iommu/arm-smmu: Fix the error path in arm_smmu_add_device" > removed fwspec assignment in legacy_binding path as redundant which is > wrong. It needs to be updated after fwspec initialisation in > arm_smmu_register_legacy_master() as it is

[PATCH v2] iommu/arm-smmu: fix null-pointer dereference in arm_smmu_add_device

2017-08-08 Thread Artem Savkov
Commit c54451a "iommu/arm-smmu: Fix the error path in arm_smmu_add_device" removed fwspec assignment in legacy_binding path as redundant which is wrong. It needs to be updated after fwspec initialisation in arm_smmu_register_legacy_master() as it is dereferenced later. Without this there is a