Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-03-29 Thread Jacob Pan
On Thu, 29 Mar 2018 10:48:24 +0200 Joerg Roedel wrote: > [ Adding Gary from AMD to Cc ] > > On Mon, Mar 19, 2018 at 09:37:14AM -0700, Jacob Pan wrote: > > On Thu, 15 Mar 2018 14:18:54 +0100 > > Joerg Roedel wrote: > > > > > On Thu, Feb 15, 2018 at

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-03-29 Thread Gary R Hook
On 03/29/2018 03:48 AM, Joerg Roedel wrote: [ Adding Gary from AMD to Cc ] On Mon, Mar 19, 2018 at 09:37:14AM -0700, Jacob Pan wrote: On Thu, 15 Mar 2018 14:18:54 +0100 Joerg Roedel wrote: On Thu, Feb 15, 2018 at 08:38:11AM -0800, Jacob Pan wrote: Just wondering if your

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-03-29 Thread Joerg Roedel
[ Adding Gary from AMD to Cc ] On Mon, Mar 19, 2018 at 09:37:14AM -0700, Jacob Pan wrote: > On Thu, 15 Mar 2018 14:18:54 +0100 > Joerg Roedel wrote: > > > On Thu, Feb 15, 2018 at 08:38:11AM -0800, Jacob Pan wrote: > > > Just wondering if your concern is on the implementation or

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-03-19 Thread Jacob Pan
On Thu, 15 Mar 2018 14:18:54 +0100 Joerg Roedel wrote: > On Thu, Feb 15, 2018 at 08:38:11AM -0800, Jacob Pan wrote: > > Just wondering if your concern is on the implementation or the > > debugfs idea in general. Perhaps have some common IOMMU debugfs? > > My concern mainly is

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-03-15 Thread Joerg Roedel
On Thu, Feb 15, 2018 at 08:38:11AM -0800, Jacob Pan wrote: > Just wondering if your concern is on the implementation or the debugfs > idea in general. Perhaps have some common IOMMU debugfs? My concern mainly is that we add interfaces which reveal potentially security relevant information to

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-02-22 Thread Jacob Pan
On Thu, 22 Feb 2018 08:48:37 +0100 Yves-Alexis Perez wrote: > On Tue, 2018-02-20 at 14:25 -0800, Jacob Pan wrote: > > I didn't know about chipsec but reading the code seems to rely on an > > out-of-tree kernel module. I don't think it matches what we need > > here. > > Yes

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-02-21 Thread Yves-Alexis Perez
On Tue, 2018-02-20 at 14:25 -0800, Jacob Pan wrote: > I didn't know about chipsec but reading the code seems to rely on an > out-of-tree kernel module. I don't think it matches what we need here. Yes good indeed, I had forgot about that. Maybe the userland part is still useful, but there's

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-02-20 Thread Jacob Pan
On Sun, 18 Feb 2018 23:15:32 +0100 Yves-Alexis Perez wrote: > On Tue, 2018-02-13 at 13:40 -0800, Raj, Ashok wrote: > > This version has only hw dumps for now, but we plan to add some > > other things like walking 2nd level page-tables, or get some SVM > > specific data from

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-02-18 Thread Yves-Alexis Perez
On Tue, 2018-02-13 at 13:40 -0800, Raj, Ashok wrote: > This version has only hw dumps for now, but we plan to add some other things > like walking 2nd level page-tables, or get some SVM specific data from the > driver in the future. Hi, I'm not sure how much you know about chipsec [1], but

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-02-15 Thread Jacob Pan
On Thu, 15 Feb 2018 10:53:38 +0100 Joerg Roedel wrote: > On Tue, Feb 13, 2018 at 02:53:32PM -0800, Jacob Pan wrote: > > We did start out with /dev/mem but run into CONFIG_STRICT_DEVMEM > > requirement which is turned on by default. > > libpci is only limited to PCI config space

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-02-15 Thread Joerg Roedel
On Tue, Feb 13, 2018 at 02:53:32PM -0800, Jacob Pan wrote: > We did start out with /dev/mem but run into CONFIG_STRICT_DEVMEM > requirement which is turned on by default. > libpci is only limited to PCI config space access, right? Even if /dev/mem is not an option, I am still not convinced that

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-02-13 Thread Jacob Pan
On Tue, 13 Feb 2018 13:40:02 -0800 "Raj, Ashok" wrote: > Hi Joerg, > > On Tue, Feb 13, 2018 at 03:03:03PM +0100, Joerg Roedel wrote: > > On Fri, Feb 02, 2018 at 04:49:56PM -0800, Sohil Mehta wrote: > > > This series aims to add debugfs support for Intel IOMMU. It > > >

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-02-13 Thread Raj, Ashok
Hi Joerg, On Tue, Feb 13, 2018 at 03:03:03PM +0100, Joerg Roedel wrote: > On Fri, Feb 02, 2018 at 04:49:56PM -0800, Sohil Mehta wrote: > > This series aims to add debugfs support for Intel IOMMU. It exposes IOMMU > > registers, internal context and dumps individual table entries to help debug > >

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-02-13 Thread Joerg Roedel
On Fri, Feb 02, 2018 at 04:49:56PM -0800, Sohil Mehta wrote: > This series aims to add debugfs support for Intel IOMMU. It exposes IOMMU > registers, internal context and dumps individual table entries to help debug > Intel IOMMUs. > > The first patch does the ground work for the following

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-02-04 Thread Andy Shevchenko
On Fri, 2018-02-02 at 16:49 -0800, Sohil Mehta wrote: > Hi All, > > This series aims to add debugfs support for Intel IOMMU. It exposes > IOMMU > registers, internal context and dumps individual table entries to help > debug > Intel IOMMUs. > > The first patch does the ground work for the

[PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-02-02 Thread Sohil Mehta
Hi All, This series aims to add debugfs support for Intel IOMMU. It exposes IOMMU registers, internal context and dumps individual table entries to help debug Intel IOMMUs. The first patch does the ground work for the following patches by reorganizing some Intel IOMMU data structures. The