Re: [PATCH 4/5] iommu/tegra-smmu: Add PCI support

2020-09-28 Thread Nicolin Chen
On Mon, Sep 28, 2020 at 09:55:45AM +0200, Thierry Reding wrote: > On Sat, Sep 26, 2020 at 01:07:18AM -0700, Nicolin Chen wrote: > > +#ifdef CONFIG_PCI > > + if (!iommu_present(_bus_type)) { > > + pci_request_acs(); > > + err = bus_set_iommu(_bus_type, _smmu_ops); > > +

Re: [PATCH 4/5] iommu/tegra-smmu: Add PCI support

2020-09-28 Thread Nicolin Chen
On Sun, Sep 27, 2020 at 01:18:15AM +0300, Dmitry Osipenko wrote: > 26.09.2020 11:07, Nicolin Chen пишет: > ... > > +#ifdef CONFIG_PCI > > + if (!iommu_present(_bus_type)) { > > Is this iommu_present() check really needed? > > > + pci_request_acs(); > > Shouldn't pci_request_acs() be

Re: [PATCH 4/5] iommu/tegra-smmu: Add PCI support

2020-09-28 Thread Thierry Reding
On Sat, Sep 26, 2020 at 01:07:18AM -0700, Nicolin Chen wrote: > This patch simply adds support for PCI devices. > > Signed-off-by: Nicolin Chen > --- > drivers/iommu/tegra-smmu.c | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH 4/5] iommu/tegra-smmu: Add PCI support

2020-09-26 Thread Dmitry Osipenko
26.09.2020 11:07, Nicolin Chen пишет: ... > +#ifdef CONFIG_PCI > + if (!iommu_present(_bus_type)) { Is this iommu_present() check really needed? > + pci_request_acs(); Shouldn't pci_request_acs() be invoked *after* bus_set_iommu() succeeds? > + err =