Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-08-06 Thread Arnd Bergmann
On Mon, Aug 6, 2018 at 2:08 PM Christoph Hellwig wrote: > > On Mon, Aug 06, 2018 at 12:01:34PM +0200, Arnd Bergmann wrote: > > There are a few subtle corner cases here, in particular in which cases > > the new dma_set_mask() behavior on arm64 reports success or > > failure when truncating the

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-08-06 Thread Christoph Hellwig
On Mon, Aug 06, 2018 at 12:01:34PM +0200, Arnd Bergmann wrote: > There are a few subtle corner cases here, in particular in which cases > the new dma_set_mask() behavior on arm64 reports success or > failure when truncating the mask to the bus_dma_mask. Going forward my plan was to make

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-08-06 Thread Arnd Bergmann
On Tue, Jul 31, 2018 at 1:30 PM Robin Murphy wrote: > On 29/07/18 13:32, Arnd Bergmann wrote: > > On Tue, Jul 24, 2018 at 12:16 AM, Robin Murphy wrote: > > Thanks a lot for working on this, this has bugged me for many years, > > and I've discussed possible solutions with lots of people over

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-07-31 Thread Robin Murphy
Hi Arnd, On 29/07/18 13:32, Arnd Bergmann wrote: On Tue, Jul 24, 2018 at 12:16 AM, Robin Murphy wrote: Whilst the common firmware code invoked by dma_configure() initialises devices' DMA masks according to limitations described by the respective properties ("dma-ranges" for OF and _DMA/IORT

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-07-29 Thread Arnd Bergmann
On Tue, Jul 24, 2018 at 12:16 AM, Robin Murphy wrote: > Whilst the common firmware code invoked by dma_configure() initialises > devices' DMA masks according to limitations described by the respective > properties ("dma-ranges" for OF and _DMA/IORT for ACPI), the nature of > the dma_set_mask()

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-07-27 Thread Grygorii Strashko via iommu
On 07/27/2018 05:55 AM, Robin Murphy wrote: > Hi Grygorii, > > Thanks for the report. > > On 27/07/18 00:45, Grygorii Strashko wrote: > [...] >> With this series applied I can't boot TI ARM32 am574x-idk any more. >> >> And log output is full of "DMA mask not set" - > > That's somewhat

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-07-27 Thread Robin Murphy
Hi Grygorii, Thanks for the report. On 27/07/18 00:45, Grygorii Strashko wrote: [...] With this series applied I can't boot TI ARM32 am574x-idk any more. And log output is full of "DMA mask not set" - That's somewhat expected - as the relevant commit message mentions, there will be bugs

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-07-26 Thread Grygorii Strashko via iommu
On 07/23/2018 05:16 PM, Robin Murphy wrote: > Whilst the common firmware code invoked by dma_configure() initialises > devices' DMA masks according to limitations described by the respective > properties ("dma-ranges" for OF and _DMA/IORT for ACPI), the nature of > the dma_set_mask() API leads

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-07-26 Thread Christoph Hellwig
Thanks, applied to the dma-mapping tree. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-07-25 Thread Ard Biesheuvel
On 25 July 2018 at 13:31, Christoph Hellwig wrote: > Hi Robin, > > this series looks fine to me. Do you want me to pull this into the > dma-mapping tree? I'd like to see a few more ACKs from the ACPI/OF/ > IOMMU maintainers though. > This fixes the issue I reported with the on-SoC NIC of the

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-07-25 Thread Will Deacon
On Wed, Jul 25, 2018 at 01:12:56PM +0100, Robin Murphy wrote: > On 25/07/18 12:31, Christoph Hellwig wrote: > >Hi Robin, > > > >this series looks fine to me. Do you want me to pull this into the > >dma-mapping tree? I'd like to see a few more ACKs from the ACPI/OF/ > >IOMMU maintainers though. >

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-07-25 Thread Robin Murphy
On 25/07/18 12:31, Christoph Hellwig wrote: Hi Robin, this series looks fine to me. Do you want me to pull this into the dma-mapping tree? I'd like to see a few more ACKs from the ACPI/OF/ IOMMU maintainers though. Thanks, I was indeed assuming that the dma-mapping tree would be the best

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-07-25 Thread Joerg Roedel
On Wed, Jul 25, 2018 at 01:31:22PM +0200, Christoph Hellwig wrote: > Hi Robin, > > this series looks fine to me. Do you want me to pull this into the > dma-mapping tree? I'd like to see a few more ACKs from the ACPI/OF/ > IOMMU maintainers though. For the IOMMU parts: Acked-by: Joerg

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-07-25 Thread Christoph Hellwig
Hi Robin, this series looks fine to me. Do you want me to pull this into the dma-mapping tree? I'd like to see a few more ACKs from the ACPI/OF/ IOMMU maintainers though. ___ iommu mailing list iommu@lists.linux-foundation.org