Re: [PATCH v4 11/13] iommu/arm-smmu-v3: Improve add_device() error handling

2020-01-15 Thread Robin Murphy
On 14/01/2020 3:25 pm, Will Deacon wrote: On Thu, Dec 19, 2019 at 05:30:31PM +0100, Jean-Philippe Brucker wrote: Let add_device() clean up after itself. The iommu_bus_init() function does call remove_device() on error, but other sites (e.g. of_iommu) do not. Don't free level-2 stream tables bec

Re: [PATCH v4 11/13] iommu/arm-smmu-v3: Improve add_device() error handling

2020-01-15 Thread Will Deacon
On Tue, Jan 14, 2020 at 03:25:39PM +, Will Deacon wrote: > On Thu, Dec 19, 2019 at 05:30:31PM +0100, Jean-Philippe Brucker wrote: > > Let add_device() clean up after itself. The iommu_bus_init() function > > does call remove_device() on error, but other sites (e.g. of_iommu) do > > not. > > >

Re: [PATCH v4 11/13] iommu/arm-smmu-v3: Improve add_device() error handling

2020-01-14 Thread Will Deacon
On Thu, Dec 19, 2019 at 05:30:31PM +0100, Jean-Philippe Brucker wrote: > Let add_device() clean up after itself. The iommu_bus_init() function > does call remove_device() on error, but other sites (e.g. of_iommu) do > not. > > Don't free level-2 stream tables because we'd have to track if we > all