Re: [PATCH v4 3/3] iommu/io-pgtable-arm-v7s: Request DMA32 memory, and improve debugging

2018-12-05 Thread Vlastimil Babka
On 12/5/18 6:48 AM, Nicolas Boichat wrote: > IOMMUs using ARMv7 short-descriptor format require page tables > (level 1 and 2) to be allocated within the first 4GB of RAM, even > on 64-bit systems. > > For level 1/2 pages, ensure GFP_DMA32 is used if CONFIG_ZONE_DMA32 > is defined (e.g. on arm64

Re: [PATCH v4 3/3] iommu/io-pgtable-arm-v7s: Request DMA32 memory, and improve debugging

2018-12-05 Thread Will Deacon
On Wed, Dec 05, 2018 at 06:43:08AM -0800, Christoph Hellwig wrote: > On Wed, Dec 05, 2018 at 02:40:06PM +, Robin Murphy wrote: > > 32-bit Arm doesn't have ZONE_DMA32, but has (or at least had at the time) a > > 2GB ZONE_DMA. Whether we actually need that or not depends on how this all > >

Re: [PATCH v4 3/3] iommu/io-pgtable-arm-v7s: Request DMA32 memory, and improve debugging

2018-12-05 Thread Christoph Hellwig
On Wed, Dec 05, 2018 at 02:40:06PM +, Robin Murphy wrote: > 32-bit Arm doesn't have ZONE_DMA32, but has (or at least had at the time) a > 2GB ZONE_DMA. Whether we actually need that or not depends on how this all > interacts with LPAE and highmem, but I'm not sure of those details off-hand.

Re: [PATCH v4 3/3] iommu/io-pgtable-arm-v7s: Request DMA32 memory, and improve debugging

2018-12-05 Thread Robin Murphy
On 05/12/2018 13:54, Christoph Hellwig wrote: On Wed, Dec 05, 2018 at 01:48:28PM +0800, Nicolas Boichat wrote: IOMMUs using ARMv7 short-descriptor format require page tables (level 1 and 2) to be allocated within the first 4GB of RAM, even on 64-bit systems. +#ifdef CONFIG_ZONE_DMA32

Re: [PATCH v4 3/3] iommu/io-pgtable-arm-v7s: Request DMA32 memory, and improve debugging

2018-12-05 Thread Christoph Hellwig
On Wed, Dec 05, 2018 at 01:48:28PM +0800, Nicolas Boichat wrote: > IOMMUs using ARMv7 short-descriptor format require page tables > (level 1 and 2) to be allocated within the first 4GB of RAM, even > on 64-bit systems. > +#ifdef CONFIG_ZONE_DMA32 > +#define ARM_V7S_TABLE_GFP_DMA GFP_DMA32 >