Re: [PATCH v5 0/5] add non-strict mode support for arm-smmu-v3
On 2018/9/13 1:12, Robin Murphy wrote: > On 12/09/18 17:57, Will Deacon wrote: >> Hi all, >> >> On Wed, Aug 15, 2018 at 09:28:25AM +0800, Zhen Lei wrote: >>> v4 -> v5: >>> 1. change the type of global variable and struct member named "non_strict" >>> from >>> "int" to "bool". >>> 2. cancel the unnecessary parameter "strict" of __arm_lpae_unmap which was >>> added >>> in v4. >>> 3. change boot option "arm_iommu" to "iommu.non_strict". >>> 4. convert __iommu_dma_unmap to use iommu_unmap_fast()/iommu_tlb_sync(), >>> because >>> non-leaf unmaps still need to be synchronous. >>> >>> Thanks for Robin's review comments. >> >> Since this is 90% of the way there now, I suggest Robin picks up what's here >> and incorporates his remaining review comments directly (especially since it >> sounded like Zhen Lei hasn't got much free time lately). With that, I can >> queue this lot via my smmu branch, which already has some stuff queued >> for SMMUv3 and io-pgtable. >> >> Please shout if you have any objections, but I'm keen for this not to >> languish on the lists given how close it is! > > Sure, having got this far I'd like to see it get done too. I'll make some > time and give it a go. Thank you very much. I've been too busy lately, at least I still have no time this week, I also think it's been too long. So sorry and thanks again. > > Robin. > > . > -- Thanks! BestRegards ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v5 0/5] add non-strict mode support for arm-smmu-v3
On 12/09/18 17:57, Will Deacon wrote: Hi all, On Wed, Aug 15, 2018 at 09:28:25AM +0800, Zhen Lei wrote: v4 -> v5: 1. change the type of global variable and struct member named "non_strict" from "int" to "bool". 2. cancel the unnecessary parameter "strict" of __arm_lpae_unmap which was added in v4. 3. change boot option "arm_iommu" to "iommu.non_strict". 4. convert __iommu_dma_unmap to use iommu_unmap_fast()/iommu_tlb_sync(), because non-leaf unmaps still need to be synchronous. Thanks for Robin's review comments. Since this is 90% of the way there now, I suggest Robin picks up what's here and incorporates his remaining review comments directly (especially since it sounded like Zhen Lei hasn't got much free time lately). With that, I can queue this lot via my smmu branch, which already has some stuff queued for SMMUv3 and io-pgtable. Please shout if you have any objections, but I'm keen for this not to languish on the lists given how close it is! Sure, having got this far I'd like to see it get done too. I'll make some time and give it a go. Robin. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v5 0/5] add non-strict mode support for arm-smmu-v3
Hi all, On Wed, Aug 15, 2018 at 09:28:25AM +0800, Zhen Lei wrote: > v4 -> v5: > 1. change the type of global variable and struct member named "non_strict" > from >"int" to "bool". > 2. cancel the unnecessary parameter "strict" of __arm_lpae_unmap which was > added >in v4. > 3. change boot option "arm_iommu" to "iommu.non_strict". > 4. convert __iommu_dma_unmap to use iommu_unmap_fast()/iommu_tlb_sync(), > because >non-leaf unmaps still need to be synchronous. > > Thanks for Robin's review comments. Since this is 90% of the way there now, I suggest Robin picks up what's here and incorporates his remaining review comments directly (especially since it sounded like Zhen Lei hasn't got much free time lately). With that, I can queue this lot via my smmu branch, which already has some stuff queued for SMMUv3 and io-pgtable. Please shout if you have any objections, but I'm keen for this not to languish on the lists given how close it is! Will ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu