Re: [PATCH v6 04/10] gpu: host1x: Add context device management code
Hi Mikko,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on tegra/for-next linus/master v5.19-rc5]
[cannot apply to tegra-drm/drm/tegra/for-next next-20220704]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/intel-lab-lkp/linux/commits/Mikko-Perttunen/Host1x-context-isolation-support/20220621-231339
base: git://anongit.freedesktop.org/drm/drm drm-next
config: arm-randconfig-r005-20220703
(https://download.01.org/0day-ci/archive/20220705/202207051045.jwevr4tw-...@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/intel-lab-lkp/linux/commit/2501beeae7469b805f9f624049fd56643cf6e18e
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review
Mikko-Perttunen/Host1x-context-isolation-support/20220621-231339
git checkout 2501beeae7469b805f9f624049fd56643cf6e18e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1
O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
drivers/gpu/host1x/context.c: In function 'host1x_memory_context_list_init':
>> drivers/gpu/host1x/context.c:80:40: error: 'struct iommu_fwspec' has no
>> member named 'ids'
80 | ctx->stream_id = fwspec->ids[0] & 0x;
|^~
vim +80 drivers/gpu/host1x/context.c
15
16 int host1x_memory_context_list_init(struct host1x *host1x)
17 {
18 struct host1x_memory_context_list *cdl = &host1x->context_list;
19 struct device_node *node = host1x->dev->of_node;
20 struct host1x_memory_context *ctx;
21 unsigned int i;
22 int err;
23
24 cdl->devs = NULL;
25 cdl->len = 0;
26 mutex_init(&cdl->lock);
27
28 err = of_property_count_u32_elems(node, "iommu-map");
29 if (err < 0)
30 return 0;
31
32 cdl->devs = kcalloc(err, sizeof(*cdl->devs), GFP_KERNEL);
33 if (!cdl->devs)
34 return -ENOMEM;
35 cdl->len = err / 4;
36
37 for (i = 0; i < cdl->len; i++) {
38 struct iommu_fwspec *fwspec;
39
40 ctx = &cdl->devs[i];
41
42 ctx->host = host1x;
43
44 device_initialize(&ctx->dev);
45
46 /*
47 * Due to an issue with T194 NVENC, only 38 bits can be
used.
48 * Anyway, 256GiB of IOVA ought to be enough for anyone.
49 */
50 ctx->dma_mask = DMA_BIT_MASK(38);
51 ctx->dev.dma_mask = &ctx->dma_mask;
52 ctx->dev.coherent_dma_mask = ctx->dma_mask;
53 dev_set_name(&ctx->dev, "host1x-ctx.%d", i);
54 ctx->dev.bus = &host1x_context_device_bus_type;
55 ctx->dev.parent = host1x->dev;
56
57 dma_set_max_seg_size(&ctx->dev, UINT_MAX);
58
59 err = device_add(&ctx->dev);
60 if (err) {
61 dev_err(host1x->dev, "could not add context
device %d: %d\n", i, err);
62 goto del_devices;
63 }
64
65 err = of_dma_configure_id(&ctx->dev, node, true, &i);
66 if (err) {
67 dev_err(host1x->dev, "IOMMU configuration
failed for context device %d: %d\n",
68 i, err);
69 device_del(&ctx->dev);
70 goto del_devices;
71 }
72
73 fwspec = dev_iommu_fwspec_get(&ctx->dev);
74 if (!fwspec) {
75 dev_err(host1x->dev, "Context device %d has no
IOMMU!\n", i);
76 device_del(&ctx->dev);
77 goto del_devices;
78 }
79
> 80 ctx->stream_id = fwspec->ids[0] & 0x;
81 }
82
83 return 0;
84
85 del_devices:
86 while (i--)
87 device_del(&cdl->devs[i].dev);
88
Re: [PATCH v6 04/10] gpu: host1x: Add context device management code
Hi Mikko,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on tegra/for-next linus/master v5.19-rc3]
[cannot apply to tegra-drm/drm/tegra/for-next next-20220621]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/intel-lab-lkp/linux/commits/Mikko-Perttunen/Host1x-context-isolation-support/20220621-231339
base: git://anongit.freedesktop.org/drm/drm drm-next
config: arm64-randconfig-r021-20220622
(https://download.01.org/0day-ci/archive/20220622/202206221557.laes8ynq-...@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project
8b8d126598ce7bd5243da7f94f69fa1104288bee)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
#
https://github.com/intel-lab-lkp/linux/commit/2501beeae7469b805f9f624049fd56643cf6e18e
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review
Mikko-Perttunen/Host1x-context-isolation-support/20220621-231339
git checkout 2501beeae7469b805f9f624049fd56643cf6e18e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/gpu/host1x/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
>> drivers/gpu/host1x/context.c:80:28: error: no member named 'ids' in 'struct
>> iommu_fwspec'
ctx->stream_id = fwspec->ids[0] & 0x;
~~ ^
1 error generated.
vim +80 drivers/gpu/host1x/context.c
15
16 int host1x_memory_context_list_init(struct host1x *host1x)
17 {
18 struct host1x_memory_context_list *cdl = &host1x->context_list;
19 struct device_node *node = host1x->dev->of_node;
20 struct host1x_memory_context *ctx;
21 unsigned int i;
22 int err;
23
24 cdl->devs = NULL;
25 cdl->len = 0;
26 mutex_init(&cdl->lock);
27
28 err = of_property_count_u32_elems(node, "iommu-map");
29 if (err < 0)
30 return 0;
31
32 cdl->devs = kcalloc(err, sizeof(*cdl->devs), GFP_KERNEL);
33 if (!cdl->devs)
34 return -ENOMEM;
35 cdl->len = err / 4;
36
37 for (i = 0; i < cdl->len; i++) {
38 struct iommu_fwspec *fwspec;
39
40 ctx = &cdl->devs[i];
41
42 ctx->host = host1x;
43
44 device_initialize(&ctx->dev);
45
46 /*
47 * Due to an issue with T194 NVENC, only 38 bits can be
used.
48 * Anyway, 256GiB of IOVA ought to be enough for anyone.
49 */
50 ctx->dma_mask = DMA_BIT_MASK(38);
51 ctx->dev.dma_mask = &ctx->dma_mask;
52 ctx->dev.coherent_dma_mask = ctx->dma_mask;
53 dev_set_name(&ctx->dev, "host1x-ctx.%d", i);
54 ctx->dev.bus = &host1x_context_device_bus_type;
55 ctx->dev.parent = host1x->dev;
56
57 dma_set_max_seg_size(&ctx->dev, UINT_MAX);
58
59 err = device_add(&ctx->dev);
60 if (err) {
61 dev_err(host1x->dev, "could not add context
device %d: %d\n", i, err);
62 goto del_devices;
63 }
64
65 err = of_dma_configure_id(&ctx->dev, node, true, &i);
66 if (err) {
67 dev_err(host1x->dev, "IOMMU configuration
failed for context device %d: %d\n",
68 i, err);
69 device_del(&ctx->dev);
70 goto del_devices;
71 }
72
73 fwspec = dev_iommu_fwspec_get(&ctx->dev);
74 if (!fwspec) {
75 dev_err(host1x->dev, "Context device %d has no
IOMMU!\n", i);
76 device_del(&ctx->dev);
77 goto del_devices;
78 }
79
> 80 ctx->stream_id = fwspec->ids[0] & 0x;
81 }
82
83 retur
