Re: [PATCH v7 7/7] perf/amd/iommu: Enable support for multiple IOMMUs

2017-01-14 Thread Borislav Petkov
On Sat, Jan 14, 2017 at 09:58:29AM +0700, Suravee Suthikulpanit wrote: > I'll update the commit log to mention > /bus/event_source/devices/amd_iommu_X instead. Yes, so /sys/devices/ contains *all* devices on the system and the iommu ones appear there too but since in the commit message you were

Re: [PATCH v7 7/7] perf/amd/iommu: Enable support for multiple IOMMUs

2017-01-13 Thread Suravee Suthikulpanit
On 1/13/17 18:49, Borislav Petkov wrote: On Fri, Jan 13, 2017 at 05:24:01PM +0700, Suravee Suthikulpanit wrote: IIUC, Perf tools looks at the /sys/devices/x to identify availalble PMUs. Are you planning to have perf tools look at /sys/devices/system/iommu/xxx instead? No, I'm planning

Re: [PATCH v7 7/7] perf/amd/iommu: Enable support for multiple IOMMUs

2017-01-13 Thread Borislav Petkov
On Fri, Jan 13, 2017 at 05:24:01PM +0700, Suravee Suthikulpanit wrote: > IIUC, Perf tools looks at the /sys/devices/x to identify > availalble PMUs. Are you planning to have perf tools look at > /sys/devices/system/iommu/xxx instead? No, I'm planning to understand what do you mean exactly.

Re: [PATCH v7 7/7] perf/amd/iommu: Enable support for multiple IOMMUs

2017-01-13 Thread Suravee Suthikulpanit
Boris, On 1/13/17 00:52, Borislav Petkov wrote: On Mon, Jan 09, 2017 at 09:33:47PM -0600, Suravee Suthikulpanit wrote: This patch adds multi-IOMMU support for perf by exposing an AMD IOMMU PMU for each IOMMU found in the system via: /sys/device/amd_iommu_x /* where x is the IOMMU index.

Re: [PATCH v7 7/7] perf/amd/iommu: Enable support for multiple IOMMUs

2017-01-12 Thread Borislav Petkov
On Mon, Jan 09, 2017 at 09:33:47PM -0600, Suravee Suthikulpanit wrote: > This patch adds multi-IOMMU support for perf by exposing > an AMD IOMMU PMU for each IOMMU found in the system via: > > /sys/device/amd_iommu_x /* where x is the IOMMU index. */ Straight into the top-level devices