Re: [PATCH v9 3/7] iommu/uapi: Introduce enum type for PASID data format

2020-09-24 Thread Jacob Pan
Hi Joerg, On Thu, 24 Sep 2020 10:40:16 +0200, Joerg Roedel wrote: > > On Fri, 18 Sep 2020 11:44:50 +0200, Joerg Roedel > > wrote: > > > On Fri, Sep 11, 2020 at 02:57:52PM -0700, Jacob Pan wrote: > > > > There can be multiple vendor-specific PASID data formats used in > > > > UAPI

Re: [PATCH v9 3/7] iommu/uapi: Introduce enum type for PASID data format

2020-09-24 Thread Joerg Roedel
Hi Jacob, On Fri, Sep 18, 2020 at 10:11:08AM -0700, Jacob Pan wrote: > On Fri, 18 Sep 2020 11:44:50 +0200, Joerg Roedel wrote: > > > On Fri, Sep 11, 2020 at 02:57:52PM -0700, Jacob Pan wrote: > > > There can be multiple vendor-specific PASID data formats used in UAPI > > > structures. This

Re: [PATCH v9 3/7] iommu/uapi: Introduce enum type for PASID data format

2020-09-22 Thread Jacob Pan
Hi Joerg, I sent out v10 with Randy's comments addressed but I didn't change this patch. Does my explanation below make sense? I am hoping to make it in v5.10 since many other pieces depend on it, your guidance is much appreciated. Jacob On Fri, 18 Sep 2020 10:11:08 -0700, Jacob Pan wrote: >

Re: [PATCH v9 3/7] iommu/uapi: Introduce enum type for PASID data format

2020-09-18 Thread Jacob Pan
Hi Joerg, On Fri, 18 Sep 2020 11:44:50 +0200, Joerg Roedel wrote: > On Fri, Sep 11, 2020 at 02:57:52PM -0700, Jacob Pan wrote: > > There can be multiple vendor-specific PASID data formats used in UAPI > > structures. This patch adds enum type with a last entry which makes > > range checking

Re: [PATCH v9 3/7] iommu/uapi: Introduce enum type for PASID data format

2020-09-18 Thread Joerg Roedel
On Fri, Sep 11, 2020 at 02:57:52PM -0700, Jacob Pan wrote: > There can be multiple vendor-specific PASID data formats used in UAPI > structures. This patch adds enum type with a last entry which makes > range checking much easier. But it also makes it much easier to screw up the numbers (which