Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

2019-12-14 Thread David Rientjes via iommu
On Thu, 12 Dec 2019, David Rientjes wrote: > Since all DMA must be unencrypted in this case, what happens if all > dma_direct_alloc_pages() calls go through the DMA pool in > kernel/dma/remap.c when force_dma_unencrypted(dev) == true since > __PAGE_ENC is cleared for these ptes? (Ignoring for

Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

2019-12-13 Thread David Rientjes via iommu
On Thu, 12 Dec 2019, David Rientjes wrote: > Since all DMA must be unencrypted in this case, what happens if all > dma_direct_alloc_pages() calls go through the DMA pool in > kernel/dma/remap.c when force_dma_unencrypted(dev) == true since > __PAGE_ENC is cleared for these ptes? (Ignoring for

Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

2019-12-12 Thread David Rientjes via iommu
On Thu, 28 Nov 2019, Christoph Hellwig wrote: > > So we're left with making dma_pool_alloc(GFP_ATOMIC) actually be atomic > > even when the DMA needs to be unencrypted for SEV. Christoph's suggestion > > was to wire up dmapool in kernel/dma/remap.c for this. Is that necessary > > to be done

Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

2019-11-27 Thread Christoph Hellwig
On Wed, Nov 27, 2019 at 02:11:28PM -0800, David Rientjes wrote: > So we're left with making dma_pool_alloc(GFP_ATOMIC) actually be atomic > even when the DMA needs to be unencrypted for SEV. Christoph's suggestion > was to wire up dmapool in kernel/dma/remap.c for this. Is that necessary > to

Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

2019-11-27 Thread David Rientjes via iommu
On Wed, 18 Sep 2019, Christoph Hellwig wrote: > On Tue, Sep 17, 2019 at 06:41:02PM +, Lendacky, Thomas wrote: > > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > > > --- a/drivers/nvme/host/pci.c > > > +++ b/drivers/nvme/host/pci.c > > > @@ -1613,7 +1613,8 @@ static int

Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

2019-09-18 Thread Christoph Hellwig
On Tue, Sep 17, 2019 at 06:41:02PM +, Lendacky, Thomas wrote: > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > > --- a/drivers/nvme/host/pci.c > > +++ b/drivers/nvme/host/pci.c > > @@ -1613,7 +1613,8 @@ static int nvme_alloc_admin_tags(struct nvme_dev *dev) > >

Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

2019-09-17 Thread Lendacky, Thomas
On 9/17/19 1:23 PM, David Rientjes wrote: > On Mon, 16 Sep 2019, David Rientjes wrote: > >> Brijesh and Tom, we currently hit this any time we boot an SEV enabled >> Ubuntu 18.04 guest; I assume that guest kernels, especially those of such >> major distributions, are expected to work with

Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

2019-09-17 Thread Jens Axboe
On 9/17/19 12:23 PM, David Rientjes wrote: > On Mon, 16 Sep 2019, David Rientjes wrote: > >> Brijesh and Tom, we currently hit this any time we boot an SEV enabled >> Ubuntu 18.04 guest; I assume that guest kernels, especially those of such >> major distributions, are expected to work with

Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

2019-09-17 Thread David Rientjes
On Mon, 16 Sep 2019, David Rientjes wrote: > Brijesh and Tom, we currently hit this any time we boot an SEV enabled > Ubuntu 18.04 guest; I assume that guest kernels, especially those of such > major distributions, are expected to work with warnings and BUGs when > certain drivers are enabled.

Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

2019-09-16 Thread David Rientjes
On Thu, 5 Sep 2019, David Rientjes wrote: > > > Hi Christoph, Jens, and Ming, > > > > > > While booting a 5.2 SEV-enabled guest we have encountered the following > > > WARNING that is followed up by a BUG because we are in atomic context > > > while trying to call set_memory_decrypted: > > >

Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

2019-09-05 Thread David Rientjes via iommu
On Thu, 5 Sep 2019, Christoph Hellwig wrote: > > Hi Christoph, Jens, and Ming, > > > > While booting a 5.2 SEV-enabled guest we have encountered the following > > WARNING that is followed up by a BUG because we are in atomic context > > while trying to call set_memory_decrypted: > > Well,

Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

2019-09-05 Thread Christoph Hellwig
On Wed, Sep 04, 2019 at 02:40:44PM -0700, David Rientjes wrote: > Hi Christoph, Jens, and Ming, > > While booting a 5.2 SEV-enabled guest we have encountered the following > WARNING that is followed up by a BUG because we are in atomic context > while trying to call set_memory_decrypted: Well,