Re: [iovisor-dev] [RFC][Proposal] BPF Control MAP

2019-03-20 Thread Saeed Mahameed
On Tue, 2019-03-19 at 20:04 -0700, Alexei Starovoitov wrote: > On Tue, Mar 19, 2019 at 06:54:08PM +, Saeed Mahameed wrote: > > This is exactly the purpose of map_{create/delete} to define what > > the > > key,vlaue format will be ( it is not going to be ifindex for all > > control maps), to

Re: [iovisor-dev] [RFC][Proposal] BPF Control MAP

2019-03-20 Thread Saeed Mahameed
On Tue, 2019-03-19 at 08:36 -0700, Alexei Starovoitov wrote: > On Fri, Mar 08, 2019 at 08:51:03PM +, Saeed Mahameed wrote: > > Thoughts ? > > It's certainly an interesting idea. I think we need to agree on use > cases > and goals first before bikesheding on the solution. Sure will discuss

Re: [iovisor-dev] [RFC][Proposal] BPF Control MAP

2019-03-20 Thread Toke Høiland-Jørgensen
Saeed Mahameed writes: > In this proposal I am going to address the lack of a unified user API > for accessing and manipulating BPF system attributes, while this > proposal is generic and will work on any BPF subsystem (eBPF attach > points), I will mostly focus on XDP use cases. > > So lately I

Re: [iovisor-dev] [RFC][Proposal] BPF Control MAP

2019-03-19 Thread Alexei Starovoitov
On Wed, Mar 20, 2019 at 04:47:11AM +, Saeed Mahameed wrote: > > consider the following command line, with bpftool that compiled way > before xsk-ring-szie attribute was introduced. perfect. let's agree on the use case first... > $ bpftool xdp set eth0 xsk-ring-size 128 would be great to

Re: [iovisor-dev] [RFC][Proposal] BPF Control MAP

2019-03-19 Thread Alexei Starovoitov
On Tue, Mar 19, 2019 at 06:54:08PM +, Saeed Mahameed wrote: > > This is exactly the purpose of map_{create/delete} to define what the > key,vlaue format will be ( it is not going to be ifindex for all > control maps), to make it clear, the key doesn't have to be an ifindex > at all, it

Re: [iovisor-dev] [RFC][Proposal] BPF Control MAP

2019-03-19 Thread Alexei Starovoitov
On Fri, Mar 08, 2019 at 08:51:03PM +, Saeed Mahameed wrote: > > Thoughts ? It's certainly an interesting idea. I think we need to agree on use cases and goals first before bikesheding on the solution. > > Example use cases (XDP only for now): > > 1) Query XDP stats of all XDP netdevs: >