[iovisor-dev] [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-07 Thread Saeed Mahameed via iovisor-dev
Previously we rang XDP SQ doorbell on every forwarded XDP packet. Here we introduce a xmit more like mechanism that will queue up more than one packet into SQ (up to RX napi budget) w/o notifying the hardware. Once RX napi budget is consumed and we exit napi RX loop, we will flush (doorbell) all

Re: [iovisor-dev] [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-07 Thread Saeed Mahameed via iovisor-dev
On Wed, Sep 7, 2016 at 4:44 PM, John Fastabend via iovisor-dev wrote: > On 16-09-07 05:42 AM, Saeed Mahameed wrote: >> Previously we rang XDP SQ doorbell on every forwarded XDP packet. >> >> Here we introduce a xmit more like mechanism that will queue up more >>

[iovisor-dev] [PATCH RFC 10/11] net/mlx5e: XDP TX forwarding support

2016-09-07 Thread Saeed Mahameed via iovisor-dev
Adding support for XDP_TX forwarding from xdp program. Using XDP, now user can loop packets out of the same port. We create a dedicated TX SQ for each channel that will serve XDP programs that return XDP_TX action to loop packets back to the wire directly from the channel RQ RX path. For that RX

[iovisor-dev] [PATCH RFC 04/11] net/mlx5e: Build RX SKB on demand

2016-09-07 Thread Saeed Mahameed via iovisor-dev
For non-striding RQ configuration before this patch we had a ring with pre-allocated SKBs and mapped the SKB->data buffers for device. For robustness and better RX data buffers management, we allocate a page per packet and build_skb around it. This patch (which is a prerequisite for XDP) will

[iovisor-dev] [PATCH RFC 02/11] net/mlx5e: Introduce API for RX mapped pages

2016-09-07 Thread Saeed Mahameed via iovisor-dev
From: Tariq Toukan Manage the allocation and deallocation of mapped RX pages only through dedicated API functions. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 46

Re: [iovisor-dev] README: [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-09 Thread Saeed Mahameed via iovisor-dev
On Fri, Sep 9, 2016 at 6:22 AM, Alexei Starovoitov via iovisor-dev wrote: > On Thu, Sep 08, 2016 at 10:11:47AM +0200, Jesper Dangaard Brouer wrote: >> >> I'm sorry but I have a problem with this patch! > > is it because the variable is called 'xdp_doorbell'? >

Re: [iovisor-dev] [PATCH RFC 00/11] mlx5 RX refactoring and XDP support

2016-09-09 Thread Saeed Mahameed via iovisor-dev
On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: > Hi All, > > This patch set introduces some important data path RX refactoring > addressing mlx5e memory allocation/management improvements and XDP support. > > Submitting as RFC since we would like to get an early