[iovisor-dev] [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-07 Thread Saeed Mahameed via iovisor-dev
Previously we rang XDP SQ doorbell on every forwarded XDP packet. Here we introduce a xmit more like mechanism that will queue up more than one packet into SQ (up to RX napi budget) w/o notifying the hardware. Once RX napi budget is consumed and we exit napi RX loop, we will flush (doorbell) all

Re: [iovisor-dev] [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-07 Thread Saeed Mahameed via iovisor-dev
On Wed, Sep 7, 2016 at 4:44 PM, John Fastabend via iovisor-dev wrote: > On 16-09-07 05:42 AM, Saeed Mahameed wrote: >> Previously we rang XDP SQ doorbell on every forwarded XDP packet. >> >> Here we introduce a xmit more like mechanism that will queue up more >>

[iovisor-dev] [PATCH RFC 10/11] net/mlx5e: XDP TX forwarding support

2016-09-07 Thread Saeed Mahameed via iovisor-dev
Adding support for XDP_TX forwarding from xdp program. Using XDP, now user can loop packets out of the same port. We create a dedicated TX SQ for each channel that will serve XDP programs that return XDP_TX action to loop packets back to the wire directly from the channel RQ RX path. For that RX

[iovisor-dev] [PATCH RFC 04/11] net/mlx5e: Build RX SKB on demand

2016-09-07 Thread Saeed Mahameed via iovisor-dev
For non-striding RQ configuration before this patch we had a ring with pre-allocated SKBs and mapped the SKB->data buffers for device. For robustness and better RX data buffers management, we allocate a page per packet and build_skb around it. This patch (which is a prerequisite for XDP) will

[iovisor-dev] [PATCH RFC 02/11] net/mlx5e: Introduce API for RX mapped pages

2016-09-07 Thread Saeed Mahameed via iovisor-dev
From: Tariq Toukan Manage the allocation and deallocation of mapped RX pages only through dedicated API functions. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 46

Re: [iovisor-dev] [PATCH RFC 08/11] net/mlx5e: XDP fast RX drop bpf programs support

2016-09-07 Thread Tom Herbert via iovisor-dev
On Wed, Sep 7, 2016 at 7:48 AM, Saeed Mahameed wrote: > On Wed, Sep 7, 2016 at 4:32 PM, Or Gerlitz wrote: >> On Wed, Sep 7, 2016 at 3:42 PM, Saeed Mahameed wrote: >> >>> Packet rate performance testing was done with pktgen

Re: [iovisor-dev] [PATCH RFC 03/11] net/mlx5e: Implement RX mapped page cache for page recycle

2016-09-07 Thread Jesper Dangaard Brouer via iovisor-dev
On Wed, 7 Sep 2016 15:42:24 +0300 Saeed Mahameed wrote: > From: Tariq Toukan > > Instead of reallocating and mapping pages for RX data-path, > recycle already used pages in a per ring cache. > > We ran pktgen single-stream benchmarks, with

Re: [iovisor-dev] [PATCH RFC 11/11] net/mlx5e: XDP TX xmit more

2016-09-07 Thread Jesper Dangaard Brouer via iovisor-dev
On Wed, 7 Sep 2016 19:57:19 +0300 Saeed Mahameed wrote: > On Wed, Sep 7, 2016 at 6:32 PM, Eric Dumazet wrote: > > On Wed, 2016-09-07 at 18:08 +0300, Saeed Mahameed wrote: > >> On Wed, Sep 7, 2016 at 5:41 PM, Eric Dumazet